From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 657BC33121F for ; Thu, 28 May 2026 06:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949667; cv=none; b=gw5Ng3je7qwY+W8o4YjxxMPQ2h20JHbpx6YiRUserI78YjC02DuLJt41EyJPkV6DYwTd2kND6eNQ+QI1vs+fbae5qwlhZMzW82QWE2k7qxodfocD/MWHYpqh/cNuFoUpVnGSIaIF8r/UAwSUHJ4zK3FvvbyFkp6jgS1Gp4WZRpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779949667; c=relaxed/simple; bh=rrIpuPhtFOkBtiPO8Uyy1YE1r7l+QH3qO4N1e8wuBEg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qZYq9CquTQmmqyJKWGLHIsJ8BUzj8WXgeYdMvhK1dqK8iOy75xIK/y4bN3Cyce3aujgyp8ebKBTRVAkOu9QVaGf7AoS8WIKKHlmZMyoLcHNpidK0Xg114/TRuuvsd3Rx0rgbfCuecTIvqY5obVEBADMJW+tYgKIvGbyBiYiqwrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=N/22HH52; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=6N+IcKdl; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="N/22HH52"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="6N+IcKdl" Date: Thu, 28 May 2026 08:27:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1779949663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwOaY4RNQyDX3FN8D+3gMoORx5Ors6iRbe/5nQOLE0g=; b=N/22HH523c7G3uFErene4NCyMSRk0DIweaYEWlOeL4O2UGBp1qQGRHJGalLXhXFJtmkN87 DvqXS4hnozc3RgkAAQXxa3BQVGGoJ4QU/m37I9/Ke/5Z/ld8ibaRNcPJGQt76BmsFXyUUG QxB8FpMmG+RyGeNSH/L2DOPrsNOWAkvpUnbFUkD7lBvHC6/xWxgauIBOQxzStAQ2wgifF/ 5Sc/yge7ftXdJTpsSqc3FpbS8hBlERaqLqTaPtYYR513BDNaNhOPfbwOVRzLsBnC//kZjA yWf9YGscVLjuA2syvyRESFyhnzuA01MQJPjqP6H9giRNcCT1CEUshwdJGYem9w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1779949663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwOaY4RNQyDX3FN8D+3gMoORx5Ors6iRbe/5nQOLE0g=; b=6N+IcKdl7y3ZlKSNkTneUwCE0X8A9a3zA79+QpXWtRDin+G0j9kjxIq4qcEQCdYSJF1vPr fv51KpPFqAJ6RMBw== From: Sebastian Andrzej Siewior To: Jakub Kicinski Cc: netdev@vger.kernel.org, Andrew Lunn , Chintan Vankar , Danish Anwar , Daolin Qiu , "David S. Miller" , Eric Dumazet , Felix Maurer , Neelima Muralidharan , Paolo Abeni , Praneeth Bajjuri , Pratheesh Gangadhar TK , Richard Cochran , Simon Horman , Vignesh Raghavendra , Willem de Bruijn Subject: Re: [PATCH net-next v5 8/8] selftests: hsr: Add test for the inline PTP header on HSR Message-ID: <20260528062742.453G-OkS@linutronix.de> References: <20260527-hsr_ptp-v5-0-158a7633eac0@linutronix.de> <20260527-hsr_ptp-v5-8-158a7633eac0@linutronix.de> <20260527121227.40bf085c@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260527121227.40bf085c@kernel.org> On 2026-05-27 12:12:27 [-0700], Jakub Kicinski wrote: > On Wed, 27 May 2026 17:08:58 +0200 Sebastian Andrzej Siewior wrote: > > Requested-by: Felix Maurer > > Please don't invent tags? If you want to say that Felix asked for this > just say it in English. okay. > > --- a/tools/testing/selftests/net/hsr/Makefile > > +++ b/tools/testing/selftests/net/hsr/Makefile > > @@ -7,8 +7,11 @@ TEST_PROGS := \ > > hsr_redbox.sh \ > > link_faults.sh \ > > prp_ping.sh \ > > + hsr_ptp.sh \ > > # end of TEST_PROGS > > > > TEST_FILES += hsr_common.sh > > > > +TEST_GEN_PROGS := hsr_ptp_test > > TEST_GET_FILES otherwise kselftest thinks its a test and tries to run > it (which of course fails on > > + if (!slaveA || !slaveB || !hsr_dev) { > + fprintf(stderr, "Missing network devices\n"); > + exit(EXIT_FAILURE); > + } > > given there are no arguments passed in) Oh. I did replace it with TEST_GEN_FILES. Sebastian