From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F59389107; Thu, 28 May 2026 10:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964572; cv=none; b=I3W0owdXX+oEBhImKrOF68pDByjd1Emon3vhacLzrXkW+EqljGysfiuaQkIfEvFdF65cgsrIMGJVzJ3EiKKOYjmqhCgAhcjGAurx5qXlLe1SXyerciNUpi1ghGThlK+vz84c5tBPgyFW8voeUsYLu/oinNX8Brt0yeQBXpm3Ncs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779964572; c=relaxed/simple; bh=oyRkC6DV+Zw+pUbqAVANJkRxwHT0zJuoSs4Ip3KUOT0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WQTTuzhJ06DUlGZ1QUW+HAe1StTf6mEUjDcNarhiEuc+xRZ8OHI/OrC/Dq8TzEed66AtaeRZyXBHQ7djaZWg0x6qNtMuGJz/HICZ5AjIcGLDRCYfCUH5ORUy4+uI0DHpKwjoIgbpY5MFl0HZk43QFBad5oPgpHyu1UHOJZMTxNE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IABOLKkh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IABOLKkh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 184E71F000E9; Thu, 28 May 2026 10:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779964571; bh=ZKSloW17DUYpt4WwltD0X9HnAYEXYhUSfwzRcfTBnxA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IABOLKkhVLvBKSKnjOa5gpA6raIJHm28qMWjxR6lzfgr7SHRFRgfzQbn9dsW4fXTh GEOjgRVgZvpzftraoAnhJZvnEWlNxCo41g/QFQeXSFA+/5Sg+MZ73PFTccZrEUp6dN ID6CcJ/N8pxnSxGaqY8hwreuu9fh4jkzOC3nIzMfaykHoJ8qjiBX5cdr9+7M/+IVjB 3CQiexyx/vqqQiBwukkNaXJM0xT9PnH2tvEHp2568dIIaUhGfVPVRHsANB/j4JNGSL KK7Cj+QvPFUU8kcYmEFSKeJyu+aOCA46ifrffPHaR4H5/z9u+OOZuD4OJryfX+mtcO AxnKKes/FYEDQ== Date: Thu, 28 May 2026 11:36:06 +0100 From: Simon Horman To: Javen Cc: "hkallweit1@gmail.com" , "nic_swsd@realtek.com" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Patch net-next v5 0/7] r8169: add RSS support for RTL8127 Message-ID: <20260528103606.GS2256768@horms.kernel.org> References: <20260520031603.700-1-javen_xu@realsil.com.cn> <20260522092004.GJ1506108@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 25, 2026 at 07:15:23AM +0000, Javen wrote: > >On Wed, May 20, 2026 at 11:15:56AM +0800, javen wrote: > >> From: Javen Xu > >> > >> This patch series adds RSS (Receive Side Scaling) support for the > >> r8169 ethernet driver, specifically for RTL8127 (RTL_GIGA_MAC_VER_80). > >> > >> RSS enables packet distribution across multiple receive queues, which > >> can significantly improve network throughput on multi-core systems by > >> allowing parallel processing of incoming packets. > > > >... > > > >Hi Javen, > > > >There are AI generated reviews of this patchset available on bogh > >https://netdev-ai.bots.linux.dev/sashiko/ and https://sashiko.dev > > > >I would appreciate it if you could look over them and address any issues that > >effect the functionality of your patchset. I do not suggest expanding the scope > >of this patchset, but rather treating other issues in the context of possible > >follow-up. > > Hi, > > r8169_main.c used request_irq() before, but I was suggested to use pci_request_irq() to generate the name for each irq dynamically. And I find that in pci_request_irq(), irqflags is fixed to IRQF_SHARED. So I want to know how can I handle with this situation? I am unsure. But if that is the advice you received then I would suggest sticking with it.