From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B965637FF41 for ; Fri, 29 May 2026 18:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780078469; cv=none; b=QRUww9aY9ZGB3K0jYWnqQ7M4YNigP7qwdZJdkfOS++St4H2PwR+Rda1BdBAblZwHQfEW1OEIgXXgZAxDm/DQJtU8FuxkJakLreWY5jEYGlQabaV+0RZeGFTjwhnJQ5jX68eBRCP6UNKWFT6m4bnCtjZI+BMIgp+pf78Ofnvlj3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780078469; c=relaxed/simple; bh=djud74fEkjZ1cuVtWqVEB3mg5zr3iJlNGnii4o1fz08=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AcNWs1ZTGCQ3zJtKjs80lOQ2mGBu3E/0bM5dNdV4nEcDVvHLHNs6YIzfJM/rCs70BMiOZsa3AhV/oAYklDfFNdOB70S25S8nOS7DB2+LQ2ZAKq6olUx//t3hrnui3kDfia8wvWZsW5GQghE9b5uJzJhlVyE6af3kg6SS8BSJbiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hxMr+V4x; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hxMr+V4x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B7461F00893; Fri, 29 May 2026 18:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780078468; bh=rbS0n6KZIxHYMFHP35Mv2lJdUf0WP5ElCIgkJP1fFYI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=hxMr+V4xcqHz5T7Ojr/D75LQl3PdH9IG/clIXWgpReWmo68LaaLu+6MdHFAEhuBfY 6vgTpE/Mkh0D6Jix4ipgvBFv3eyuVaHhQSQWZ13aixhS3Uy8cTes7WITLT31qLsUt6 4idHS91Y6T+qqcQ6ODoCc0tkbjnQszP8epH2MW9pFV9/aWe6nBLpxpA7/858Ea3V8J Gxy42ugyplZ3SSsIsky0jchJkEVRbuXUko6AJm+ra+pNgfuRuF/yQzPxyzYvBWqWDO uZHBC3M0gX+Qql32h7SY+jOq+dy3aVYI7RZWWDfSrzYgmz0FlJL6Q/zo5XPtE2YS46 tpBIXpoWgAwDA== Date: Fri, 29 May 2026 11:14:27 -0700 From: Jakub Kicinski To: Steffen Klassert Cc: Paolo Abeni , David Miller , Herbert Xu , , Alessandro Schino <7991aleschino@gmail.com> Subject: Re: [PATCH 5/9] esp: fix page frag reference leak on skb_to_sgvec failure Message-ID: <20260529111427.249957c2@kernel.org> In-Reply-To: References: <20260527084148.3489759-1-steffen.klassert@secunet.com> <20260527084148.3489759-6-steffen.klassert@secunet.com> <0902bdb9-2746-45fd-ba4d-8e5b96617b8b@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 29 May 2026 07:52:07 +0200 Steffen Klassert wrote: > > > -static void esp_ssg_unref(struct xfrm_state *x, void *tmp, struct sk_buff *skb) > > > +static void esp_ssg_unref(struct xfrm_state *x, void *tmp, struct sk_buff *skb, bool already_unref) > > > { > > > struct crypto_aead *aead = x->data; > > > int extralen = 0; > > > @@ -113,7 +113,7 @@ static void esp_ssg_unref(struct xfrm_state *x, void *tmp, struct sk_buff *skb) > > > /* Unref skb_frag_pages in the src scatterlist if necessary. > > > * Skip the first sg which comes from skb->data. > > > */ > > > - if (req->src != req->dst) > > > + if (already_unref || req->src != req->dst) > > > for (sg = sg_next(req->src); sg; sg = sg_next(sg)) > > > skb_page_unref(page_to_netmem(sg_page(sg)), > > > skb->pp_recycle); > > > > Sashiko points the above is still unsafe: > > For the original patch submission, sashiko reported 'failed > to apply' because it was targeted to the ipsec tree. Now > with the full pull request it applied and it found issues, > but now it is too late for me to fix this. > > Would it be possible to integrate subtrees of net and net-next > into the netdev CI? This would avoid such problems in future. Sashiko is run by Google, tho. IDK why it fails to apply the patches sometimes, happens for us too :(