From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A996E30568E for ; Fri, 29 May 2026 11:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780053853; cv=none; b=YmY6vyV2E3B+R7RK/HKds2FtCMB9WNzxRvud3fUTUFvUGegfuI1z6vqy50swfMAkQ8qb1DVaMIprhLYDAgrVaI1d9mD5McxE0rynML1/YV3cTu6v/QT/abgw8VeQ+ID+I8AIzSrPChqLuBqCFkYMZ+rZbHoO4BtMCp6qsmUYu0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780053853; c=relaxed/simple; bh=B1y96rqGwNSiG9tkqeRlG4pFEWX/QUJYaUyiOpBN5nA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uS1VaNwBQaVW5KWT2rLB85WvY2plQ9vaeZxmkwCEDTlK5Wj1Rc/ZNnwveOEJyPlCXGXIJXf70yiwwGqabWsyPExF/k+Oxb6DtUEZnPFgrIJnhdeaW5apV9ASVPTwrBSk4e9jkyrXdOXY+gGUz0SMUwNyzd4ybBpbbjM1knuEeew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=06y/6K51; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rjlNw/QX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=GTrv1T6L; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=nyueWRl1; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="06y/6K51"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rjlNw/QX"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="GTrv1T6L"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="nyueWRl1" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD4B866D88; Fri, 29 May 2026 11:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780053850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YTn2G8m1Cj0tWjuCma31TyjVpPXr8sPbadJLHAXAkQc=; b=06y/6K51PjLADS2+PB0UNbSj290BsklO5wS6klkGm3aPWpmH7OH6yrZ5yXcEwyh0NB89sA tHU3nHZDysdCw+mbL/0MTJoJ7yXZ6KWiPM8ZBTdUj8dCd9tgstZPjXwII0ajt89Fx18cUW sh/sgsm260N0+lmbMe5o+01ZMw7067c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780053850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YTn2G8m1Cj0tWjuCma31TyjVpPXr8sPbadJLHAXAkQc=; b=rjlNw/QXzLzyiKOOHuuZq853SosZk1ZGcX5wYwetCCdFuOSBE3Dh+vzi3QE8S2YEcDOpmp 9RnV+XrNG783+nDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780053849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YTn2G8m1Cj0tWjuCma31TyjVpPXr8sPbadJLHAXAkQc=; b=GTrv1T6Lby9aBA3hN7+5mkQuQqxrANZM+y1haxskf0srzfynQZqpXiwZ+yrHr/6xfKXoIi 4j3scFuVqahJRUGQLm2rLG43oZqS0PpxYPUW1kceMigf0vppcl8tmu6mE5RSy+A1kcixUh f2T1IYrh/hKAc3ROSGGB1o+svgYj7tU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780053849; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YTn2G8m1Cj0tWjuCma31TyjVpPXr8sPbadJLHAXAkQc=; b=nyueWRl1bEuOoN52wRm8WFjS0O99hf+c/mRHrhYsPpYIlQ+D5dc2O9yYjwHpHROUHj7t7h t5udXbKgNZ3lDfAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 21D0C779A7; Fri, 29 May 2026 11:24:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id FsdABVl3GWo1SAAAD6G6ig (envelope-from ); Fri, 29 May 2026 11:24:09 +0000 From: Fernando Fernandez Mancera To: netdev@vger.kernel.org Cc: yuhuang@redhat.com, justin.iurman@gmail.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, idosch@nvidia.com, dsahern@kernel.org, sbrivio@redhat.com, Fernando Fernandez Mancera , Chris Adams Subject: [PATCH net v2] Revert "ipv6: preserve insertion order for same-scope addresses" Date: Fri, 29 May 2026 13:23:57 +0200 Message-ID: <20260529112357.5079-1-fmancera@suse.de> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Spam-Score: -1.30 X-Spam-Level: X-Spamd-Result: default: False [-1.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[13]; MIME_TRACE(0.00)[0:+]; TAGGED_RCPT(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,gmail.com,kernel.org,google.com,davemloft.net,nvidia.com,suse.de,cmadams.net]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com] Chris Adams reported that preserving insertion order for same-scope addresses is causing SSH connections to be dropped after stopping a VM while running NetworkManager. NetworkManager caches the IPv6 address configuration, when a RA arrives, it determines the list of addresses to configure and checks if the addresses are already in the right order in the kernel. If they aren't, NetworkManager removes and re-adds them to achieve the desired order. As the order changes, NetworkManager is confused and reconfigures the addresses on every update. In addition, this would also affect to cloud tooling that relies on IPv6 addresses order to identify primary and secondaries addresses. This reverts commit cb3de96eea66f5e4a580086c6a1be46e765f97f4. Fixes: cb3de96eea66 ("ipv6: preserve insertion order for same-scope addresses") Reported-by: Chris Adams Closes: https://lore.kernel.org/netdev/20260521135310.GC977@cmadams.net/ Signed-off-by: Fernando Fernandez Mancera --- v2: updated commit description to make it more accurate --- net/ipv6/addrconf.c | 2 +- tools/testing/selftests/net/ioam6.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 5476b6536eb7..bb84a78b80f6 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1013,7 +1013,7 @@ ipv6_link_dev_addr(struct inet6_dev *idev, struct inet6_ifaddr *ifp) list_for_each(p, &idev->addr_list) { struct inet6_ifaddr *ifa = list_entry(p, struct inet6_ifaddr, if_list); - if (ifp_scope > ipv6_addr_src_scope(&ifa->addr)) + if (ifp_scope >= ipv6_addr_src_scope(&ifa->addr)) break; } diff --git a/tools/testing/selftests/net/ioam6.sh b/tools/testing/selftests/net/ioam6.sh index b2b99889942f..845c26dd01a9 100755 --- a/tools/testing/selftests/net/ioam6.sh +++ b/tools/testing/selftests/net/ioam6.sh @@ -273,8 +273,8 @@ setup() ip -netns $ioam_node_beta link set ioam-veth-betaR name veth1 &>/dev/null ip -netns $ioam_node_gamma link set ioam-veth-gamma name veth0 &>/dev/null - ip -netns $ioam_node_alpha addr add 2001:db8:1::2/64 dev veth0 &>/dev/null ip -netns $ioam_node_alpha addr add 2001:db8:1::50/64 dev veth0 &>/dev/null + ip -netns $ioam_node_alpha addr add 2001:db8:1::2/64 dev veth0 &>/dev/null ip -netns $ioam_node_alpha link set veth0 up &>/dev/null ip -netns $ioam_node_alpha link set lo up &>/dev/null ip -netns $ioam_node_alpha route add 2001:db8:2::/64 \ -- 2.54.0