From: Oscar Maes <oscmaes92@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 2/2] pcnet32: switch to napi_alloc_skb() and napi_gro_receive()
Date: Sun, 31 May 2026 18:51:40 +0200 [thread overview]
Message-ID: <20260531165140-oscmaes92@gmail.com> (raw)
In-Reply-To: <20260528121210.40b0e493@kernel.org>
On Thu, May 28, 2026 at 12:12:10PM -0700, Jakub Kicinski wrote:
> On Thu, 28 May 2026 19:05:10 +0200 Oscar Maes wrote:
> > On Thu, May 28, 2026 at 08:07:48AM -0700, Jakub Kicinski wrote:
> > > On Thu, 28 May 2026 16:28:51 +0200 Oscar Maes wrote:
> > > > On Mon, May 25, 2026 at 08:45:28AM -0700, Jakub Kicinski wrote:
> > > > Intel x86
> > >
> > > LOL. Please. Which _hardware_ platform.
> > > Or to ask more directly - is it QEMU.
> >
> > It was indeed tested on QEMU.
> > Either way, the performance measurements were just a sanity check.
> > Changing the code to use the modern API is just better.
>
> Please don't waste our time with optimizations to unused code.
It's not unused code. VMware emulates this device by default in some cases.
I've encountered it when installing QubesOS in vmware which is based on
relatively modern Linux.
next prev parent reply other threads:[~2026-05-31 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:54 [PATCH net-next v2 0/2] pcnet32: switch to napi_alloc_skb() and napi_gro_receive() Oscar Maes
2026-05-25 12:54 ` [PATCH net-next v2 1/2] pcnet32: stop holding device spin lock during napi_complete_done Oscar Maes
2026-05-25 13:53 ` Andrew Lunn
2026-05-25 15:46 ` Jakub Kicinski
2026-05-25 12:54 ` [PATCH net-next v2 2/2] pcnet32: switch to napi_alloc_skb() and napi_gro_receive() Oscar Maes
2026-05-25 15:45 ` Jakub Kicinski
2026-05-28 14:28 ` Oscar Maes
2026-05-28 15:07 ` Jakub Kicinski
2026-05-28 17:05 ` Oscar Maes
2026-05-28 19:12 ` Jakub Kicinski
2026-05-31 16:51 ` Oscar Maes [this message]
2026-05-31 20:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260531165140-oscmaes92@gmail.com \
--to=oscmaes92@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox