From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70F329BD9A; Tue, 2 Jun 2026 02:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780365945; cv=none; b=MswBAcQevQXob1d+U3qMLkqwXlviL3YPEFnjz79+oW2vS9rm7c7URSBaEcp2SmfdTeQdA6qHLFMNf63F8XDTbi8gqz+fHNe/+5KSqfwkRtPoOnVJkndlyQ1tAe70Q0qNj/lYzfhuPKiIExwnr7cCkm5JTXvfSwzXCHk3546gPlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780365945; c=relaxed/simple; bh=w7M5+j6fJiAOKd5dxDioY+7cIY443e18YGMg4MDNaM0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vg21Bj/f9/vFNiyxVlqhUCD5gIuac1IA/jaKgoyFvvBc6Ar2ydf2lYNvtXA1OG54VN9cdvNEP4Dej/OfnVv9cqAnHPAEhwfqahzXkYV/DPrux32jX87fsnLbfzlFDnn7/yytji0fx+OgjqEXPl28dbDHTYNA2fb2FFEh3d0/4to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ab6aXmc3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ab6aXmc3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 069701F00893; Tue, 2 Jun 2026 02:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780365944; bh=4AjsROMV02U/yvIBd08KPpw+N48FHKFpRq2b7ZoH1hw=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Ab6aXmc3kNpZ/JPb6d5/ueMOt9kxuRgk3W+cQ57XapKwR9VpZGQ8fIMwo15CWgZzd KgSS/zKPVvgQukE4LjLg88xEwxVXvWDi0aHRfFLAw12IaJrp9FuBNo6HD6X2h5LAaN qnfM32TbkiwbrIEPorNazHW4EtURDbtfVw7SRKl+StYeMutrOjLMQMGv8e0cSzU38d 410TD/5eFuaU2Re8kp7WZzsUz+2UPLSloOOoZErPRdt8g2iq3lJR45xTLKZOEcMbaV ae/lwZdmfuN0XaP3EaKWX2UiPl7bBh0wCnsth258v/Xn5OV0rGiabdQc53kPoVfo/q ayzBTG7rUG2sw== Date: Mon, 1 Jun 2026 19:05:43 -0700 From: Jakub Kicinski To: Yizhou Zhao Cc: netdev@vger.kernel.org, "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Kees Cook , linux-kernel@vger.kernel.org, Yuxiang Yang , Ao Wang , Xuewei Feng , Qi Li , Ke Xu Subject: Re: [PATCH net] vlan: prevent unsigned underflow in VLAN MTU calculation over MACsec Message-ID: <20260601190543.33d42ef8@kernel.org> In-Reply-To: <20260529062135.70490-1-zhaoyz24@mails.tsinghua.edu.cn> References: <20260529062135.70490-1-zhaoyz24@mails.tsinghua.edu.cn> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 29 May 2026 14:21:33 +0800 Yizhou Zhao wrote: > + if (netif_reduces_vlan_mtu(real_dev)) { > + if (real_dev->mtu < VLAN_HLEN) > + return -EINVAL; > + max_mtu = real_dev->mtu - VLAN_HLEN; > + } else { > + max_mtu = real_dev->mtu; > + } Does not apply, please rebase on net and repost. -- pw-bot: cr