From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A18633B6FB for ; Tue, 2 Jun 2026 05:41:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780378902; cv=none; b=XFLPbr7q3QsvtScunrhbdakbG55omZlrIQPqhGKUKWEYBh+2XdRtElpxGsz6hMoId+XATXcCmsRI3An4zKs9Kep5SsN5X/WbyqoHV2bnOWfUS2xCAJ71TUg00cCJIJI3TRkmYmUpN/pYkyW29Djh0rbvtq6o5vprb31fLZsXDR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780378902; c=relaxed/simple; bh=n7V2vfC1JbI4WrA583Y6PpTcqWcjqmKB0sQIXUnDtEc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iiPaI/IdJTpZ2Hj/FdrnCGvZMoam1wniMiReRPw8eCnl3SxkYS9e4whAWS5GMZyK7vNXMNylOFPaQsuy39zYxgWK+H0Nr6UWIByUZaCfZxSXf/OuxD/BBzTE8LllXqTpwbtV+XBkNaHQXpfkyY+u+bFMKIkaTo+OmxmnC926xEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F4kx/Yrz; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F4kx/Yrz" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8423f53332aso768681b3a.3 for ; Mon, 01 Jun 2026 22:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780378900; x=1780983700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b87cwHT2BrTigjVd+6bwq58aCoITji6mCL2XtGIvkXs=; b=F4kx/YrztuquMauH+60ndA5ypfuxlqfdZPjfAHjDcdCTIDEU60N1qzQPzbvihhxzl2 Jl++Er5WItmtWxzcepURJgCn3GlDsh03IVMuSTd77kW8oYf6jLbLsCIqA9QqQ0MC1qLR C1nwYLnExPKOGLmYvyGMBuBxgM8EQXfvG5Xlcgaw8w0RoB37zc8V5ZNRefM6a7GlQDNh +gS2vqPa18d0riFTC3rGCmtiNlYqswVktX2b0NSrFyq73vrokmdU0+6U40JyjQpzWV82 ptl8PdcWBrG6g72V+tklqOWkaZONIXYKy1C3dqCKvK+/Bz15r2pttNaOjkAx97vW7Tku 0i7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780378900; x=1780983700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b87cwHT2BrTigjVd+6bwq58aCoITji6mCL2XtGIvkXs=; b=n/z/XrmTLS98mYYVgPeyIArywYrH5n4hVvmv4ktX2nRuYGq8E+WtRqtoly0Noh16Hy /sHRNT7nECO1URgSu1S7YDReYNRJpf42yMGTBdP3lKLQrAmA2E4p8T82LEqI2ODXu9my Q3S8AarPSjFdcqX/Hxzfb9Mi/1vmndXgHx9QPor7p/JEde9Yjg5kdGGdj3GpPNkLy2I8 kUAqXeDsdgUbjp++Wyln5wOi3jx31eih3lkWIlTXCMIczi+HU7z1bC40SYgHE84inpz2 Ji5Jj8j2VngpW/KrPhPgtUpsaGxEXX2lVqD09/KcBSr6VYsBbIvAFkiuB3gFxPd7CifP 7QZw== X-Forwarded-Encrypted: i=1; AFNElJ8ftCXjb2D0XjvS/0KwoW6OKWrJSV1BbzgOkAk6qc7/NBxQYuSKXa6QNILjCSb/AkiJQ4Cfk30=@vger.kernel.org X-Gm-Message-State: AOJu0YwZcQst3ea4PEK8pRXVEd6/JNY6yqQOG2s/fugGkdvl+ro2we2S XRFHWiOE6LZaoH5HYfxdBGe4x8OiW4dX4HQPLnFZf/DEBFloreVvJ+aF X-Gm-Gg: Acq92OEIB92u05P26M0QsczvbbAxGKTkbdlMQgaNUTuBLkON8F2MqJ+S1eeeD4HVLxw vFVq2QcTmqAnjLwFm7TOYXavkIvGF6EmrwMJuhb/m8wI1lzPoDeSxnElstMu03T1BUCWaoet+nr wP3Anl0DPtLNiA4oa9ZmcAVzJBSDzdv1DoRlNb72UhotLehvegg5pt6+7/hJniACQ5sHwk0M9Qd imLVgVH/MnO0x/csCPOm5t7qucpg5Wzp+2RyuwJ6eUHmtXCi3O/DQ3EtHzwx2ImS+A5a99fbPgz R0t5MPm6Tm4XjooXO3k9QUpYBcrR/u3Mmvwr11u9e9AmAdAE2ltLsuxIVJrQvGFe6ns18Wx3J5C XLUQVgnvRnjT2O0m5W1Y8kKZutbnSZTYNDQuDm3BbtFNSVZSleIJW4Ys9lDoK9ooqS/SfMa7h2V XdP22XYFKJ35iJwj0zIskOQccdPslteAa67NgSDg== X-Received: by 2002:a05:6a00:301c:b0:842:6fce:6171 with SMTP id d2e1a72fcca58-8426fce6cadmr1818446b3a.3.1780378900295; Mon, 01 Jun 2026 22:41:40 -0700 (PDT) Received: from soyboi ([2402:8780:1073:19a3:f977:6a92:60c9:fc08]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842596e63f4sm4020138b3a.29.2026.06.01.22.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 22:41:39 -0700 (PDT) From: Robertus Diawan Chris To: alex.aring@gmail.com, stefan@datenfreihafen.org, miquel.raynal@bootlin.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH] mac802154: Prevent overwrite return code in mac802154_perform_association() Date: Tue, 2 Jun 2026 12:41:33 +0700 Message-ID: <20260602054133.470293-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL, the return value assigned to either "-ERANGE" or "-EPERM" but this return value will be overwritten to 0 after exiting the conditional scope. So, jump to clear_assoc label to preserve the return value when assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL. This is reported by Coverity Scan as "Unused value". Fixes: fefd19807fe9 ("mac802154: Handle associating") Signed-off-by: Robertus Diawan Chris --- I am still not sure how to test this change. I look around the function and use the previous error handler as a guidance to make this change, like error handler for "No ASSOC REQ ACK received" and "No ASSOC RESP received". Thank you. net/mac802154/scan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c index 0a31ac8d8415..300d4584533e 100644 --- a/net/mac802154/scan.c +++ b/net/mac802154/scan.c @@ -594,6 +594,7 @@ int mac802154_perform_association(struct ieee802154_sub_if_data *sdata, "Negative ASSOC RESP received from %8phC: %s\n", &ceaddr, local->assoc_status == IEEE802154_PAN_AT_CAPACITY ? "PAN at capacity" : "access denied"); + goto clear_assoc; } ret = 0; base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8 -- 2.54.0