From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b1-smtp.messagingengine.com (fhigh-b1-smtp.messagingengine.com [202.12.124.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174C93D16FC for ; Tue, 2 Jun 2026 09:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780393245; cv=none; b=KRFfL+SLSVWmSSgdsQuEifWjSvI9X7jtEbMCw65U6u96h01bDvyq6vS9epmreKbXE8fv0b0FxTfiL2v7LhXpFfYZWiciKzkZFDfWgB5z/BGweJtOTXYFh2sfHQ7HGIS91SL/jvCZRpY1L+I/m8fAFg+5x3sj5bQ3s0F7PFbVKAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780393245; c=relaxed/simple; bh=YNV0P3187X4bJ5z4JkmK9JtfzpaUHgewjelhe1nrlro=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xb592GNvgA7ksr4qZelV5z3lLX8fyeminfB3R4PivEOh5P/8SM2IP5tyugnP/X9QXYU5J0hIbifBUOdaNS7cOZ0eLkNwxdLM6dPDveRVbYlNPINUYU34JXrEJ7y9vIUNnjV20MNf7QC6Hxj15EAQwhP16hp8PzxHpup46pLrxqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im; spf=pass smtp.mailfrom=fastmail.im; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b=BYMu9odB; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=MW3OIvtO; arc=none smtp.client-ip=202.12.124.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.im header.i=@fastmail.im header.b="BYMu9odB"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="MW3OIvtO" Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfhigh.stl.internal (Postfix) with ESMTP id 155B27A0135; Tue, 2 Jun 2026 05:40:43 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Tue, 02 Jun 2026 05:40:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.im; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1780393242; x= 1780479642; bh=4R4rqPdhmvE+WG+QusgyxV/z9YIC3V1TUrnQrZRogrE=; b=B YMu9odBb/31Kr93QoXkQ8T/9I/FVKADMZqFbPECq1zpyJ12cAgk33NQx5Cj79wbo nUFY0AdtFczGf7cnu+pj6dkDaRgDmSwZn8GMUXkafvyQ06HhTrg/NbgAcUXQTJKf yKY2UMM8I82yl3Jw897NukoWzqM9ZprutpHJ2Px3y0FH3rvpA2Rldr6MfDiwBj80 +ykfLOjB1uRPgovLdOiztumrvs6RmSLRLxaN1IsGFK9uJ8Fs6FAxuyWZEiXU8vcs 0TWf9rxmfj7Prqne3d+28NSly7vEPdrDAKsLJagqbMy3uAalsumvptEBrwdC8VcB kOQC9apU6zx5WvQ1Q0D3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1780393242; x=1780479642; bh=4 R4rqPdhmvE+WG+QusgyxV/z9YIC3V1TUrnQrZRogrE=; b=MW3OIvtO0ZBfbMEbH axYtRJ7nCZ+8qn89NI99ouMJ2bqTmtKS2xMlXD0TQF2IGnze8gnSbr4H9PXr+24Z 1z6eetxkZu7SKAf/912Vpo8dT0zEQP53zE9ke03bIDe+JO4384PJfOQBXsGcq1Ot WcheJVMUQfx2WxSwNhVFTDmQVh4EbZGLj9gjoUcKxUy6Zb5mUPdGmoPQlxL1Z6wg FaueGx9oRWy6sBCxc83DFP01Kw3sZAkJT9GMJG2jfM3KHX7BQM3lw7wp0TUH3/uc SlRT7cVo9BehttPY89lSm5ChAgk4FWknM0src8q7SqgFzi79F4yTkfbQf2Ig45fT 2urrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEhfRVF1SKd+GLnfZgooACD6hO2wJk+Zyim2TRNm1FE/QAPLbyY/pSJn/R1ebWLdW 8ddtkh5p3JaW9uH4aGXXJD9FFQUSHMnrYr3OV6ljKpntCcdaC7UcJhE5szseZ2k5GRYeY/ Lhvny7OVdXCJitqlBn5HEyGYj7iWIQvNEHlPT+KL5jFhxFuoRwHHVQ/22ycwjLowSE3ABx zXZkS8ByTzJZqhEcDidmGmaCAG3Qn6XL4ySjcbiTRQa5YDOaCIcA3JQ2yezAI+o892cMlK BfpgTV+tXB0+ERUl9fBWyXQ8QW4KFHxt8Ha5ZmXsci0qG/g3QjJvVgWrbXt6zdycTVBBDQ DpaaBFThvZRqxILdG3h/72zr9LoQ3B716c9LrpPfnH9gi842erty3oMj8Dct9MXisdy1+q /uxpWO2MlNPI+rU+Q7ETcIiNyjh77ysibLCO/89x+REDP7NjU2TYavX65Eq8P1FwYyKITK iPZwZWQV1m3Z9GFNR1ilz42fo1K9wtDzc374BGsSfw50wIsWee0PrU93lW57flFY6JvdeK eGmDBGkvu2qYY2Qy0BWyMdZL2EbyFVbNJx1LIKTOh5EyK75ldokw753plvZFHUyYJ/SCOX 39LDW/cQ8dr9GPqtOy9BrfmPBebaQ8MxujJoBjdftb52ZiwhYNBcemWuUl4Q X-ME-Proxy: Feedback-ID: i559e4809:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Jun 2026 05:40:41 -0400 (EDT) From: Alice Mikityanska To: Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xin Long , Willem de Bruijn , Willem de Bruijn , David Ahern , Nikolay Aleksandrov Cc: Shuah Khan , Stanislav Fomichev , Andrew Lunn , Simon Horman , Florian Westphal , netdev@vger.kernel.org, Alice Mikityanska Subject: [PATCH net-next v6 02/11] geneve: Fix off-by-one comparing with GRO_LEGACY_MAX_SIZE Date: Tue, 2 Jun 2026 11:39:22 +0200 Message-ID: <20260602093931.516281-3-alice.kernel@fastmail.im> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260602093931.516281-1-alice.kernel@fastmail.im> References: <20260602093931.516281-1-alice.kernel@fastmail.im> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alice Mikityanska GRO_LEGACY_MAX_SIZE = 65536; total_len being 65536 is too big to fit into a u16. As can be seen in skb_gro_receive, packets bigger or equal to gro_max_size (or GRO_LEGACY_MAX_SIZE) are dropped with -E2BIG. Apply the same boundary to geneve_post_decap_hint to avoid writing 65536 to a 16-bit iph->tot_len field with an overflow. Fixes: fd0dd796576e ("geneve: use GRO hint option in the RX path") Signed-off-by: Alice Mikityanska Reviewed-by: Willem de Bruijn --- drivers/net/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index e8ff03ed87dc..ae8ff31cffa1 100644 --- a/drivers/net/geneve.c +++ b/drivers/net/geneve.c @@ -603,7 +603,7 @@ static int geneve_post_decap_hint(const struct sock *sk, struct sk_buff *skb, ipv6h = (void *)skb->data + gro_hint->nested_nh_offset; iph = (struct iphdr *)ipv6h; total_len = skb->len - gro_hint->nested_nh_offset; - if (total_len > GRO_LEGACY_MAX_SIZE) + if (total_len >= GRO_LEGACY_MAX_SIZE) return -E2BIG; /* -- 2.54.0