From: Stephen Hemminger <stephen@networkplumber.org>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 iproute2-next] iplink_geneve: Support IFLA_GENEVE_LOCAL and IFLA_GENEVE_LOCAL6.
Date: Tue, 2 Jun 2026 12:59:51 -0700 [thread overview]
Message-ID: <20260602125951.50492267@phoenix.local> (raw)
In-Reply-To: <20260523061102.2762452-1-kuniyu@google.com>
On Sat, 23 May 2026 06:10:58 +0000
Kuniyuki Iwashima <kuniyu@google.com> wrote:
> + } else if (!matches(*argv, "local")) {
> + NEXT_ARG();
> + check_duparg(&attrs, IFLA_GENEVE_LOCAL, "local",
> + *argv);
> + get_addr(&saddr, *argv, AF_UNSPEC);
> + if (!is_addrtype_inet_not_multi(&saddr))
> + invarg("invalid local address", *argv);
No new code can use matches(), it creates problems with conflicting
short arguments.
next prev parent reply other threads:[~2026-06-02 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 6:10 [PATCH v1 iproute2-next] iplink_geneve: Support IFLA_GENEVE_LOCAL and IFLA_GENEVE_LOCAL6 Kuniyuki Iwashima
2026-06-02 18:38 ` Kuniyuki Iwashima
2026-06-02 19:59 ` Stephen Hemminger [this message]
2026-06-02 20:06 ` Kuniyuki Iwashima
2026-06-02 20:26 ` Stephen Hemminger
2026-06-02 20:30 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602125951.50492267@phoenix.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox