From: Jakub Kicinski <kuba@kernel.org>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Yury Norov" <yury.norov@gmail.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mieczyslaw Nalewaj" <namiltd@yahoo.com>
Subject: Re: [net-next PATCH v11 4/9] net: dsa: realtek: rtl8365mb: prepare for multiple source files
Date: Wed, 3 Jun 2026 17:52:44 -0700 [thread overview]
Message-ID: <20260603175244.0950094e@kernel.org> (raw)
In-Reply-To: <20260531-realtek_forward-v11-4-50d60f5717e8@gmail.com>
On Sun, 31 May 2026 23:53:19 -0300 Luiz Angelo Daros de Luca wrote:
> The trailing backslash in the Makefile is deliberate. It allows for new
> files to be added without clobbering git history.
FWIW maybe just my personal preference but I'd add a trailing comment
for this, IOW:
rtl8365mb-objs := rtl8365mb_main.o \
# end of rtl8365mb-objs
This way it's less likely someone will add a line here without
realizing it will become part of the previous statement.
next prev parent reply other threads:[~2026-06-04 0:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 2:53 [net-next PATCH v11 0/9] net: dsa: realtek: rtl8365mb: bridge offloading and VLAN support Luiz Angelo Daros de Luca
2026-06-01 2:53 ` [net-next PATCH v11 1/9] net: dsa: realtek: rtl8365mb: use ERR_PTR Luiz Angelo Daros de Luca
2026-06-01 2:53 ` [net-next PATCH v11 2/9] net: dsa: realtek: rtl8365mb: reject unsupported topologies Luiz Angelo Daros de Luca
2026-06-01 8:12 ` Linus Walleij
2026-06-01 2:53 ` [net-next PATCH v11 3/9] net: dsa: realtek: rtl8365mb: use dsa helpers for port iteration Luiz Angelo Daros de Luca
2026-06-01 2:53 ` [net-next PATCH v11 4/9] net: dsa: realtek: rtl8365mb: prepare for multiple source files Luiz Angelo Daros de Luca
2026-06-04 0:52 ` Jakub Kicinski [this message]
2026-06-01 2:53 ` [net-next PATCH v11 5/9] net: dsa: realtek: rtl8365mb: add table lookup interface Luiz Angelo Daros de Luca
2026-06-01 2:53 ` [net-next PATCH v11 6/9] net: dsa: realtek: rtl8365mb: add VLAN support Luiz Angelo Daros de Luca
2026-06-04 0:56 ` Jakub Kicinski
2026-06-01 2:53 ` [net-next PATCH v11 7/9] net: dsa: realtek: rtl8365mb: add port_bridge_{join,leave} Luiz Angelo Daros de Luca
2026-06-01 2:53 ` [net-next PATCH v11 8/9] net: dsa: realtek: rtl8365mb: add FDB support Luiz Angelo Daros de Luca
2026-06-01 2:53 ` [net-next PATCH v11 9/9] net: dsa: realtek: rtl8365mb: add bridge port flags Luiz Angelo Daros de Luca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603175244.0950094e@kernel.org \
--to=kuba@kernel.org \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=luizluca@gmail.com \
--cc=namiltd@yahoo.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox