From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D984142E83; Thu, 4 Jun 2026 00:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780534580; cv=none; b=kuf6DYkTMNN3SL/B02Y8BAoROx9o+SLgK7QP4GRHXLndwU3dexECD8CZz9ZvUliUvWr6r/WuM2FO795klWqdJj6MbTE3vcqdemF5laKeXdvOsrXdBqcMnmTM9KlfgFlHrYGAPl+MXbOf/WZKf+m51ownneoL8zeO9zAL/j1Ikz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780534580; c=relaxed/simple; bh=95imCsvpAnyWr4bvzUI/rNWCdu9iRhNtZFL+o/3lHiE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X0bOWpouwoPoAmr2Fx4u+4mPCGEOMwso82I4pXSWmz1QYYP0Bk7p9NDBU6LzS5MT2xVHO8gLJ8nW2NXLJl70+UItejtiaTOmiJmgzIUGXnt/SaxsIvAwyNPcZmmDN0V4lj247JOPTN6kInP5W5nTXIiQH1+OZEku421XKU9PsGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YvndKmqL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YvndKmqL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EF921F00893; Thu, 4 Jun 2026 00:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780534578; bh=gF8d4Q9scRWFseYExzUgYTOi59LCj0LaGZy3d3dDve8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=YvndKmqLSxRnxToW2b4/W+5/EBi06MPP0fGsWL203pGBgeGlAktfzgsrJT7vYBe59 b2p+CbolYOkIgEmPdtskDCazZbZFDWacg8Oii+G+wiyxOTigx1aqNyny1KJFcPDqc1 xFp+Uje2tNG42ZQZoA9wlJqQ5SU7Y0vZcLk+dHd8gMwOREf3DZoR80TN4546eKjsPF mCz8ANbSLJhelyWxL/SLPs7IXHRsY2xaUBIuJZMNl8thQKn+PgnslrSdff8Y0ueHLj RRUF21YcfYs1+7mgo9z4YbPR/Bffp0xsuw14lqVup4OyilO0SKFoSoO522e8IVIxA+ H3bL7IN1+9/PQ== Date: Wed, 3 Jun 2026 17:56:17 -0700 From: Jakub Kicinski To: Luiz Angelo Daros de Luca Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Linus Walleij , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , Yury Norov , Rasmus Villemoes , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yury Norov , Abdulkader Alrezej , Mieczyslaw Nalewaj Subject: Re: [net-next PATCH v11 6/9] net: dsa: realtek: rtl8365mb: add VLAN support Message-ID: <20260603175617.7cc4f660@kernel.org> In-Reply-To: <20260531-realtek_forward-v11-6-50d60f5717e8@gmail.com> References: <20260531-realtek_forward-v11-0-50d60f5717e8@gmail.com> <20260531-realtek_forward-v11-6-50d60f5717e8@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 31 May 2026 23:53:21 -0300 Luiz Angelo Daros de Luca wrote: > +#define RTL_VLAN_ERR(msg) \ > + do { \ > + const char *__msg = (msg); \ > + \ > + if (extack) \ > + NL_SET_ERR_MSG_FMT_MOD(extack, "%s", __msg); \ > + dev_err(priv->dev, "%s", __msg); \ > + } while (0) Please don't duplicate errors. The errors are either due to something being wrong / unsupported in the request in which case they should go via extack. Or they are unexpected system errors (IO errors, timeouts and such) in which case just return errno and print to the logs so that the admin has a permanent record. There's a tracepoint in NL_SET_ERR_MSG() if you want to sniff user errors. -- pw-bot: cr