From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9D83402BB6 for ; Wed, 3 Jun 2026 20:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780517673; cv=none; b=YsOy4aCcyNOGOGnSU3wXI1ba8l7+luHa1zPR5FPfUzktXTmz5s9mt3kcMwPy9i1EXBogKnPis/5G6ah2Xm3yp6etpbIPMLRmc1qJknUZ8KNSR2eUHyx+tHLV9jueJqYscK/HR1p41qWUysCk1eKr7Oa8/KJeUhXAIrUTZYM2nQM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780517673; c=relaxed/simple; bh=sU7a+cepX5Yo0+ifY+l6yrlTvgf21pD972JHq2GklJE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UeeJzFI0P7mHhNm0xg7Ys+31fCC3uUW8B6TSOJbETzmzJ9DJxqUTo1kxkq+4I4nA8rbI5uRXaG1k66dchTsUmHxl6WFFD4Dap3hbNg8uNojkR0wPBVxBr/zS9FFA6OdrUCqNHhYwbqNuaaLA71KLmZnYX+7cKtvEZJm4PkGvi9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iIA9+Bcu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iIA9+Bcu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED3A41F00893; Wed, 3 Jun 2026 20:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780517672; bh=uXXxZ8FqhgPcL5gSEGJG8WHkuHR2HXsCZkOQLVDE8ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iIA9+Bcujh2XJOug029cRJ57fG4IiDUEMcuFERvMchutZIsdI9j87UIa5KC5Sl9AK AHWihb9Ktf2RkJFOZXiAO+0qq8S4SfT3GBKolSqqKRUkPHIHDIZ80BRrJRjj1gb86k EGZa60f3LQ+wgM8mCMhvIgYsr1yiranjjdexkOXd5Wc/7TI8yePDDkBmdW8oIJHphX kfIzwiTav+dWB3KCzpeXLyUEH6WfGv5DDbljKN1YnFXy92acJCeoroTPXb94Qo6Fv1 S61VrIs5mPf16IgblEkmOxxdiSYVoXVFP1j6fi9gP819cAkF0ba244JFBAjJ2NtOFr gBjlnC8fkTcTg== Date: Wed, 3 Jun 2026 21:14:28 +0100 From: Simon Horman To: Antoine Tenart Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, andrew+netdev@lunn.ch, netdev@vger.kernel.org, Sashiko Subject: Re: [PATCH net] geneve: fix length used in GRO hint UDP checksum adjustment Message-ID: <20260603201428.GJ3766816@horms.kernel.org> References: <20260529144713.780938-1-atenart@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260529144713.780938-1-atenart@kernel.org> On Fri, May 29, 2026 at 04:47:00PM +0200, Antoine Tenart wrote: > In geneve_post_decap_hint the length used for adjusting the UDP checksum > should be 'skb->len - gro_hint->nested_tp_offset' (UDP length) instead > of 'skb->len - gro_hint->nested_nh_offset' (IP length). > > Fixes: fd0dd796576e ("geneve: use GRO hint option in the RX path") > Cc: Paolo Abeni > Reported-by: Sashiko > Closes: https://sashiko.dev/#/patchset/20260521131436.748832-1-jhs%40mojatatu.com > Signed-off-by: Antoine Tenart Reviewed-by: Simon Horman FTR, an AI-generated review of this patch is available on sashiko.dev. I do not believe that needs to be addressed in the context of this patch.