From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C74F93BE17E; Thu, 4 Jun 2026 13:06:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780578388; cv=none; b=p0MnZqjnrH3kDmM6x7W362Cm7/lXNNPfe2p/FRxpJODGITsZ9o4iZQvW44l3uXdwVYUTtqyaGo2d5q59gJTBmkljdUksJ8JVvRhbh/TeXHRSuMgUaZZYJQXpIWGAqa5AVwJ9NyrAue4VgYA+672Tn2f50xu3k98/ULLrIiG8bSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780578388; c=relaxed/simple; bh=t/bnHVvLxSnLu7GFAfeDE6W9zRykt9dyoZD7Bp1dM8w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f+U9EILtBgxB65TE9ziYP9e6QGFumE0sUWnXHjmWfVAS5cwSbz4xC7gCwJ0IRL06VkmrzO9AHlJtLaE3CPPBpNOn+VcQt5YtT7SaeC3Sr4QHnqyTqb5Q84c2dobB1ZZPeHOqu0DV/UgLNv+Te7JJTNySmf7VSh9xbMKDtZ4jp9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J+Qq9g4e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J+Qq9g4e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F8A11F00893; Thu, 4 Jun 2026 13:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780578387; bh=Yk7G4nQ76kEw4V8LfGixmYzRqb+tUcXQEXr+9JxJya8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=J+Qq9g4ecq6sFBscMlTP5Yd+894YldsFLUszk5+a4sBaXHEHvTdLhRnn9UekuoDLN /gY8+t2iBNybiMJoZAw1p5RGzGvV8Q3ZMQqiiX0+BP9YJqRaCGi8UANpo5FSZCvLXo AI0VKx5InvAx3ljDvwT2DXzrB0QDhe8vJfrCLh9c8+wB8kv7RufsKFcMn/eKmmJTBE UNb9FYDFzjojwOhrCT5DmnN9MA5y9gmDIYvQEEVs7Cxo5jeuntl4eAbR3xQrO55Pyr mjSsYj14vx05f9cFVuwGQW3Yy7oCXv8rGa5n7qc6sA2tWdJgFiLHKIIiS5BhnnNfHr Gus2LDtsORCvw== Date: Thu, 4 Jun 2026 14:06:22 +0100 From: Simon Horman To: Breno Leitao Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH net-next v2 0/3] netconsole: Fix reported problems Message-ID: <20260604130622.GB3920875@horms.kernel.org> References: <20260602-netcons_fix_before_move-v2-0-eca3f8a8b1a3@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602-netcons_fix_before_move-v2-0-eca3f8a8b1a3@debian.org> On Tue, Jun 02, 2026 at 07:26:56AM -0700, Breno Leitao wrote: > These are some of the issues that LLM reported to netconsole, and they > are being addressed here before big refactors. > > I was doing some big refactors, and got some "pre-existent-issues" > during LLM review of the refactor, that make them hard to guarantee that > refactor is not introducing any bug, so, let's clean these pre-existent > bugs first, and then submit the refactor. > > The issues fixed in this patchset were reported during the review of > https://lore.kernel.org/all/20260524-netconsole_move_more-v1-0-909d1ab398b4@debian.org/ > > Not all of them got fixed, but, those that were easy to reason about. > > Why net-next and not 'net' tree. > > Most of the functions that are being fixed here moved from netpoll to > netconsole, thus, fixing this on net will cause merge conflicts from > 'net' to 'net-next', thus I decided to fix it on 'net-next', given we > are on 7.1-rc6 already. Sorry if that is not the right approach. > > Changed from v1: > * Change it from 'net' to 'net-next'. Hi Breno, There is AI-generated review of this patch-set available on both https://sashiko.dev and https://netdev-ai.bots.linux.dev/sashiko/ I would appreciate it if you could look over that with a view to addressing any issues that directly effect this patch-set.