From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: lawson.fidelio@gmail.com, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, andrew@lunn.ch, olteanv@gmail.com,
davem@davemloft.net, edumazet@google.com, marex@denx.de,
maxime.chevallier@bootlin.com, horms@kernel.org,
hkallweit1@gmail.com, linux@armlinux.org.uk,
Tristram.Ha@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, nb@tipi-net.de,
fidelio.lawson@exotec.com, marex@nabladev.com
Subject: Re: [PATCH net-next v9 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables
Date: Thu, 4 Jun 2026 19:35:45 -0700 [thread overview]
Message-ID: <20260604193545.0a906598@kernel.org> (raw)
In-Reply-To: <20260604114119.170747-1-pabeni@redhat.com>
On Thu, 4 Jun 2026 13:41:19 +0200 Paolo Abeni wrote:
> > @@ -3114,6 +3114,9 @@ static int ethtool_phy_tunable_valid(const struct ethtool_tunable *tuna)
> > switch (tuna->id) {
> > case ETHTOOL_PHY_DOWNSHIFT:
> > case ETHTOOL_PHY_FAST_LINK_DOWN:
> > + case ETHTOOL_PHY_SHORT_CABLE_PRESET:
> > + case ETHTOOL_PHY_LPF_BW:
> > + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE:
> > if (tuna->len != sizeof(u8) ||
> > tuna->type_id != ETHTOOL_TUNABLE_U8)
> > return -EINVAL;
>
> [Severity: High]
> Is it intentional to enforce an 8-bit type constraint for bandwidth and DSP
> equalizer tunables?
>
> This heavily couples the global API to the 8-bit register layout of the
> KSZ87xx hardware without defining generic units like Hz for bandwidth.
AFAIK this is the one comment from AI that survives scrutiny.
Seems unlikely we'd need more bits, but then again - why not.
u32 should be our default for integer values, u8 is more for
booleans.
next prev parent reply other threads:[~2026-06-05 2:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 15:19 [PATCH net-next v9 0/3] ksz87xx: add support for low-loss cable equalizer errata Fidelio Lawson
2026-06-01 15:19 ` [PATCH net-next v9 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Fidelio Lawson
2026-06-01 15:19 ` [PATCH net-next v9 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Fidelio Lawson
2026-06-04 11:41 ` Paolo Abeni
2026-06-04 12:11 ` Andrew Lunn
2026-06-05 2:35 ` Jakub Kicinski [this message]
2026-06-05 3:16 ` Marek Vasut
2026-06-01 15:19 ` [PATCH net-next v9 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Fidelio Lawson
2026-06-04 11:41 ` Paolo Abeni
2026-06-04 12:15 ` Andrew Lunn
2026-06-01 15:43 ` [PATCH net-next v9 0/3] ksz87xx: add support for low-loss cable equalizer errata Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604193545.0a906598@kernel.org \
--to=kuba@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fidelio.lawson@exotec.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=lawson.fidelio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=marex@nabladev.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox