From: Jakub Kicinski <kuba@kernel.org>
To: Eric Joyner <eric.joyner@amd.com>
Cc: <netdev@vger.kernel.org>, Brett Creeley <brett.creeley@amd.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net] ethtool: Set histogram ranges to NULL before querying FEC data
Date: Thu, 4 Jun 2026 19:46:29 -0700 [thread overview]
Message-ID: <20260604194629.45a3ef03@kernel.org> (raw)
In-Reply-To: <20260604225440.11083-1-eric.joyner@amd.com>
On Thu, 4 Jun 2026 15:54:40 -0700 Eric Joyner wrote:
> If this field isn't set to NULL, then drivers that set the non-histogram
> FEC statistics and don't support/modify the histogram fields will
> trigger a WARN_ON() in fec_put_hist(). Drivers shouldn't be forced to
> set this field to NULL if they don't have a need to touch FEC histogram
> reporting, so set this field before the driver gets the data structure.
&data should be zero-initialized, how is this patch not a nop?
Are you sure this can trigger unless the driver is buggy and sets
ranges without reporting any values?
next prev parent reply other threads:[~2026-06-05 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 22:54 [PATCH net] ethtool: Set histogram ranges to NULL before querying FEC data Eric Joyner
2026-06-05 2:46 ` Jakub Kicinski [this message]
2026-06-05 16:28 ` Eric Joyner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604194629.45a3ef03@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox