From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D4727A92E for ; Fri, 5 Jun 2026 01:00:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780621250; cv=none; b=AkAIQyPplkmml5+sruX/OU2FhRGp5hJmrpsBbFYfE6ODMPSsI/xhBhYdBwqH65Jwv+8zJoBTSlygxsOxZ2U52UhxlOSiFfhcGKSlsGeWLYe2BoNKe+iIJipANFqECcy0nFBggy9fOBkyBCnX7l5YCcvviu/iyUZ7veQYwVA9dGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780621250; c=relaxed/simple; bh=vMr4jxhlvuiWi2PyxKlVKNSh14l3upUcj5Q6o8aP3EM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O/LQWTLZ2/I/AS4XTVLwrnjoSxtn1jSQ1XY5JYRzb/vnmUx9c9MJnh1jhjX0wss0CzSFrxwDeHb6VjwchIy1eG7CTjEmplxXR+wlVqXaeiYwxTOYdg/eO8jwk7nuXkqkQs+ni4ZxgSvki14pHSyaaWgOkkfbhrgXNim4RJCVZME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=P5NRH/k4; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="P5NRH/k4" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-48650c78e09so564263b6e.2 for ; Thu, 04 Jun 2026 18:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1780621234; x=1781226034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fJ+38FTwss9ygHui1gfTl6vP2WH2KcHiorJ0gzERMpo=; b=P5NRH/k4oh2qX2Mxdd1OGFpXE8cbMm9Qg67qkD9BjzDwrunKnD461+DMCBCtWg7XJ/ ivuyG4zmFl8XBfqAxnaxlTVlEMaJtBNWUGgAa67ubcick5WLoapSlMULVLXbsoEejMPA njCAqnmHUNS1o6j9Fx6KW2VVjwH6iMltkcnVE2qwFnaK9GLCKMS3P2KGAdob0lqR7zH3 lgJUTPMkTHsrLS/HHDuoYj7sI8Rs3Dph4OdadMmHO5J/P6DD1VbijV3LcEjizTlR18TB yirDWNylk12lGSdC0PxAFOZO+yP35qc9KFzPlDH2MFDG9FatFM4+NM++S0kNd/VnQu0V YkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780621234; x=1781226034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fJ+38FTwss9ygHui1gfTl6vP2WH2KcHiorJ0gzERMpo=; b=nvHwzzUKX6qo9gwkXOE89NGYvKlz6MJqZWDswneKZHuV7ZN8kVLRX1Zo1KncOb+xgi f11MZxhjZ1IX4dC5NYssDqKmfxYTflCsqZRSjJtew8K0/14GCBGyTyK+uY/M1JPfNCjc o4x199qQB7ubsGZp8Rp7cinqVIuTJKNrgMs2qMq5ixpoy5kD9soK2+SJjRaaVq29szNt gxhd7hBWwrUoWddb8hbaqdLnITVItV/DM/K30LmethCwcNjGRNX63ItdHXHwnVgmdVcv 8O9I5ixj7XMT6E2GqRZi/sqeTDEhpE8+YXUiLF/iB0QAuTX7tFX4e4kdg2M4Xc+NJIM9 E8Uw== X-Forwarded-Encrypted: i=1; AFNElJ87FI6Ko9tjaJHTEHiPYq86tF/hguCFG32g3SxUz7ewAHcrksS2fOJRKzgcG6U7UK7QBC8rOaU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw66hg4FE3qQkbkNUn466kQt4LAmPSBfNIGKeZaVPBu8/NLG6g vHoxyXyu0lWxSvfRuyQdHDSc3T7vY8NjOZ6GZlzhaB12+oDwu9S8trCaGTiHfRDLpUE= X-Gm-Gg: Acq92OF8HE2F7DJi1fzHAfQQ6hOtQNxPurV3fAZv2QyOfVz/8YA5L60L8i+jOkkiB4K 36cJOvvmfnATxMZwpFvC/fs1547UnJCSfYOT6RrFT/GU/6+gS8rIB8HwFJVmXzS+0uKpLL42QzS RWuhDLZZJogIZgxYAW82Sgi++2MheMIvCIH+SnJ4TXGiozi7eiKM5APF0sgnRGFag/eiDrUlWIX PKH6xSPCSDpiNt/6MamoHRL1vU2T9+dKh5H4zRZ6wIQp/lpe1KCg8hwJlWDtbn21FgMTq3/Nsqd 5IpN2JcRxWD/BqSosDffI21RnzL8FytFXrNmcjLW9oBMfEZSxkTVQCYeJ76O0Wz50Chp+9Cs2fJ xRjYiIjjWfLgjQJc5EygTe5JukHsodgXPQCkcnQwDG/xFrEvaMJ9+UtqGvs/ij5aPcfEnJ6SGbE l/Cdi4oiXMqTV2SszfwHPqbVpmrscbtpn6IxUq2w== X-Received: by 2002:a05:6808:1b25:b0:486:560d:aa9c with SMTP id 5614622812f47-4868dc63516mr816744b6e.15.1780621234618; Thu, 04 Jun 2026 18:00:34 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4865b6ec694sm5544631b6e.5.2026.06.04.18.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 18:00:34 -0700 (PDT) From: Alex Elder To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: Daniel Thompson , elder@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 02/14] net: phy: qcom: qca808x: Add regulator management Date: Thu, 4 Jun 2026 20:00:09 -0500 Message-ID: <20260605010022.968612-3-elder@riscstar.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260605010022.968612-1-elder@riscstar.com> References: <20260605010022.968612-1-elder@riscstar.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daniel Thompson QCA8081 appears in embedded board designs paired with GPIO controlled regulators for its power rails. Add logic to allow these regulators to be turned on during a probe. In order to avoid the complexity of tracking state for suspend with and without WoL we take a tremendously simple "always-on" approach to regulator management, essentially relying on BMCR_PDOWN to conserve power when the phy device exists. Signed-off-by: Daniel Thompson Signed-off-by: Alex Elder --- drivers/net/phy/qcom/qca808x.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/net/phy/qcom/qca808x.c b/drivers/net/phy/qcom/qca808x.c index 8eb51b1a006c4..fc3f2cf2e55d0 100644 --- a/drivers/net/phy/qcom/qca808x.c +++ b/drivers/net/phy/qcom/qca808x.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0+ #include +#include #include #include "qcom.h" @@ -178,15 +179,44 @@ static void qca808x_fill_possible_interfaces(struct phy_device *phydev) __set_bit(PHY_INTERFACE_MODE_2500BASEX, possible); } +static int qca808x_power_on(struct phy_device *phydev) +{ +#ifdef CONFIG_OF + static const char * const regulator_names[] = { + "avdd18", "vdd", "vdd18", "vdd125" + }; + struct device *dev = &phydev->mdio.dev; + u32 count = 0; + int i, ret; + + for (i = 0; i < ARRAY_SIZE(regulator_names); i++) { + ret = devm_regulator_get_enable_optional(dev, regulator_names[i]); + if (!ret) + count++; + else if (ret != -ENODEV) + return ret; + } + + if (count) + fsleep(phydev->mdio.reset_assert_delay); +#endif + return 0; +} + static int qca808x_probe(struct phy_device *phydev) { struct device *dev = &phydev->mdio.dev; struct qca808x_priv *priv; + int ret; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; + ret = qca808x_power_on(phydev); + if (ret) + return ret; + /* Init LED polarity mode to -1 */ priv->led_polarity_mode = -1; -- 2.51.0