From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.simonwunderlich.de (mail.simonwunderlich.de [23.88.38.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D373A472775 for ; Fri, 5 Jun 2026 07:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=23.88.38.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780644022; cv=none; b=eGUG6I/xCXVPaTMPDfaKhUvKvaL6BcrwptBDkLXfEBoTHYAVcOT6vMLti0FTYjPgSgCZUeedWMapeBVAjOhfR2rxKjj0KbnOK8GCVxqMQgje+D6+rtdfu01Dt1+77edbSq1vrsmu61HSFqFQDu3jMRPuSsQoNy2ChZSqnPiImmI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780644022; c=relaxed/simple; bh=6wxIf4iVWK1x1g7o6BZMvgAjpP3p4hgZ9/6fRW7KVk0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gGFK3CSODT8vY1swUSXhz7rP+XxZ3AWz+JHSoEB+yMNnL+K40+WL2pOmY79ARsGOSBwWtsG1X4ykMO9ZN5ro+tQwphG562hCqNIMQuWqgK0mBGxp0I/QUb6VuwIjJHLQTEqa5z2Gs0Mjnz6/P5nfSCeneqO9pdTVOEVeZW3pnZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=simonwunderlich.de; spf=pass smtp.mailfrom=simonwunderlich.de; dkim=pass (2048-bit key) header.d=simonwunderlich.de header.i=@simonwunderlich.de header.b=bWwsArv3; arc=none smtp.client-ip=23.88.38.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=simonwunderlich.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=simonwunderlich.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=simonwunderlich.de header.i=@simonwunderlich.de header.b="bWwsArv3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=simonwunderlich.de; s=09092022; t=1780644018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Min51foF2kElplOUTaOkcqj5GJmfwEQQHqIG5in0FV0=; b=bWwsArv3bgYIz8xIy1AK/pUEVTmitbggph35VEwNo/2dnvjiYQPn84R6HMrFAMgjUszKlE lZyztpRKDerEKmMTKKQZtDC3WuEb9JTMdwEu0KDLD2vMlYSYkW8vuAarFPBdjXzlLRsfGC nwGYWvMsqZ9oK1ej+bs0YvAdOKf4dF0Qpiqj4Dm5c+4NUCgf5UA5vLYdlaiTAHeeSmPoCj +QfwLLtAYFEZPFtfmoJ11bEE5s88Yhfs+Mp/BdRy6d9ovP2k/PjiOKV8cezVQRbi5uKx4i XuN4i8EjPAoG9s+QWuOxKFKrW5Ch00GdL/TQGsHD7m+2DtJIEOnizUDSQLOc5A== From: Simon Wunderlich To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , b.a.t.m.a.n@lists.open-mesh.org, Sven Eckelmann , Simon Wunderlich Subject: [PATCH net-next 10/11] batman-adv: fix batadv_v_ogm_packet_recv error handling kernel-doc Date: Fri, 5 Jun 2026 09:20:04 +0200 Message-ID: <20260605072005.490368-11-sw@simonwunderlich.de> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260605072005.490368-1-sw@simonwunderlich.de> References: <20260605072005.490368-1-sw@simonwunderlich.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sven Eckelmann All receive handlers in batman-adv are consuming the skbuff independent of the result of the handler. The "(without freeing the skb) on failure" is therefore not corrrect anymore for the current implementation. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/bat_v_ogm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c index 72ae8ffc9db65..14920f4bb315b 100644 --- a/net/batman-adv/bat_v_ogm.c +++ b/net/batman-adv/bat_v_ogm.c @@ -984,7 +984,7 @@ static void batadv_v_ogm_process(const struct sk_buff *skb, int ogm_offset, * @if_incoming: the interface where this OGM has been received * * Return: NET_RX_SUCCESS and consume the skb on success or returns NET_RX_DROP - * (without freeing the skb) on failure + * (freeing the skb) on failure */ int batadv_v_ogm_packet_recv(struct sk_buff *skb, struct batadv_hard_iface *if_incoming) -- 2.47.3