From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B822930FC1A for ; Sat, 6 Jun 2026 08:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780734592; cv=none; b=uhjBzOWQr501+XAcJNuS9leOaNBVxPlxTLALwmyXwnYVHNu/s10bILDzAXg/6BocrWC6Fq+Ni8coPTUiGP9QT4ic64/LWGs4iPDPzGHOKTttK94jpgvNj0R9TdzcShpwJUumf/gKcmNaZ+35XEvs5ZB+zxgrK3bLvXgU7Asa6ug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780734592; c=relaxed/simple; bh=6vvUpEnA3zuZyhkh5L9tx3acH0/PiR28xnODKHfdVgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A3kATWhUNpz7ej+3baFGSt4Vtigw1dml1jSZtJJYU11J6UHM4BWJxpB3X021hgp+iqOxkkw939uZnpFOjAMHR79xrPQC9NtlTYd63DKT7Nz4l1HiEW7ez49u286qMdVxQmrk5taJ5JQHrX8Tf2Pu6nP/VpHYALZlzhCg2YQQOy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jx8M5HI9; arc=none smtp.client-ip=209.85.222.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jx8M5HI9" Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-96395a59ff6so959214241.0 for ; Sat, 06 Jun 2026 01:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780734590; x=1781339390; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rgdsNgCTJpv8k0KRcqQg2bYC+LqfZpfIBBy5KwRLQzE=; b=jx8M5HI9rYYn5CzI+L8CaKkZm0tv7alKUM5VbZKofmQFm3/t/eZccyPFA0zlf5OkRI tX7OuasZZBOLCmjI7tdseHT9qBlvV4evMM8JSs1XZ4NR0UYtoUMR4vsQ4fDm744Db7Cf dHi2tg5XVD1jGB5xSG03qPa6Eh99n4IGYK9f8FsUWdD53seucW0Kv3IWEDkMZWziv0xX Q9DlYFlGV0LvgPrV2x2U//vtw736teEbhu+hry4r/SENklNcW4pnh+VznLtb5b62/60o PBPR8fGJglu0Jpv88PmsV0aD3tYa/BjyIuTjJZzIpIXlLgbuAjDfWR5NW0FryRYYRHbm S2gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780734590; x=1781339390; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rgdsNgCTJpv8k0KRcqQg2bYC+LqfZpfIBBy5KwRLQzE=; b=VW7EoMvaflF6bomLyyrjQil4BVMhLmt5juKbD95S3FLtAG9OQEE+I8JS6WV8iW8PCs MnmjannW37scdd7p/2Fzzu464+Re4PeWcQ9SWn92DYYy5dgG2pkE4tBWipriHhrAGZ7A GuDI8bZIBJI2180R4cM7FQYQLj+u32Cunsy1TL1Aeb55ZsXxHvLJ2A4uw8fWhEUy0zom 00wf0pGGuywf/1yKsXG+k8SyYr0J0pYQjO+GTiME3gjXo+Ibv0jCqvXZBq4ATxjVWp3D 1ZO/0XAOf1A6xpLtz3T/gIUtaK1PBcd+wGXVZRDExv1G6aKPl3I/MCAicEDJOZ0hpZZq xekQ== X-Gm-Message-State: AOJu0YyFbW2InA2EtdxgUNaGCxV1dySbEgzsdSNveW3UbMpGgiSD+wdG FnZxkCpFpi47xTNFKFUh6k2OTvE8NnDeRHNw9X2KA22zlxE01NfZMqrRYGFzxW9o1LI= X-Gm-Gg: Acq92OFa4F/LCVlZwqEF2XyydrehefYZot5AdwkfRjHDoorhMvFc2MxJEzQCA8gog6Z QYxrD+3sMBRDrHE1SrHGUrOSzPLwOPREPdZpuPhmD4TYlwsASX2SnrF09VO1hExBHzctnp798iq 6c0RyACVm1+8EBHX1PpQaM8pDTRH/1tCuIjQ4GXa3+p76wbnLxGBYWRPV+kXYAKU4fBuwt6dOgl NwL/i98obGJioVJ+i09mxb/sSeC0tjwX/yj9f4UdDa6t6Xtx+5Hh5ltI8my5e/3t1+rm4uNLZP0 1Hh/uYoYj1SnL0ng6Vc5GLo5kGUyfZbRKjP0ruk7zZQ1a7CFy260EW+OTN2tb/qja57O0eDIvNB 3uXj+qYiwviqmsslD/ygS+5Ye8BmEsyHr9wrk4qrhooqY0pgaCwuuRZkLa+CBicc5qIYXFUKyre k8izREJh1djcM71DutkxPoQnAeG3gchin2FiM2/cvm7QcOamLGjDhZDIPP5AIQ X-Received: by 2002:a05:6122:4692:b0:5a6:7838:d679 with SMTP id 71dfb90a1353d-5ac52c09f1amr3867536e0c.13.1780734589808; Sat, 06 Jun 2026 01:29:49 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5a6dc44d233sm9630281e0c.10.2026.06.06.01.29.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 01:29:49 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Sat, 06 Jun 2026 05:29:25 -0300 Subject: [net-next PATCH v13 1/9] net: dsa: realtek: rtl8365mb: use ERR_PTR Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260606-realtek_forward-v13-1-b9e409687cbe@gmail.com> References: <20260606-realtek_forward-v13-0-b9e409687cbe@gmail.com> In-Reply-To: <20260606-realtek_forward-v13-0-b9e409687cbe@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mieczyslaw Nalewaj , Luiz Angelo Daros de Luca X-Mailer: b4 0.15.2 Convert numeric error codes into human-readable strings by using %pe together with ERR_PTR() in dev_err() messages. Also use dev_err_probe() instead of checking for -EPROBE_DEFER. Reviewed-by: Linus Walleij Reviewed-by: Mieczyslaw Nalewaj Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/rtl8365mb.c | 51 +++++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c index 0da048da533a..2637884fe472 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -803,8 +803,8 @@ static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum) ret = rtl8365mb_phy_ocp_read(priv, phy, ocp_addr, &val); if (ret) { dev_err(priv->dev, - "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to read PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -831,8 +831,8 @@ static int rtl8365mb_phy_write(struct realtek_priv *priv, int phy, int regnum, ret = rtl8365mb_phy_ocp_write(priv, phy, ocp_addr, val); if (ret) { dev_err(priv->dev, - "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy, - regnum, ocp_addr, ret); + "failed to write PHY%d reg %02x @ %04x, ret %pe\n", phy, + regnum, ocp_addr, ERR_PTR(ret)); return ret; } @@ -1082,8 +1082,8 @@ static void rtl8365mb_phylink_mac_config(struct phylink_config *config, ret = rtl8365mb_ext_config_rgmii(priv, port, state->interface); if (ret) dev_err(priv->dev, - "failed to configure RGMII mode on port %d: %d\n", - port, ret); + "failed to configure RGMII mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1112,8 +1112,8 @@ static void rtl8365mb_phylink_mac_link_down(struct phylink_config *config, false, false); if (ret) dev_err(priv->dev, - "failed to reset forced mode on port %d: %d\n", - port, ret); + "failed to reset forced mode on port %d: %pe\n", + port, ERR_PTR(ret)); return; } @@ -1143,8 +1143,8 @@ static void rtl8365mb_phylink_mac_link_up(struct phylink_config *config, rx_pause); if (ret) dev_err(priv->dev, - "failed to force mode on port %d: %d\n", port, - ret); + "failed to force mode on port %d: %pe\n", port, + ERR_PTR(ret)); return; } @@ -1299,8 +1299,8 @@ static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *da mib->length, &data[i]); if (ret) { dev_err(priv->dev, - "failed to read port %d counters: %d\n", port, - ret); + "failed to read port %d counters: %pe\n", port, + ERR_PTR(ret)); break; } } @@ -1652,7 +1652,8 @@ static irqreturn_t rtl8365mb_irq(int irq, void *data) return IRQ_HANDLED; out_error: - dev_err(priv->dev, "failed to read interrupt status: %d\n", ret); + dev_err(priv->dev, "failed to read interrupt status: %pe\n", + ERR_PTR(ret)); out_none: return IRQ_NONE; @@ -1725,10 +1726,13 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) /* rtl8365mb IRQs cascade off this one */ irq = of_irq_get(intc, 0); if (irq <= 0) { - if (irq != -EPROBE_DEFER) - dev_err(priv->dev, "failed to get parent irq: %d\n", - irq); - ret = irq ? irq : -EINVAL; + if (!irq) { + dev_err(priv->dev, "failed to map IRQ\n"); + ret = -EINVAL; + } else { + ret = dev_err_probe(priv->dev, irq, + "failed to get parent irq\n"); + } goto out_put_node; } @@ -1790,7 +1794,8 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv) ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT, "rtl8365mb", priv); if (ret) { - dev_err(priv->dev, "failed to request irq: %d\n", ret); + dev_err(priv->dev, "failed to request irq: %pe\n", + ERR_PTR(ret)); goto out_remove_irqdomain; } @@ -1966,14 +1971,16 @@ static int rtl8365mb_setup(struct dsa_switch *ds) ret = rtl8365mb_reset_chip(priv); if (ret) { - dev_err(priv->dev, "failed to reset chip: %d\n", ret); + dev_err(priv->dev, "failed to reset chip: %pe\n", + ERR_PTR(ret)); goto out_error; } /* Configure switch to vendor-defined initial state */ ret = rtl8365mb_switch_init(priv); if (ret) { - dev_err(priv->dev, "failed to initialize switch: %d\n", ret); + dev_err(priv->dev, "failed to initialize switch: %pe\n", + ERR_PTR(ret)); goto out_error; } @@ -2091,8 +2098,8 @@ static int rtl8365mb_detect(struct realtek_priv *priv) ret = rtl8365mb_get_chip_id_and_ver(priv->map, &chip_id, &chip_ver); if (ret) { - dev_err(priv->dev, "failed to read chip id and version: %d\n", - ret); + dev_err(priv->dev, "failed to read chip id and version: %pe\n", + ERR_PTR(ret)); return ret; } -- 2.54.0