From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com [185.226.149.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BC43C2796; Sat, 6 Jun 2026 20:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.226.149.38 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780777646; cv=none; b=uLj9STvk00fQWSiWK7rV2BpemJr/WEiJ210/9mzuMJ0+sJkZvCA6lC1kadbxj6AC77AIYlOBtS9lKOxXqfZa3vCajydp3CBam4R+qaqjuvWYqfhLHNMUhuNFY3dFxkuWEXb5RMeIcogyvbDsUbwBaT5J88rg8pnkYhao/qKckFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780777646; c=relaxed/simple; bh=x34zKJLbHrcfl7PrIVfYPfgZXBOyFERJSkGeDrsYoZE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ThZ2ZjcQ0szEXxPrmlP3fVd0MUk6NvJ3Z3RuyskHoc0vFBacaFNMTAf9sKDkG7I1V+DMKUX0Yi7kLJUoFKVWmXyyau5QKK3NWtUDkQuGboArx28q1Ug0wNRpJMAlFrYWROacZ71cFDO6drdqG0bKTwWIZFmiDdenacVwA2gqRF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=runbox.com; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b=J26kTvRl; arc=none smtp.client-ip=185.226.149.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=runbox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b="J26kTvRl" Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1wVxbu-007cH7-QD; Sat, 06 Jun 2026 22:27:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=1KyGr0RrzQAbPBe1OH55bwns/tP9FfEfmistj29ns+k=; b=J26kTv RlHV+T4PPuIPitv4867R4mIrOYWbuQxBwNpsVr8lFF2J42NiciZwKItnI8GVHd/sSZi20VROkHRm6 sozRMYQ4yAf9w6BZmLey4u0kw3ledTVjpL3Kiy8VA21VJXOqnZ8LmxOcoNv71/NxOu0E977a71NKF UCBkdPk7WIYKO/kM0sh8kSnuYBDZfdEjkarzc1pH1mJCGXyELw/yiugyGHAedzVm0cQ1bey79pEd8 pIjh0/28+dmCaT5BN4mxkICWYg65+OAtM3b1GkPmUxpHscnq4m/LxnlPAUlM6Pa76Zqxjm5EfHo3k uzOYSOWC3ujnplAnPXwliQXTvvxA==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1wVxbu-0005D3-CD; Sat, 06 Jun 2026 22:27:14 +0200 Received: by submission01.runbox with esmtpsa [Authenticated ID (1493616)] (TLS1.2:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) id 1wVxbg-006V18-Fq; Sat, 06 Jun 2026 22:27:00 +0200 From: david.laight.linux@gmail.com To: Kees Cook , linux-hardening@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-net-drivers@amd.com, netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Edward Cree , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Laight Subject: [PATCH net-next] drivers/net/ethernet/sfc/efx: User strscpy() to copy device name Date: Sat, 6 Jun 2026 21:26:12 +0100 Message-Id: <20260606202633.5018-18-david.laight.linux@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Laight Signed-off-by: David Laight --- This is one of a group of patches that remove potentially unbounded strcpy() calls. They are mostly replaced by strscpy() or, when strlen() has just been called, with memcpy() (usually including the '\0'). Calls with copy string literals into arrays are left unchanged. They are safe and easily detected as such. The changes were made by getting the compiler to detect the calls and then fixing the code by hand. Note that all the changes are only compile tested. Some Makefiles were changed to allow files to contain strcpy(). As well as 'difficult to fix' files, this included 'show' functions as they really need to use sysfs_emit() or seq_printf(). All the patches are being sent individually to avoid very long cc lists. Apologies for the terse commit messages and likely unexpected tags. (There are about 100 patches in total.) drivers/net/ethernet/sfc/efx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 8f136a11d396..77d29773c5af 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -755,7 +755,7 @@ static int efx_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **xdpfs, static void efx_update_name(struct efx_nic *efx) { - strcpy(efx->name, efx->net_dev->name); + strscpy(efx->name, efx->net_dev->name); efx_mtd_rename(efx); efx_set_channel_names(efx); } -- 2.39.5