From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailtransmit04.runbox.com (mailtransmit04.runbox.com [185.226.149.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DCED3C4B88; Sat, 6 Jun 2026 20:27:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.226.149.37 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780777645; cv=none; b=l2rtWTR+edF+EWOxMF1TIWz5X4dpOFcwwkkvA1Irx/SbmTUkIp9PZ/+UhTl05dSH6Ybt/fiEb86sGRnUEL7MrrIAK4dx3xp2GCLocH1nPOcAEKSbRFPDoNGO1X+rgRKEIsY7TYsQW3PISUF4s7Jsw3bJlKlEr05wbxjxvGnR5sY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780777645; c=relaxed/simple; bh=SxzaNOPuRKvYNLVHaRZrGNPTvEna/tHYJItD78azQwA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OMQ7wPM3cQx3Lgl2V6IV9qNENQK6bgFG77Z1hC+J8kPkzEmVkhnYWv3FRkhCw05Xta6qMFb/3V98ASzDqBtnRq/kyRvxrlLVSsbNaOIh4Nxc8hT72tB7yUzp4tnz7Hn9cMjGUvA/IlGVl5uVhY5jMwfFAphbUTdMyHwxFPj55Po= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=runbox.com; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b=mjpZOoiP; arc=none smtp.client-ip=185.226.149.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=runbox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=runbox.com header.i=@runbox.com header.b="mjpZOoiP" Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1wVxbv-007NRO-02; Sat, 06 Jun 2026 22:27:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=7lP0V/PmqS5w6KerRWcqIcU3V9iQKo1pwTjde744MY0=; b=mjpZOo iP4VjIuMbdQttdGmJCASaz05iyq0vYuvV/KCnS9a1/jEitNkyg/MfEuL1WcRBdyMGjJOXTZDzvGq6 Y0NiVxxDcVJDy5N17xcPqY5RCmsMFNDFWpANMy8nCRXf9hO3oiXAygd4SH4uWv7AEV9IFAZ3qUPWK OKvCiMdiy1zkpXv5fe6Vxz4eHBDfgoqsKO9MgzyvhfYBNDj7mXy9JbQh7gKARO8wKEhbmcY+VqL0C AWs7g2WfwwNp1psKRlcxt9YRa+nlEYR3gOz/Ru6I9mHoU9yLAHgTTIbWPF/AgLd6RxcPpqhUbhFZf A616nkvHkx2Mup5sOwdbb+62yecQ==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1wVxbu-0000ty-JJ; Sat, 06 Jun 2026 22:27:14 +0200 Received: by submission01.runbox with esmtpsa [Authenticated ID (1493616)] (TLS1.2:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) id 1wVxbg-006V18-Vp; Sat, 06 Jun 2026 22:27:01 +0200 From: david.laight.linux@gmail.com To: Kees Cook , linux-hardening@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-net-drivers@amd.com, netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Edward Cree , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Laight Subject: [PATCH net-next] drivers/net/ethernet/sfc/falcon/efx: User strscpy() to copy device name Date: Sat, 6 Jun 2026 21:26:13 +0100 Message-Id: <20260606202633.5018-19-david.laight.linux@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: David Laight Signed-off-by: David Laight --- This is one of a group of patches that remove potentially unbounded strcpy() calls. They are mostly replaced by strscpy() or, when strlen() has just been called, with memcpy() (usually including the '\0'). Calls with copy string literals into arrays are left unchanged. They are safe and easily detected as such. The changes were made by getting the compiler to detect the calls and then fixing the code by hand. Note that all the changes are only compile tested. Some Makefiles were changed to allow files to contain strcpy(). As well as 'difficult to fix' files, this included 'show' functions as they really need to use sysfs_emit() or seq_printf(). All the patches are being sent individually to avoid very long cc lists. Apologies for the terse commit messages and likely unexpected tags. (There are about 100 patches in total.) drivers/net/ethernet/sfc/falcon/efx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c index 0c197b448645..28ae767432f9 100644 --- a/drivers/net/ethernet/sfc/falcon/efx.c +++ b/drivers/net/ethernet/sfc/falcon/efx.c @@ -2212,7 +2212,7 @@ static const struct net_device_ops ef4_netdev_ops = { static void ef4_update_name(struct ef4_nic *efx) { - strcpy(efx->name, efx->net_dev->name); + strscpy(efx->name, efx->net_dev->name); ef4_mtd_rename(efx); ef4_set_channel_names(efx); } -- 2.39.5