From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+381d82bbf0253710b35d@syzkaller.appspotmail.com,
syzbot+3479efbc2821cb2a79f2@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: watchdog: fix refcount tracking races
Date: Mon, 8 Jun 2026 09:01:01 -0700 [thread overview]
Message-ID: <20260608090101.42b9f43c@kernel.org> (raw)
In-Reply-To: <20260608123935.524879-1-edumazet@google.com>
On Mon, 8 Jun 2026 12:39:35 +0000 Eric Dumazet wrote:
> Blamed commit converted the untracked dev_hold()/dev_put() calls
> in the watchdog code to use the tracked dev_hold_track()/dev_put_track()
> (which were later renamed/interfaced to netdev_hold() and netdev_put()).
selftest kernel build says:
net/sched/sch_generic.c: In function ‘netdev_watchdog_up’:
net/sched/sch_generic.c:594:39: error: incompatible type for argument 1 of ‘IS_ERR_OR_NULL’
594 | if (IS_ERR_OR_NULL(dev->watchdog_dev_tracker))
| ~~~^~~~~~~~~~~~~~~~~~~~~~
| |
| netdevice_tracker
config:
https://netdev-ctrl.bots.linux.dev/logs/vmksft/forwarding/results/682182/config
next prev parent reply other threads:[~2026-06-08 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 12:39 [PATCH net] net: watchdog: fix refcount tracking races Eric Dumazet
2026-06-08 16:01 ` Jakub Kicinski [this message]
2026-06-08 16:15 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608090101.42b9f43c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+3479efbc2821cb2a79f2@syzkaller.appspotmail.com \
--cc=syzbot+381d82bbf0253710b35d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox