From: Jakub Kicinski <kuba@kernel.org>
To: "Zhou, Yun" <yun.zhou@windriver.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH] flow_dissector: fix uninit-value in __skb_flow_dissect() for ETH_ADDRS
Date: Mon, 8 Jun 2026 13:43:30 -0700 [thread overview]
Message-ID: <20260608134330.40bb1b16@kernel.org> (raw)
In-Reply-To: <08433245-f57b-472b-96b4-7db28e1a3ab2@windriver.com>
On Mon, 8 Jun 2026 09:30:12 +0800 Zhou, Yun wrote:
> Hi Jakub,
>
> What is your opinion on this fix method?
This looks good, thanks for pointing out.
Please adjust the commit message explaining the problem, the setup that
triggers it, and problems with the control path approach.
The comment above the skb_mac_header_was_set() should also say _why_
this is hard to check in the control path, right now they comment
just restates what the code does.
Thanks!
prev parent reply other threads:[~2026-06-08 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 3:08 [PATCH] flow_dissector: fix uninit-value in __skb_flow_dissect() for ETH_ADDRS Yun Zhou
2026-06-03 5:44 ` Eric Dumazet
2026-06-03 8:15 ` Zhou, Yun
2026-06-03 8:33 ` Eric Dumazet
2026-06-03 8:54 ` Jiayuan Chen
2026-06-03 9:22 ` Zhou, Yun
2026-06-08 1:30 ` Zhou, Yun
2026-06-08 20:43 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608134330.40bb1b16@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox