From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B883E7BD9; Mon, 8 Jun 2026 14:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780929718; cv=none; b=Xo2CfOT3s8+9LsUfu0Hld5X4I9EtPuNqLw+3WQE4jv7l7bFBZBVUbCoJgP62GMcSKr3draYKkehjjd2AwGXjZ6jGGtipBDYnXZ/WGn788HMV32z3R99UHEmG433cwEhQpgMdom3EQ2Gxy3m/EzfR7+T6jsaMwpcrrJ85IUcNE9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780929718; c=relaxed/simple; bh=W8vjjRdq9241lv/bMwc8tyTtrTcZlgOVtG83Kg2hOog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MsnraCxFwOLCkQTAWrB+r+GcEpUZ+5znE45ZsWejLSPtSWYkDNC6I70vb4UByDovqulzVGWIKN32Pu1q+vJjSjsD6uJ2Y1iycILlLL7FVx3C//qYYhEwe9Zu5QHNVsqlAVIypG1WPObno5NZl/7UQfgEXaStQHFRdKURfm9stHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=B70FdOXH; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="B70FdOXH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780929717; x=1812465717; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=W8vjjRdq9241lv/bMwc8tyTtrTcZlgOVtG83Kg2hOog=; b=B70FdOXHX51ff80h0L9JfoFGxN/g3bqX766+iNKnp4xI24y/sWsitHnj yBbtxgmntGhdOzl0QGpPOz/8FNXFe+oneCiIjLrb2M00dlUVNiZpW3SaD gJ5YOkDq9g1Mh5pk1qIOAulBYjqvGV+vjkDozfY1S7dUJvNkEyMIOvqad kZGIIRZ+LjhLO/BCjPU/0yeBQ4JRDGZILf3s9jCqIV0dlipQiuVLkHxFO T1lEFlYUX04joeMvdtPHehic30QINsjFP8kHQ2zCJE2b/s2uedYinp92o zckmgNORAG3WaTharO3MAn4WRPTbk0DsHqyzHv0z073WD3OPqgCvJGkUs Q==; X-CSE-ConnectionGUID: +ru0+FYDSD+UOlHLP2tvUQ== X-CSE-MsgGUID: PkEXvsH+THqUlGcdFbuFVg== X-IronPort-AV: E=McAfee;i="6800,10657,11811"; a="81642037" X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="81642037" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2026 07:41:56 -0700 X-CSE-ConnectionGUID: 9XMEtk5HTfmNXowRjO5+nw== X-CSE-MsgGUID: +Msu1WMERRK+jTZCUM8qSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,194,1774335600"; d="scan'208";a="249489754" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orviesa003.jf.intel.com with ESMTP; 08 Jun 2026 07:41:51 -0700 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id E80AB28791; Mon, 8 Jun 2026 15:41:48 +0100 (IST) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Cc: aleksander.lobakin@intel.com, sridhar.samudrala@intel.com, Michal Swiatkowski , Larysa Zaremba , "Fijalkowski, Maciej" , Emil Tantilov , Madhu Chittim , Josh Hay , "Keller, Jacob E" , jayaprakash.shanmugam@intel.com, Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Richard Cochran , Przemek Kitszel , Andrew Lunn , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksandr Loktionov , Samuel Salin Subject: [PATCH iwl-next v8 11/15] idpf: print a debug message and bail in case of non-event ctlq message Date: Mon, 8 Jun 2026 16:41:16 +0200 Message-ID: <20260608144127.2751230-12-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260608144127.2751230-1-larysa.zaremba@intel.com> References: <20260608144127.2751230-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Unlike previous internal idpf ctlq implementation, idpf calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Kubiak Tested-by: Samuel Salin Signed-off-by: Larysa Zaremba --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index c6c036edb918..03087b63660d 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -84,6 +84,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; adapter = container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode != VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payload for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, -- 2.47.0