From: Stanislav Fomichev <sdf.kernel@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, Zijing Yin <yzjaurora@gmail.com>
Subject: [PATCH net-next v3 0/3] net: add retry mechanism to ndo_set_rx_mode_async
Date: Mon, 8 Jun 2026 08:40:11 -0700 [thread overview]
Message-ID: <20260608154014.227538-1-sdf@fomichev.me> (raw)
Original async ndo_set_rx_mode work left one place where we do netdev_WARN
in response to a ENOMEM. The intent was to see whether actual real
users can hit that (adding uc/mc under memory pressure seems like a
very unlikely thing to do). However, it was quickly triggered by
syzbot's failslab. Add a retry mechanism and downgrade netdev_WARN
to netdev_err. The retry logic is a typical exponential backoff:
1, 2, 4, 8 seconds, 15 in total, hopefully enough for a system to resolve
memory pressure.
Link: https://lore.kernel.org/netdev/20260416185712.2155425-1-sdf@fomichev.me/
Link: https://lore.kernel.org/netdev/20260519095557.3749407-1-yzjaurora@gmail.com/
Cc: Zijing Yin <yzjaurora@gmail.com>
v3:
- add netdev_warn for bnxt_hwrm_set_vnic_filter's EAGAIN (Michael)
- use netdev_assert_locked_ops_compat (Jakub)
v2:
- rx_mode_retry_work -> rx_mode_retry_timer (Jakub)
- (ulong) rx_mode_retry_delay -> (uint) rx_mode_retry_count (Jakub)
- remove dev_get/put (Jakub)
- drop fwd decl (Jakub)
- move comment about total retires to NETIF_RX_MODE_RETRY_MAX (Jakub)
- use -EAGAIN in bnxt to signal retry (Michael)
Stanislav Fomichev (3):
net: change ndo_set_rx_mode_async return type to int
net: add retry mechanism to ndo_set_rx_mode_async
bnxt: convert to core rx_mode retry mechanism
drivers/infiniband/ulp/ipoib/ipoib_main.c | 9 ++--
drivers/net/dummy.c | 7 +--
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 40 ++++++--------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 -
drivers/net/ethernet/intel/iavf/iavf_main.c | 10 ++--
.../net/ethernet/mellanox/mlx5/core/en_main.c | 8 +--
.../net/ethernet/meta/fbnic/fbnic_netdev.c | 8 +--
drivers/net/netdevsim/netdev.c | 7 +--
drivers/net/netkit.c | 7 +--
include/linux/netdevice.h | 16 ++++--
net/core/dev.c | 4 +-
net/core/dev.h | 2 +
net/core/dev_addr_lists.c | 53 ++++++++++++++++++-
13 files changed, 116 insertions(+), 57 deletions(-)
--
2.53.0-Meta
next reply other threads:[~2026-06-08 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 15:40 Stanislav Fomichev [this message]
2026-06-08 15:40 ` [PATCH net-next v3 1/3] net: change ndo_set_rx_mode_async return type to int Stanislav Fomichev
2026-06-08 15:40 ` [PATCH net-next v3 2/3] net: add retry mechanism to ndo_set_rx_mode_async Stanislav Fomichev
2026-06-08 15:40 ` [PATCH net-next v3 3/3] bnxt: convert to core rx_mode retry mechanism Stanislav Fomichev
2026-06-09 4:31 ` Michael Chan
2026-06-10 1:40 ` [PATCH net-next v3 0/3] net: add retry mechanism to ndo_set_rx_mode_async patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608154014.227538-1-sdf@fomichev.me \
--to=sdf.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yzjaurora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox