From: Jason Gunthorpe <jgg@ziepe.ca>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: leon@kernel.org, brett.creeley@amd.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, allen.hubbe@amd.com, nikhil.agarwal@amd.com,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [for-next v3 5/5] RDMA/mlx5: move mlx5 clock info to common struct ib_uverbs_clock_info
Date: Mon, 8 Jun 2026 14:30:39 -0300 [thread overview]
Message-ID: <20260608173039.GE2764304@ziepe.ca> (raw)
In-Reply-To: <20260606050003.3648306-6-abhijit.gangurde@amd.com>
On Sat, Jun 06, 2026 at 10:30:03AM +0530, Abhijit Gangurde wrote:
> Use struct ib_uverbs_clock_info from ib_user_verbs.h for clock info.
>
> The original struct mlx5_ib_clock_info remains in mlx5-abi.h for
> userspace ABI compatibility.
Please don't do that, we generally don't do compatability for
compilation only, especially in this case where rdma-core is the only
consumer and it has its own version linked copies of all these
headers.
Though it seems like the contents are the same so you could just do:
> +/*
> + * deprecated, see struct ib_uverbs_clock_info from ib_user_verbs.h
> + */
#define mlx5_ib_clock_info ib_uverbs_clock_info
Jason
next prev parent reply other threads:[~2026-06-08 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-06 4:59 [for-next v3 0/5] ionic: RDMA completion timestamping support Abhijit Gangurde
2026-06-06 4:59 ` [for-next v3 1/5] net: ionic: register PHC for rdma timestamping Abhijit Gangurde
2026-06-06 5:00 ` [for-next v3 2/5] net: ionic: Add PHC state page for user space access Abhijit Gangurde
2026-06-06 5:00 ` [for-next v3 3/5] RDMA/ionic: map PHC state into user space Abhijit Gangurde
2026-06-06 5:00 ` [for-next v3 4/5] RDMA/ionic: add completion timestamp to CQE format Abhijit Gangurde
2026-06-06 5:00 ` [for-next v3 5/5] RDMA/mlx5: move mlx5 clock info to common struct ib_uverbs_clock_info Abhijit Gangurde
2026-06-08 17:30 ` Jason Gunthorpe [this message]
2026-06-08 21:20 ` [for-next v3 0/5] ionic: RDMA completion timestamping support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608173039.GE2764304@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox