From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 419BD25782A; Mon, 8 Jun 2026 18:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780944459; cv=none; b=tld73xi6m8VTzkJO2MRSUM2/OdGF9uQazu2JXXVNvX8TKsEwpNXO21sdDnv8rcz84Ql2yRRkxMGfaJx3AkhFQsCvalDkUmACDh2jUUrj5mn92Wcuir3ws6JwZQbFyzaJOpgNe6PXNeYv60zNb5dHKMyE+iSctAha4BXplYAuCzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780944459; c=relaxed/simple; bh=rPTlTseugqTt8+Ydju2GJZuV4m26u0vKUx87Hlan5Xs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NcxkfpgZrtg5llaA2u4hEKfn4FPowYu80oCzg7petV/WMjZ703NwjsN95xXwRlKiDv+4XsMG7L7BkSkbVwVA1US5g8dYAHhW14E/1156N+KbN6E3Vo6UiAhVIcD82aSS/zWZBaSTFWeoBVv+Rb9L/1cZlHsAxi8W3U28n9gIvAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iSV5nJDm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iSV5nJDm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68B251F00893; Mon, 8 Jun 2026 18:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780944458; bh=lyf/y2u1bO4hUmn6dQhfqSR5sYdLExgnJf82uOJss00=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iSV5nJDm4y9J2F7I06C098oJYHO5v1Ymc7DeaoT/wkUoGAU3LYd1mCNeowCzdhya+ cBPW3IKjvuS0yx1YbAS9tt02rHjznUMYJB/oSmDfKx/xCThhe2UdtwBwu3h1FFwDpp dRIDJvkc1Ra2COgc7pqBAoeIIf7EtuJ+BA8yf+21Za3HnTs4+3SBd+YlomYKF/iwU0 tjNZKNYB2W45ZrelRYj4SBokZZlmz4ELPjdhHqDruNGS5sey2s9NJRdQkcKdJW77Ho zqNeHjWrJAtNdVLjxFmBb6VIW4Qb7BXoxFokf2OSbwY4p+9ExYYiT+BogjPiyc75Ak uA0HpE0Hx9+Yw== Date: Mon, 8 Jun 2026 19:47:33 +0100 From: Simon Horman To: Kshitiz Bartariya Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, aleksandr.loktionov@intel.com, jacob.e.keller@intel.com, jedrzej.jagielski@intel.com, piotr.kwapulinski@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] ixgbe: implement get_queue_stats_rx Message-ID: <20260608184733.GJ3920875@horms.kernel.org> References: <20260603174857.78666-1-kshitiz.bartariya@zohomail.in> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603174857.78666-1-kshitiz.bartariya@zohomail.in> On Wed, Jun 03, 2026 at 11:18:51PM +0530, Kshitiz Bartariya wrote: > Hook into the netdev_stat_ops interface to expose per RX queue > statistics through the netdev generic netlink API. > > The following counters are filled: > > - alloc_fail: sum of alloc_rx_page_failed and alloc_rx_buff_failed > > - csum_bad: maps directly to csum_err, which is incremented for both > IP header and L4 checksum errors in ixgbe_rx_checksum(). > > The new per-queue stats can be observed with: > $ ynltool qstats show scope queue > > Signed-off-by: Kshitiz Bartariya > --- > v2: > Amended commit message with command to get RX queue stats as > suggested by Jedrzej Jagielski. > > v1: https://lore.kernel.org/lkml/20260602100932.21838-1-kshitiz.bartariya@zohomail.in/ > > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Hi Kshitiz, There is AI-generated review of this patch-set available on both https://sashiko.dev and https://netdev-ai.bots.linux.dev/sashiko/ I would appreciate it if you could look over that.