Re: [PATCH 1/3 net-next v5] ipv4: centralize devconf sysctl handling

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 8 Jun 2026 19:41:54 +0200 Fernando Fernandez Mancera wrote:
> On 6/8/26 6:03 PM, Jakub Kicinski wrote:
> > On Sun,  7 Jun 2026 13:01:21 +0200 Fernando Fernandez Mancera wrote:  
> >> The logic for handling IPv4 devconf sysctls is scattered. Notification
> >> and cache flushes are managed in devinet_conf_proc(), while a separate
> >> ipv4_doint_and_flush() function and DEVINET_SYSCTL_FLUSHING_ENTRY macro
> >> is used for properties that solely require a cache flush.  
> > 
> > Hi Fernando!
> > 
> > Do you have the necessary iproute2 patches pushed out somewhere?
> > I'll pull them in the CI to make sure the test works.
> >   
> 
> Oh sorry, I thought this was using iproute2-next.
> 
> Yes, feel free to find it either here [0] or pick it from [1].
> 
> [0] https://lore.kernel.org/netdev/20260601143242.6729-1-fmancera@suse.de/
> 
> [1] 
> https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=fdb064bf64e5df738f5f823a11f315340679d336

Tests pass, thanks!

but ruff check fails with

tools/testing/selftests/net/rtnetlink.py:45: [E722] Do not use bare `except`

There's a specific error cmd()/ip() raises on non-zero return, you can
catch that one.
-- 
pw-bot: cr