From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D004EA367; Tue, 9 Jun 2026 17:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781027291; cv=none; b=QK4d7tIpkNVPOUMXTuErJYlYzuhEmW5jiNxqidTV7RxXsvyZEBnXH4m5eSgENmVGxnxBG+pel4pT7U9uvqMkFDoqE5uoxCooKdHV0zULOmxRqk27XsePAMcczRSYUYiG1zzMbsRFPUh591ACyHYRpa6giraDasxwyhbwIrAxRH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781027291; c=relaxed/simple; bh=hRhpof256WQKvwovAWbRm1MWiOD2BnEzRGWngsNI+JE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tWbPAwBgqqQart2xwm8NpClj1H3ZqCGnYTBvwezb1+L1YiawmUYputpdvpIdX4wpQ6d5pXye2a53CT1k6kKdtbfwyyRkXdg97UtJwgPP8HrYhVDc5IH27LJgamui33tWB5PPe+hRY7dR2zG2AH8eJgo2VXKWcooZ22+jGx8S4Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LU05ovkq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LU05ovkq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAA491F00899; Tue, 9 Jun 2026 17:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781027289; bh=/VBdGVg26zQKWyJI8yfnf2xCXui05mQvSa45bIwcNzA=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=LU05ovkqpLA14pLPGSbnqIs+99r1EAo9hBgQSVYKf9woMNEhi40X6JpAAQz72Ri4u 1fFHrY/eefesyFsMbg8qyijalR4u2lWoYYPvEJSzTFj1s/dafREKvVb8j+uaMgkhKr hoSWMj4nB4L6CFn2F9HCB2ZOoxW5mXxHyDCO+dE1HekXaioxtSggK2QxvVQas3HZcs v+psq5ESY/HrhivwY3A6F71f2sd7eySWRmsP9wFKEUsV+TZXjuKnucNBTHYE8vAEju UEazM6eaMJVITuNFSApHXhQlli80dKGdioK2Sqcmg0iw6xrpplscK3Ar3RfRerGAsD kxMAxWy3WFT3g== From: Jeff Layton Date: Tue, 09 Jun 2026 13:47:33 -0400 Subject: [PATCH 12/19] nfsd: add fh_want_write() for early-verified SETATTR in nfsd_proc_setattr() Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260609-nfsd-testing-v1-12-e83acead2ae8@kernel.org> References: <20260609-nfsd-testing-v1-0-e83acead2ae8@kernel.org> In-Reply-To: <20260609-nfsd-testing-v1-0-e83acead2ae8@kernel.org> To: Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Christian Brauner , Benjamin Coddington , Donald Hunter , Lorenzo Bianconi , Qi Zheng , Andrew Morton , Muchun Song Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1192; i=jlayton@kernel.org; h=from:subject:message-id; bh=hRhpof256WQKvwovAWbRm1MWiOD2BnEzRGWngsNI+JE=; b=owEBbQKS/ZANAwAKAQAOaEEZVoIVAcsmYgBqKFG80QOEnXx9LKgofwY2TbK8Wb3WnhA80ooMD 3EOsw/lCByJAjMEAAEKAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCaihRvAAKCRAADmhBGVaC FewtEACmtY4axz/R+MEukW5LnRHHP3k0WsosoFh660ezMVBLqkr4UjS9g5IBH7Ly3k1j+e4dZA3 TLrjZyMq5us4H+KCtNYSMlvnELGUejh7ECKKZ3NBAiWSYJ6xne4YfydiqtYzpbndltQe3krBh97 oQjrQBUkOZ1tPo2UBbvRx8TVMi9EGUSzGzlpe8xV59ebYEELhTwwNQhAs2O1XVg2T41ffpXd82z Q6j/pZZj15NRHVMuhOessQXybwwXwt3owejv7FLXLTKw3i9AMuEQSgP+dKfmYvMctocizsmRmKW ov662ejP1FwEQ+6mQkUoFlS0Cs+BwRby/w3/8F2icXQTcqUgjdB7KLMPhNTJuB5H7Tvsm65bnRt y2uxu6Wa8iiFeiLMshOF3IL6NJ8ZawXBfpHipDT3h3me2K70bA2GYo7+jn0UhqN2/sh8z8Mmk+x smsdoGHUJ5p+DfM6m3wpfFrk6AVp8DZ3TZz5Uljy3cP/r4KHvQ6qRgLbXMLFk9HPV+TxDiXKUbt kbf+589FBx0xurchEaCaDoeMoY+via6jadlZxWLrwdAo3tfO1zgBVky9YkNlM2XaM+M/cx/IRR0 Y0VQEnfM86XR4Vw5p5TVFnimfQYwrOk+VKEsQz8xjl4zQho4NlotNcC7/eHqmNuQ1chrWJWOEdO hOe3vOW+bY85iGA== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 The BOTH_TIME_SET branch calls fh_verify() early so setattr_prepare() can inspect the dentry. This causes nfsd_setattr() to skip fh_want_write(), so notify_change() runs without a mount write reference. Add the missing fh_want_write() call after the early fh_verify(). Fixes: cc265089ce1b ("nfsd: Disable NFSv2 timestamp workaround for NFSv3+") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Jeff Layton --- fs/nfsd/nfsproc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c index 8873033d1e82..a73d5c259cd9 100644 --- a/fs/nfsd/nfsproc.c +++ b/fs/nfsd/nfsproc.c @@ -82,6 +82,7 @@ nfsd_proc_setattr(struct svc_rqst *rqstp) .na_iattr = iap, }; struct svc_fh *fhp; + int hosterr; dprintk("nfsd: SETATTR %s, valid=%x, size=%ld\n", SVCFH_fmt(&argp->fh), @@ -117,6 +118,12 @@ nfsd_proc_setattr(struct svc_rqst *rqstp) if (resp->status != nfs_ok) goto out; + hosterr = fh_want_write(fhp); + if (hosterr) { + resp->status = nfserrno(hosterr); + goto out; + } + if (delta < 0) delta = -delta; if (delta < MAX_TOUCH_TIME_ERROR && -- 2.54.0