From: Tariq Toukan <tariqt@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>
Cc: David Ahern <dsahern@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Simon Horman <horms@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
"Jonathan Corbet" <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Shuah Khan <shuah@kernel.org>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
Or Har-Toov <ohartoov@nvidia.com>,
"Carolina Jubran" <cjubran@nvidia.com>,
Moshe Shemesh <moshe@nvidia.com>, Shay Drori <shayd@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Daniel Zahka <daniel.zahka@gmail.com>,
Shahar Shitrit <shshitrit@nvidia.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Parav Pandit <parav@nvidia.com>,
Kees Cook <kees@kernel.org>,
Adithya Jayachandran <ajayachandra@nvidia.com>,
Daniel Jurgens <danielj@nvidia.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>, "Ido Schimmel" <idosch@nvidia.com>,
Jiri Pirko <jiri@nvidia.com>, Petr Machata <petrm@nvidia.com>
Subject: [PATCH iproute2-next 3/7] devlink: fix memory leak in resource_ctx_fini
Date: Tue, 9 Jun 2026 08:39:49 +0300 [thread overview]
Message-ID: <20260609053953.487152-4-tariqt@nvidia.com> (raw)
In-Reply-To: <20260609053953.487152-1-tariqt@nvidia.com>
From: Or Har-Toov <ohartoov@nvidia.com>
resource_ctx_init() allocates ctx->resources via resources_alloc()
which calls calloc(). resource_ctx_fini() calls resources_free() to
free the list items inside the struct, but never frees the struct
itself.
Signed-off-by: Or Har-Toov <ohartoov@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
devlink/devlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 7a8be3ad9b6a..ba14c0056b1c 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -7441,6 +7441,7 @@ static int resource_ctx_init(struct resource_ctx *ctx, struct dl *dl)
static void resource_ctx_fini(struct resource_ctx *ctx)
{
resources_free(ctx->resources);
+ free(ctx->resources);
}
struct dpipe_ctx {
--
2.44.0
next prev parent reply other threads:[~2026-06-09 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 5:39 [PATCH iproute2-next 0/7] devlink: add per-port resource support Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 1/7] devlink: Split dpipe tables output to a separate function Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 2/7] devlink: Move dpipe tables query to resources show callback Tariq Toukan
2026-06-09 5:39 ` Tariq Toukan [this message]
2026-06-09 5:39 ` [PATCH iproute2-next 4/7] devlink: add dump support for resource show Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 5/7] devlink: show port resources in resource dump Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 6/7] devlink: add per-port resource show support Tariq Toukan
2026-06-09 5:39 ` [PATCH iproute2-next 7/7] devlink: add scope filter to resource show Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609053953.487152-4-tariqt@nvidia.com \
--to=tariqt@nvidia.com \
--cc=ajayachandra@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=chuck.lever@oracle.com \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=daniel.zahka@gmail.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=shshitrit@nvidia.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox