From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 141252D97BB for ; Tue, 9 Jun 2026 07:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780989366; cv=none; b=T9b6j+sOHJWxOKUEy5NCucuR2ATqP116ENS+ZVpFyqXSYjaT/4g07jBKQs2pMXbB64dEox9Lpmjn2GUuR7RfTGrMBNpzTJpx7593gwB+JdK7nNh+t593gpDMCW1AbYXgQROYFIgsbthSpt7Ru0B2TQru8C2iylDkke6aws6PYb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780989366; c=relaxed/simple; bh=hh8plpyDLmp7qYUu71tv3I6n+HRBSPfE+afzPnmPQiM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XcKTKKs5EMiloPuKKXFxyfdjdFZLItLxgd2mXJdK4YLsmuHMDZPuZigMx3hxVLz8yDmUdoK8XvoJblyxi9mX1gzqy9HHnU8oV+lqeiOq6s415A68SGhK/vvmZGzRlfrD9VM4kMMc1NumaaaxyD5PNFcFeLQprBki/7z3IGl9rfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y+Ne68ze; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y+Ne68ze" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-372b4330deeso1533741a91.0 for ; Tue, 09 Jun 2026 00:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780989364; x=1781594164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J+WMj06VweuHxnnE2/mbYxrsGIb7CGFY2jdVSiz7USM=; b=Y+Ne68zeZu6b3jU4TF2p0IPS0aG+wg8ZFMfWS7/3HIoDgev5xmm5TN0mp5pR+WAO3X dNY6YiTfgrVIyWZpefkDUb1L8IioQoPwobHfUxF9I1UecXg3MKYVb8JEUUsxcj9tqJkl XgH9rWrddDnFhNdS9HsFYKkFlhFkpIab+4fNKZu5C6GjF1NJ7dQPjnvVYDDWEXP2aKXg /GYLawvL4PiIOkX/A+RZ24AU4BYfcV78+6OzkXF5+iNx48tWEW8ufEXPQiuPonYlOGgb RTP7q2LXyIalJnNm5MjtBcac/km0rzsfLMK28tpeoTzFEDfOGk6vh57Kr+nnkplkYcfx YJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780989364; x=1781594164; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J+WMj06VweuHxnnE2/mbYxrsGIb7CGFY2jdVSiz7USM=; b=V6XSWIhuoSEL7L3sHdyKfL9HkhNgaqRwzoKL7M+rHMBBPGHrFy1NFnAYe9jhaTyxaq vk/5keKR2RRowQE6cdRgzKsPy41UWq3KaTb748W4md517DNhHNQrRtUdVgjs8gSw0Z+5 oak4UMr7CR2rxADja2KLspam247VnMBQ2T2JxAxaURRDjMpGzzfQMm9R5a/BAqeHt9Oi EvuCLdfuMoxt8EMcEPJJHMsAKoutjb6e8zgigx5RSDbV2k2KK83KwfWAq6nQdhTBNwPb Sct4tVdsgBN3G2TTaLYJtwn7vAFTlBCmpI4u4Ge8ZloDLAM/l7DHn/BFDrpZ+pSWVYVe uWqA== X-Forwarded-Encrypted: i=1; AFNElJ+AHv1BwA9ScGiWr8BrEZ/znkJsIWINXKkZtX9oqOJPGoICoQk55v+KMjB17hpbjbc1J/zKYsA=@vger.kernel.org X-Gm-Message-State: AOJu0YwD5k8mRX+o9Y1obOm3KdWMhn2wjTC8GSISfzwn1ArdQ3TCCcwj 87hnfQ7tSQon5ATe0zXxWdnkGRBv3hgTR2hepjAIE0Pf6JoDmZJbnZvk X-Gm-Gg: Acq92OHBeyp067K+sUA4YNss7Jkp2Rer2HVm9g8/9kHlNvlZ0UPegfg4W4gcFvWI2yv NYqAWRlCcZaqOkFCAdeDfhn0vtkKHiqYw5/cwBmxqxky2WkG7Sk98VO1imTWySJJp2dipFIpgB0 hPtzHUtla8tsc5ex9WkZRET0tmm/79FyP24EpJpMAIJTxjaHyJzRAAoTte9utYSBmzD2AMBQXyx iZvxX4MMWvUt281dTu+PA/fJZCcWDZSxUD7y0340K8ak/FX7sSSh5shntu5xAB6SqJ/8C5IlmVi jCI1ecwGR/1ayDw1ULeK2D0V8ZZ5hPxZpuwnP3+7hnZvaJOjYs4F4K7XSowDcs9kb1yJl5gY13e 7dA8EAXPN3JPWWz3QYOf7RG0YtFcKtObDnw5deHUUGFXkb6eq1lh5TD1ddoL4IgXgSJrfltoYbu Zf6gWznUD6qo6O+59YZilmt6+ZDcQYCsWU/nQUfzs3RBjp7EUy8giWDg== X-Received: by 2002:a17:90b:5747:b0:36b:9798:4f67 with SMTP id 98e67ed59e1d1-370eee03facmr18953062a91.8.1780989364319; Tue, 09 Jun 2026 00:16:04 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:37c9:44fa:729b:6aaa]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6d1fec5asm18109501a91.10.2026.06.09.00.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 00:16:03 -0700 (PDT) From: Ruoyu Wang To: Chandrashekar Devegowda , Liu Haijun , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH net v2] net: wwan: t7xx: check skb_clone in control TX Date: Tue, 9 Jun 2026 15:15:56 +0800 Message-ID: <20260609071556.5-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit t7xx_port_ctrl_tx() clones each skb fragment before passing it to the port transmit path. The clone is used immediately to set cloned->len, so an skb_clone() failure results in a NULL pointer dereference. Return -ENOMEM if skb_clone() fails. Fixes: 36bd28c1cb0d ("wwan: core: Support slicing in port TX flow of WWAN subsystem") Signed-off-by: Ruoyu Wang --- Changes in v2: - Add Fixes tag. - Return -ENOMEM consistently on skb_clone() failure. drivers/net/wwan/t7xx/t7xx_port_wwan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wwan/t7xx/t7xx_port_wwan.c b/drivers/net/wwan/t7xx/t7xx_port_wwan.c index 7fc569565..01844d067 100644 --- a/drivers/net/wwan/t7xx/t7xx_port_wwan.c +++ b/drivers/net/wwan/t7xx/t7xx_port_wwan.c @@ -106,6 +106,8 @@ static int t7xx_port_ctrl_tx(struct t7xx_port *port, struct sk_buff *skb) while (cur) { cloned = skb_clone(cur, GFP_KERNEL); + if (!cloned) + return -ENOMEM; cloned->len = skb_headlen(cur); ret = t7xx_port_send_skb(port, cloned, 0, 0); if (ret) { -- 2.51.0