From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17238356760 for ; Tue, 9 Jun 2026 14:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781016676; cv=none; b=Rjb9XH8ETb1JI5nfIsN2gjS2OcwTQORbhg2PqGAWFhappNcKmTy2XBBZ+s+1YdkMi6DLAlS3SbyW3isfGgqo7PU/q6bLPffddYo2hCh1w4UL9eNfMmf4/eD+HBH180+FjjS0cpSv7Z1kyi4ukD3X/pif5yrQ7MQArxHEfX9v2BU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781016676; c=relaxed/simple; bh=gWQ/Il4P4t0zTHBxAJZA63W9tJWeyjxCRza7HeFyBSg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F/TeVuTW26gk6Wgz5G0UN095c2W4bb6i56s+QuV8dxJSFxumakuOeCMXtTx3oFgap22fEAFNFFGbQW2HyMuusvenuU5tFXVRAakfCGzOhxc8kOpPBebR0Us1gZh8X74RkexC2+eSXy66AXQl0ngjsZQPwwuRxEV8puYbqCy8mj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XAtxLEFL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=i+s4/No9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XAtxLEFL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="i+s4/No9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781016666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LzesbWGj4YTo1y0et+ljf+77fl9oQ9V4yKu6m9JZpcY=; b=XAtxLEFLmAddGaFg6XxTgE8KDCmEWP80SmZahaZ1P5HTupcrsit7dNDgIoyjTwTFlt0aMB mo7yok5RbOR3bkFTIcmvlCnIyv/ITi9/cgz21ispgs268J2XRtsX3FYNWoxKVW5t1o++hg 11F5kRO5QAPCQtkr6CEzIUMeAn08uNU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-awgJ0hqdPFaZpPvP2PEscQ-1; Tue, 09 Jun 2026 10:51:02 -0400 X-MC-Unique: awgJ0hqdPFaZpPvP2PEscQ-1 X-Mimecast-MFC-AGG-ID: awgJ0hqdPFaZpPvP2PEscQ_1781016661 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4601c9b630fso2308229f8f.0 for ; Tue, 09 Jun 2026 07:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781016661; x=1781621461; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LzesbWGj4YTo1y0et+ljf+77fl9oQ9V4yKu6m9JZpcY=; b=i+s4/No9MyoM/EZB/qJXtAkVNCYwnw7q9DHUHvBortGasB9V3tQ2RgpBL2eD8JUMhf WRb+hQkD4EiCCg+XONbjQtv8TyRUvqaEjh/z0RzMwahTeyqZyxxCrFIGuuMIB+IlmQ7a lW6k+OYdYw4z+HZYomVldaQoBGqeeq2WLnZZU9U8TNyG6b87FzUmJwwCq6mQFSFG5vDJ mDgU0veHdKA+gUSP/IyZ5qZ4Frrum3e3O0dpX0d22sP4UnYRNU5Yz0i22J8Yp3XPq7js oM5QYt6/h/x/o2jCx4tYmvymsjVmZKMmcBaUnzOh1BRSF5No2kBQh0gnfrJyEiLXrENA bA/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781016661; x=1781621461; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LzesbWGj4YTo1y0et+ljf+77fl9oQ9V4yKu6m9JZpcY=; b=FukZ7LkbEY9f9O1BZTkivoEGFnbmQ4K2f8OSGXNwJR/LYikA2hq+G11BYax9zlZAwz T3GhsjDKEMCrFVWpzldSv9Z2bgor0tm04ryHXSn8LbbNwRYa9QDfkBckeEVpD9BEH1/A qwTvOIqxAH7eKWzubx2rrMtqjm0ExH8HABNn+WllOoEZbtBN22lXJA0kEEZnBgZqWQHB f2DzQuJ7c+aAIieGbAGu77mKaXnNsme/nZU9OzQzUoE3lWnyfeRDLs81eX4IKMBiSWqs ZAHwLvZf0KBW264PylkiFyT8NfKkoPjrf++OlmbGlzU2cmA7K0UZGThTlKDwixVmv8G1 SO1w== X-Gm-Message-State: AOJu0YyGHlR0/sgDY/74zsQeYKHrPaniHEXGQtootWCPEVViGfdngS8g 3bwzQvi43wwy33JcwTKejVTre8jK3MXIrNfiKd3udO2/mUfxlKgRk6LWJJUUutIo0Xy5yBoU/+Y bO9hYjFdc/DsyqiU6QQo4rDNGStWcO0GD21AofUJpQgzEsx1RBF/wEFNdrQ== X-Gm-Gg: Acq92OGtuir4e4TsekMzRXaNJUyqKXM0HwngbeAxbsKodCEdCbIwU22LQ+LZiB++o60 gnEYmaxorg7kXaxsnkByILPkz3isSyi25RkhBuWKk4qVZ+KD7hjB2QKsmeEoYXvlbZSLnNQyxzJ 6wa/jU5q4R0bRiFvG2BPuhvrCHv29DPRlK8w0y+zpqt2NiNayf70jbKw8sE3+r5Tgvl7IyXtFP+ Q34OqrfMfgcqUFRNg5VeBnrnGk63Rtck+CULfBMiYmBUDtgaowX+/Ao+yM1Asa3JQWHul5KEkTM DrTjWedwwcrVjLtw/Y+F2bGRs35PooQcdNxi1ZaOquPhnvlXzDJZvnTj9bq9zcUVO0s8R+LhHYZ h534wDF6nhfkykwFbWrokX0Rwmx2DdLMfYO9Bg9VDQJWaWTrnwUV2tA== X-Received: by 2002:adf:e608:0:b0:44a:2cb3:b633 with SMTP id ffacd0b85a97d-460304fae53mr23680407f8f.12.1781016660809; Tue, 09 Jun 2026 07:51:00 -0700 (PDT) X-Received: by 2002:adf:e608:0:b0:44a:2cb3:b633 with SMTP id ffacd0b85a97d-460304fae53mr23680357f8f.12.1781016660290; Tue, 09 Jun 2026 07:51:00 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35133csm60643986f8f.25.2026.06.09.07.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 07:50:59 -0700 (PDT) Date: Tue, 9 Jun 2026 10:50:57 -0400 From: "Michael S. Tsirkin" To: Paolo Abeni Cc: netdev@vger.kernel.org, Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , virtualization@lists.linux.dev, Willem de Bruijn Subject: Re: [PATCH net] virtio_net: do not allow tunnel csum offload for non GSO packets Message-ID: <20260609105050-mutt-send-email-mst@kernel.org> References: <38d33d63ce5d1aee486bd6c7c47345040d526e35.1781016169.git.pabeni@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38d33d63ce5d1aee486bd6c7c47345040d526e35.1781016169.git.pabeni@redhat.com> On Tue, Jun 09, 2026 at 04:44:26PM +0200, Paolo Abeni wrote: > Fiona reports broken connectivity for virtio net setup using UDP tunnel > inside the guest and NIC with not UDP tunnel TSO support in the host. > > Currently the virtio_net driver exposes csum offload for UDP-tunneled, > TCP non GSO packets. Such packet reach the host as CSUM_PARTIAL ones > with the 'encapsulation' flag cleared, as the virtio specification do > not support this specific kind of offload. > > HW NICs with UDP tunnel TSO support - and those drivers directly > accessing skb->csum_start/csum_offset - are still capable of computing > the needed csum correctly, but otherwise the packets reach the wire with > bad csum on both the inner and outer transport header. > > Address the issue explicitly disabling csum offload for UDP tunneled, > non GSO packets via the ndo_features_check op. > > Fixes: 56a06bd40fab ("virtio_net: enable gso over UDP tunnel support.") > Reported-by: Fiona Ebner > Closes: https://bugzilla.proxmox.com/show_bug.cgi?id=7627 > Tested-by: Fiona Ebner > Signed-off-by: Paolo Abeni Acked-by: Michael S. Tsirkin > --- > drivers/net/virtio_net.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index f4adcfee7a80..07b8710639f9 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -6222,6 +6222,18 @@ static void virtnet_free_irq_moder(struct virtnet_info *vi) > rtnl_unlock(); > } > > +static netdev_features_t virtnet_features_check(struct sk_buff *skb, > + struct net_device *dev, > + netdev_features_t features) > +{ > + /* Inner csum offload is only available for GSO packets. */ > + if (skb->encapsulation && !skb_is_gso(skb)) > + return features & ~NETIF_F_CSUM_MASK; > + > + /* Passthru. */ > + return features; > +} > + > static const struct net_device_ops virtnet_netdev = { > .ndo_open = virtnet_open, > .ndo_stop = virtnet_close, > @@ -6235,7 +6247,7 @@ static const struct net_device_ops virtnet_netdev = { > .ndo_bpf = virtnet_xdp, > .ndo_xdp_xmit = virtnet_xdp_xmit, > .ndo_xsk_wakeup = virtnet_xsk_wakeup, > - .ndo_features_check = passthru_features_check, > + .ndo_features_check = virtnet_features_check, > .ndo_get_phys_port_name = virtnet_get_phys_port_name, > .ndo_set_features = virtnet_set_features, > .ndo_tx_timeout = virtnet_tx_timeout, > -- > 2.54.0