From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: [PATCH net-next v2 1/2] selftests: drv-net: so_txtime: remember to deploy the binaries
Date: Tue, 9 Jun 2026 11:08:02 -0700 [thread overview]
Message-ID: <20260609180803.1093428-2-kuba@kernel.org> (raw)
In-Reply-To: <20260609180803.1093428-1-kuba@kernel.org>
The test seems to be written with a single-host loopback
in mind. We need to deploy the binary to remote before
we run it. This is just fixing an obvious issue, but
more work will be needed to make the dual-host setup
work reliably. Most of the runs still fail with:
FAIL: start time already passed
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
tools/testing/selftests/drivers/net/so_txtime.py | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/drivers/net/so_txtime.py b/tools/testing/selftests/drivers/net/so_txtime.py
index b7be4cabbec2..abdd2371cc1a 100755
--- a/tools/testing/selftests/drivers/net/so_txtime.py
+++ b/tools/testing/selftests/drivers/net/so_txtime.py
@@ -18,14 +18,16 @@ from lib.py import NetDrvEpEnv, bkg, cmd, defer, tc
"""Main function. Run so_txtime as sender and receiver."""
slow_machine = os.environ.get('KSFT_MACHINE_SLOW')
- bin_path = cfg.test_dir / "so_txtime"
+ if not hasattr(cfg, "bin_remote"):
+ cfg.bin_local = cfg.test_dir / "so_txtime"
+ cfg.bin_remote = cfg.remote.deploy(cfg.bin_local)
tstart = time.time_ns() + (2000_000_000 if slow_machine else 200_000_000)
cmd_addr = f"-S {cfg.addr_v[ipver]} -D {cfg.remote_addr_v[ipver]}"
- cmd_base = f"{bin_path} -{ipver} -c {clockid} -t {tstart} {cmd_addr}"
- cmd_rx = f"{cmd_base} {args_rx} -r"
- cmd_tx = f"{cmd_base} {args_tx}"
+ cmd_args = f"-{ipver} -c {clockid} -t {tstart} {cmd_addr}"
+ cmd_rx = f"{cfg.bin_remote} {cmd_args} {args_rx} -r"
+ cmd_tx = f"{cfg.bin_local} {cmd_args} {args_tx}"
expect_fail = not expect_success
if slow_machine:
--
2.54.0
next prev parent reply other threads:[~2026-06-09 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 18:08 [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes Jakub Kicinski
2026-06-09 18:08 ` Jakub Kicinski [this message]
2026-06-09 18:08 ` [PATCH net-next v2 2/2] selftests: drv-net: so_txtime: check IP versions Jakub Kicinski
2026-06-09 18:44 ` [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609180803.1093428-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox