From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 2/4] net: shaper: drop unnecessary kfree_rcu in pre_insert
Date: Tue, 9 Jun 2026 11:32:22 -0700 [thread overview]
Message-ID: <20260609183224.1108521-3-kuba@kernel.org> (raw)
In-Reply-To: <20260609183224.1108521-1-kuba@kernel.org>
If we fail to insert a node into the XArray in net_shaper_pre_insert()
we can free it directly - it was never visible to the RCU readers.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
net/shaper/shaper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/shaper/shaper.c b/net/shaper/shaper.c
index a5b42b697a93..33958462e5e9 100644
--- a/net/shaper/shaper.c
+++ b/net/shaper/shaper.c
@@ -406,7 +406,7 @@ static int net_shaper_pre_insert(struct net_shaper_binding *binding,
prev = xa_store(&hierarchy->shapers, index, cur, GFP_KERNEL);
if (xa_err(prev)) {
NL_SET_ERR_MSG(extack, "Can't insert shaper into device store");
- kfree_rcu(cur, rcu);
+ kfree(cur);
ret = xa_err(prev);
goto free_id;
}
--
2.54.0
next prev parent reply other threads:[~2026-06-09 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 18:32 [PATCH net-next 0/4] net: shaper: follow ups to recent fixes Jakub Kicinski
2026-06-09 18:32 ` [PATCH net-next 1/4] net: shaper: drop redundant xa_lock() bracketing Jakub Kicinski
2026-06-09 18:32 ` Jakub Kicinski [this message]
2026-06-09 18:32 ` [PATCH net-next 3/4] net: shaper: add a comment why we don't need kfree_rcu() in flush Jakub Kicinski
2026-06-09 18:32 ` [PATCH net-next 4/4] net: shaper: add a note that we expect cap dumps to be tiny Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609183224.1108521-3-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox