From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5313EB114 for ; Tue, 9 Jun 2026 18:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781029948; cv=none; b=afI8ydW3ZM+2nrMZRXQPzqrtYwvMW7GnucAFRO2HlfHstKDufLKG0lguYejPA2HLKGUqEFGgUXlu6/1wU9qGjJNcnufMma0khU3ofadIP/E0WPXVcm/0MB3oTRvuZj1UOlXEpSii6Ibei4y6CqgTTXcUdK7ksn41P/G+Lsj+wys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781029948; c=relaxed/simple; bh=/qu2BSr+iBthGCMoYTyJdgMJ748+2ydtUQXTpunJU08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YRTBABOxDPWoVhDxnM6zV150V++yyycjLQmie0iH3Yf0cOKS4bNk5O8hPeEWiXqgS2Dm2teFHVXkriOMqw6L0t+c6unWPq6R6gZphviuQktofRWvnFAheBx8dmayE/isTO/9RxgbcYZXWoojuWO/1ZhgYtf9GUugTq+J0nYeDig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VUw+Gcfm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VUw+Gcfm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96F741F0089A; Tue, 9 Jun 2026 18:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781029946; bh=nUUvvKklIjZzg63JaFgSbx5oWv0Zv057Z+XikoE1ZxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VUw+GcfmHIdtCkO0db7pCqwGdEthJqZ0psogxuQcoei0ZMIerQ1r5xPjmQVw2EhyW ITTqYOeFONOXtjSI7wamSg9oVDdznKDknq2MjvMmZ7W+NLAYeR8szd5308FDUlWT0/ WNYeh0lVzO4FDWsaYbbgEf/9zdAyy/1PMSkWcx/gYi6MRzq4zQ/acIII9AsEIuaJUn NOHqpt8PEAvZeaBj6StwhjMvIw1R9gxADVlmrimSqDT12fSvfODDVgEI5W0WhyyHZT R8K15B7pNIGEG2AF2pT/69Qd4Dlyzh+6TNm01QNBM+VFg170qhmeWtO3HtXvRVMfrO EsLxh71s8J6Jg== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, Jakub Kicinski Subject: [PATCH net-next 2/4] net: shaper: drop unnecessary kfree_rcu in pre_insert Date: Tue, 9 Jun 2026 11:32:22 -0700 Message-ID: <20260609183224.1108521-3-kuba@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609183224.1108521-1-kuba@kernel.org> References: <20260609183224.1108521-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If we fail to insert a node into the XArray in net_shaper_pre_insert() we can free it directly - it was never visible to the RCU readers. Signed-off-by: Jakub Kicinski --- net/shaper/shaper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/shaper/shaper.c b/net/shaper/shaper.c index a5b42b697a93..33958462e5e9 100644 --- a/net/shaper/shaper.c +++ b/net/shaper/shaper.c @@ -406,7 +406,7 @@ static int net_shaper_pre_insert(struct net_shaper_binding *binding, prev = xa_store(&hierarchy->shapers, index, cur, GFP_KERNEL); if (xa_err(prev)) { NL_SET_ERR_MSG(extack, "Can't insert shaper into device store"); - kfree_rcu(cur, rcu); + kfree(cur); ret = xa_err(prev); goto free_id; } -- 2.54.0