From: Jakub Kicinski <kuba@kernel.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: timur@kernel.org, netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: qualcomm: emac: replace strcpy() with strscpy()
Date: Tue, 9 Jun 2026 18:39:09 -0700 [thread overview]
Message-ID: <20260609183909.2fa53143@kernel.org> (raw)
In-Reply-To: <20260607154423.67146-1-dennylin0707@gmail.com>
On Sun, 7 Jun 2026 15:44:23 +0000 Hungyu Lin wrote:
> Replace strcpy() with strscpy() in emac_get_strings().
>
> strscpy() is the preferred string copy helper in the kernel and
> provides better bounds checking semantics.
strcpy() on a literal falls under pointless cleanups, IMO:
Quoting documentation:
Clean-up patches
~~~~~~~~~~~~~~~~
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:
* Addressing ``checkpatch.pl``, and other trivial coding style warnings
* Addressing :ref:`Local variable ordering<rcs>` issues
* Conversions to device-managed APIs (``devm_`` helpers)
This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.
Conversely, spelling and grammar fixes are not discouraged.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
next prev parent reply other threads:[~2026-06-10 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 15:44 [PATCH] net: qualcomm: emac: replace strcpy() with strscpy() Hungyu Lin
2026-06-10 1:39 ` Jakub Kicinski [this message]
2026-06-10 3:33 ` Hungyu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609183909.2fa53143@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dennylin0707@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox