From: Jakub Kicinski <kuba@kernel.org>
To: Ren Wei <n05ec@lzu.edu.cn>
Cc: netdev@vger.kernel.org, yuantan098@gmail.com,
yifanwucs@gmail.com, tomapufckgml@gmail.com, bird@lzu.edu.cn,
zcliangcn@gmail.com
Subject: Re: [PATCH net v2 1/2] llc: conn: use one state snapshot in llc_conn_service
Date: Tue, 9 Jun 2026 18:58:18 -0700 [thread overview]
Message-ID: <20260609185818.309ebf30@kernel.org> (raw)
In-Reply-To: <86c82b564186dd085fae59984ea481493341b823.1780850934.git.zcliangcn@gmail.com>
On Mon, 8 Jun 2026 15:46:53 +0800 Ren Wei wrote:
> llc_conn_service() only rejects states above NBR_CONN_STATES before
> the state machine lookup. That misses LLC_CONN_OUT_OF_SVC, whose value
> is 0.
Warning: ../net/llc/llc_conn.c:393 function parameter 'state' not described in 'llc_qualify_conn_ev'
--
pw-bot: cr
prev parent reply other threads:[~2026-06-10 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 7:46 [PATCH net v2 1/2] llc: conn: use one state snapshot in llc_conn_service Ren Wei
2026-06-08 7:46 ` [PATCH net v2 2/2] llc: conn: publish OUT_OF_SVC before draining timers Ren Wei
2026-06-10 1:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609185818.309ebf30@kernel.org \
--to=kuba@kernel.org \
--cc=bird@lzu.edu.cn \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=tomapufckgml@gmail.com \
--cc=yifanwucs@gmail.com \
--cc=yuantan098@gmail.com \
--cc=zcliangcn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox