From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BFCC4D2EF3 for ; Tue, 9 Jun 2026 19:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781032093; cv=none; b=mVULfuXBtqTXKA/b4VH1PES9FBiwdN/k19c3pW1ru1b/wutVteLW1W8fXXXpJt4nlQ+0EaCTQi4tXrDD+6TPlYHvIE13L9cXyR/3xn2h1i4zyPbmaX2/usVJl5ZV8eTUUSgtFiN3g+zyWgI1bVrPy344d+vlPvM35tKaGIv6GI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781032093; c=relaxed/simple; bh=x1NwOU2N2pdU0syA2m2kuvNOsaWicJKJc6cO7rwl5jc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XP4DBglrHq92Q1yIL2dp71Eh4+sp7z0KqSQNcVmGIHukh28iLc9VNf2w+JO7PyjWC/Qs5JxsgFRkLvtWSXap/OW2iqUl/+drNA6c8HaVbEdh178PVlcOg2PuWBZu96YH+ELnAjT14MBdt5ugINkTT9+TMm4fk18CN8hYkcpjldI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G4oofpY/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G4oofpY/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99FFC1F0089C; Tue, 9 Jun 2026 19:08:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781032092; bh=7wOiIVEJvTrcnprZMoyo+F5xJjProJiCsE9kyJM4NBM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=G4oofpY/J9cTPnDIpz5DyOiT38kMYYudK7HTmqhHgGfMwuFxdNaSfcSCJlmO6tBA9 iwlWO6e6mfa3W5Zp1louXWv4fZxww2dE8Fh9gOv0VVMt5vRzdqG/9jNnTgkQREY+ZN QKTOM2OvTiFbp4R50AopboPdN7RZH2ZdP/THk7nfyVdA6jF8elOF+bvy4mLEtSE/nb sHPOTYBoL7+sghn61MhhZ6yHoRCfR2nFN8ocwzoqbfb+Fvsgb1+IdjUuENwpj2xWV7 XzNfPqaoieOjgIHSM8z4t6ePPnHHbvZdOP6NCfq5dwaP3WgPb379AYV4xTbvQs879r 7bYUyWbkwgbKQ== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, dw@davidwei.uk, daniel@iogearbox.net, razor@blackwall.org, sdf@fomichev.me, dtatulea@nvidia.com, bobbyeshleman@meta.com, Jakub Kicinski Subject: [PATCH net-next 4/4] netdev: don't use dev->flags for IFF_UP Date: Tue, 9 Jun 2026 12:08:04 -0700 Message-ID: <20260609190804.1137085-5-kuba@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609190804.1137085-1-kuba@kernel.org> References: <20260609190804.1137085-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit dev->flags are not technically ops lock protected. The IFF_UP flag will not change when dev->lock is held, but other flags may change so KCSAN would probably not be impressed. Because of this we added a dedicated dev->up which is safe to read under dev->lock. qstats want to make sure device is up, use dev->up. Signed-off-by: Jakub Kicinski --- net/core/netdev-genl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index 18046ad0f883..745e2eb6c9af 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -773,7 +773,7 @@ netdev_nl_stats_by_queue(struct net_device *netdev, struct sk_buff *rsp, const struct netdev_stat_ops *ops = netdev->stat_ops; int i, err; - if (!(netdev->flags & IFF_UP)) + if (!netdev->up) return 0; i = ctx->rxq_idx; -- 2.54.0