From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5489C40B364; Wed, 10 Jun 2026 15:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781104477; cv=none; b=CU2qGZuBv+7TVziboiAbZ5bfSmRFMBY/zeQLbSY1cS2nyybEcrotZ/vnKr7rhOxFo09QzoaDoGcl6br4FSOFZXji73MKsTpY/u2A4cMY8M6pT1AVPRWE1UtkhBrTe+YMJSnDtqoscakcHEyVStwRlyDWNzuotS9QnlTIzLF3Yh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781104477; c=relaxed/simple; bh=O4ESASxXJTBkmgS2eT0NxJimSSFVGnXuyGlnizkC9/M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KkH/2ozQTZxRbSCaQv24sotak37vm2rgCyVaHY1/hE5Fk9kdn0l5Nqk9j/LNX4zASDAsh+ytJDooamS3OTTuPIP9+fi2e1C0DwdJUYYpkbaIDr/PnGmY5ELdF5kq+KrLUZPBbwjJ+50rqV2zC2QkM+nh5Br6LmIXQtfKcEx1EKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U/zA5YJN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U/zA5YJN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C72C1F00893; Wed, 10 Jun 2026 15:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781104476; bh=GLeTvS7KTUFpD6LfplzKEmpJrqfI0Ec5tYBniK/zx6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=U/zA5YJNyG0v9Tkb8N08UsOaggJjv6nmcfJyFhhIdvham0SugCTVlm3E5AJNz3q4+ 0ChixKfe8/i7aTSwKD/adpyDvqRqMZi0FOIBDJK56qYMDjMsyHqTtZDIQXUMI5pyoi DKnqCnpdWdBUW1ycIHiQ4D6c9VZjwuLzIjDAszVX7dKvD/2VddHtwVhS6/9XZeMSH0 yLb2SvaB8bq8yJVt7x6RLHlJP7qkqRPmO+hvELQ/oygy3N7+MHqhgLiHoEsd4/eRg8 D63LMbX7OgbAdOdlML3jU2mrqMKRAVUiW8tiEYj3GBur/Zr24n8DCu9ShQRDE7LVH2 hrcfTkY4YzSEw== Date: Wed, 10 Jun 2026 16:14:30 +0100 From: Simon Horman To: nshettyj@marvell.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, hkelam@marvell.com, sbhatta@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, rkannoth@marvell.com, sumang@marvell.com, kirankumark@marvell.com Subject: Re: [PATCH net] octeontx2-af: fix IP fragment flag corruption on custom KPU profile load Message-ID: <20260610151430.GN3920875@horms.kernel.org> References: <20260608095455.1499203-1-nshettyj@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260608095455.1499203-1-nshettyj@marvell.com> On Mon, Jun 08, 2026 at 03:24:55PM +0530, nshettyj@marvell.com wrote: > From: Kiran Kumar K > > npc_cn20k_apply_custom_kpu() overwrites KPU profile entries with custom > firmware values and then calls npc_cn20k_update_action_entries_n_flags() > over all entries. Since the same function already ran during default > profile initialisation, entries not overridden by the custom firmware > get their flags translated twice, corrupting the CN20K-specific values. > > Fix this by extracting the per-entry translation into a helper > npc_cn20k_translate_action_flags() and calling it as each custom entry > is loaded, removing the redundant batch call at the end. > > Fixes: ef992a0f12e8 ("octeontx2-af: npc: cn20k: MKEX profile support") > Cc: Suman Ghosh > Signed-off-by: Kiran Kumar K > Signed-off-by: Nitin Shetty J Reviewed-by: Simon Horman