From: David Yang <mmyangfl@gmail.com>
To: netdev@vger.kernel.org
Cc: David Yang <mmyangfl@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: dsa: yt921x: Add limited ACL flow statistics support
Date: Thu, 11 Jun 2026 04:25:05 +0800 [thread overview]
Message-ID: <20260610202508.845328-1-mmyangfl@gmail.com> (raw)
The yt921x supports flow statistics, which might be used to implement
.cls_flower_stats(). However, the number of flow counter are limited,
and you must choose between byte mode or packet mode. As there is no
interface for statistics preference for now, we pick one on our own
initiative.
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/net/dsa/yt921x.c | 87 ++++++++++++++++++++++++++++++++++++++++
drivers/net/dsa/yt921x.h | 13 ++++++
2 files changed, 100 insertions(+)
diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c
index 9929676a15e1..a553c966916a 100644
--- a/drivers/net/dsa/yt921x.c
+++ b/drivers/net/dsa/yt921x.c
@@ -373,6 +373,11 @@ yt921x_regs_clear_bits(struct yt921x_priv *priv, u32 reg, const u32 *masks,
return yt921x_regs_write(priv, reg, vs, num_regs);
}
+static int yt921x_reg64_read(struct yt921x_priv *priv, u32 reg, u32 *vals)
+{
+ return yt921x_regs_read(priv, reg, vals, 2);
+}
+
static int
yt921x_reg64_write(struct yt921x_priv *priv, u32 reg, const u32 *vals)
{
@@ -2224,6 +2229,40 @@ yt921x_acl_reserve(struct yt921x_priv *priv, unsigned int entscnt,
return UINT_MAX;
}
+static int
+yt921x_acl_stat(struct yt921x_priv *priv, enum tc_setup_type type,
+ unsigned long tag, u64 *statp)
+{
+ const struct yt921x_acl_rule *aclrule;
+ const struct yt921x_acl_blk *aclblk;
+ unsigned int statid;
+ unsigned int binid;
+ unsigned int blkid;
+ unsigned int entid;
+ u32 vals[2];
+ int res;
+
+ entid = yt921x_acl_find(priv, type, tag);
+ if (entid == UINT_MAX)
+ return -ENOENT;
+
+ blkid = entid / YT921X_ACL_ENT_PER_BLK;
+ binid = entid % YT921X_ACL_ENT_PER_BLK;
+ aclblk = priv->acl_blks[blkid];
+ aclrule = aclblk->rules[binid];
+
+ if (!(aclrule->action[0] & YT921X_ACL_ACTa_FLOWSTAT_EN))
+ return -EOPNOTSUPP;
+
+ statid = FIELD_GET(YT921X_ACL_ACTa_FLOWSTAT_ID_M, aclrule->action[0]);
+ res = yt921x_reg64_read(priv, YT921X_FLOWSTATn_STAT(statid), vals);
+ if (res)
+ return res;
+
+ *statp = ((u64)vals[1] << 32) | vals[0];
+ return 0;
+}
+
static int
yt921x_acl_commit(struct yt921x_priv *priv, unsigned int entid, u8 entsmask)
{
@@ -2336,6 +2375,10 @@ yt921x_acl_del(struct yt921x_priv *priv, enum tc_setup_type type,
clear_bit(FIELD_GET(YT921X_ACL_ACTa_METER_ID_M,
aclrule->action[0]),
priv->meters_map);
+ if (aclrule->action[0] & YT921X_ACL_ACTa_FLOWSTAT_EN)
+ clear_bit(FIELD_GET(YT921X_ACL_ACTa_FLOWSTAT_ID_M,
+ aclrule->action[0]),
+ priv->flowstats_map);
priv->acl_masks[blkid] &= ~aclrule->mask;
kvfree(aclrule);
if (!priv->acl_masks[blkid]) {
@@ -2355,11 +2398,13 @@ yt921x_acl_add(struct yt921x_priv *priv,
struct yt921x_acl_blk *aclblk;
bool use_trap = false;
unsigned int meterid;
+ unsigned int statid;
unsigned long mask;
unsigned int binid;
unsigned int blkid;
unsigned int entid;
unsigned int o;
+ u32 ctrl;
int res;
/* Allocate resources */
@@ -2386,6 +2431,22 @@ yt921x_acl_add(struct yt921x_priv *priv,
}
}
+ statid = find_first_zero_bit(priv->flowstats_map, YT921X_FLOWSTAT_NUM);
+ if (statid < YT921X_FLOWSTAT_NUM) {
+ u32 zeros[2] = {};
+
+ ctrl = YT921X_FLOWSTAT_CTRL_EN | YT921X_FLOWSTAT_CTRL_TYPE_FLOW;
+ res = yt921x_reg_write(priv, YT921X_FLOWSTATn_CTRL(statid),
+ ctrl);
+ if (res)
+ return res;
+
+ res = yt921x_reg64_write(priv, YT921X_FLOWSTATn_STAT(statid),
+ zeros);
+ if (res)
+ return res;
+ }
+
/* Prepare acl block ctrlblk */
blkid = entid / YT921X_ACL_ENT_PER_BLK;
binid = entid % YT921X_ACL_ENT_PER_BLK;
@@ -2426,6 +2487,9 @@ yt921x_acl_add(struct yt921x_priv *priv,
aclrule->action[0] |= YT921X_ACL_ACTa_METER_ID(meterid);
else
aclrule->action[0] &= ~YT921X_ACL_ACTa_METER_EN;
+ if (statid < YT921X_FLOWSTAT_NUM)
+ aclrule->action[0] |= YT921X_ACL_ACTa_FLOWSTAT_EN |
+ YT921X_ACL_ACTa_FLOWSTAT_ID(statid);
/* Write rules */
aclblk->rules[binid] = aclrule;
@@ -2438,6 +2502,8 @@ yt921x_acl_add(struct yt921x_priv *priv,
if (meterid < YT921X_METER_NUM)
set_bit(meterid, priv->meters_map);
+ if (statid < YT921X_FLOWSTAT_NUM)
+ set_bit(statid, priv->flowstats_map);
priv->acl_masks[blkid] |= aclrule->mask;
return 0;
@@ -2449,6 +2515,26 @@ yt921x_acl_add(struct yt921x_priv *priv,
return res;
}
+static int
+yt921x_dsa_cls_flower_stats(struct dsa_switch *ds, int port,
+ struct flow_cls_offload *cls, bool ingress)
+{
+ struct yt921x_priv *priv = to_yt921x_priv(ds);
+ int res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_acl_stat(priv, TC_SETUP_CLSFLOWER, cls->cookie,
+ &cls->stats.bytes);
+ mutex_unlock(&priv->reg_lock);
+
+ if (res)
+ return res;
+
+ cls->stats.used_hw_stats = FLOW_ACTION_HW_STATS_IMMEDIATE;
+ cls->stats.used_hw_stats_valid = true;
+ return 0;
+}
+
static int
yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,
struct flow_cls_offload *cls, bool ingress)
@@ -4817,6 +4903,7 @@ static const struct dsa_switch_ops yt921x_dsa_switch_ops = {
.port_policer_add = yt921x_dsa_port_policer_add,
.port_setup_tc = yt921x_dsa_port_setup_tc,
/* acl */
+ .cls_flower_stats = yt921x_dsa_cls_flower_stats,
.cls_flower_del = yt921x_dsa_cls_flower_del,
.cls_flower_add = yt921x_dsa_cls_flower_add,
/* hsr */
diff --git a/drivers/net/dsa/yt921x.h b/drivers/net/dsa/yt921x.h
index 555046526669..5952900f1794 100644
--- a/drivers/net/dsa/yt921x.h
+++ b/drivers/net/dsa/yt921x.h
@@ -759,6 +759,16 @@ enum yt921x_l4_type {
#define YT921X_METER_CTRLa_EIR_M GENMASK(17, 0)
#define YT921X_METER_CTRLa_EIR(x) FIELD_PREP(YT921X_METER_CTRLa_EIR_M, (x))
#define YT921X_METERn_STAT(x) (0x221000 + 8 * (x))
+#define YT921X_FLOWSTATn_STAT(x) (0x221400 + 8 * (x))
+#define YT921X_FLOWSTATn_CTRL(x) (0x221c00 + 4 * (x))
+#define YT921X_FLOWSTAT_CTRL_EN BIT(3)
+#define YT921X_FLOWSTAT_CTRL_PKT_MODE BIT(2) /* 0: byte mode */
+#define YT921X_FLOWSTAT_CTRL_TYPE_M GENMASK(1, 0)
+#define YT921X_FLOWSTAT_CTRL_TYPE(x) FIELD_PREP(YT921X_FLOWSTAT_CTRL_TYPE_M, (x))
+#define YT921X_FLOWSTAT_CTRL_TYPE_FLOW YT921X_FLOWSTAT_CTRL_TYPE(0)
+#define YT921X_FLOWSTAT_CTRL_TYPE_CPU_CODE YT921X_FLOWSTAT_CTRL_TYPE(1)
+#define YT921X_FLOWSTAT_CTRL_TYPE_DROP_CODE YT921X_FLOWSTAT_CTRL_TYPE(2)
+#define YT921X_FLOWSTAT_CTRL_TYPE_PORT YT921X_FLOWSTAT_CTRL_TYPE(3)
#define YT921X_PORTn_VLAN_CTRL(port) (0x230010 + 4 * (port))
#define YT921X_PORT_VLAN_CTRL_SVLAN_PRIO_EN BIT(31)
@@ -830,6 +840,8 @@ enum yt921x_fdb_entry_status {
#define YT921X_SHAPE_CIR_MAX ((1 << 18) - 1)
#define YT921X_SHAPE_CBS_MAX ((1 << 14) - 1)
+#define YT921X_FLOWSTAT_NUM 64
+
#define YT921X_LAG_NUM 2
#define YT921X_LAG_PORT_NUM 4
@@ -969,6 +981,7 @@ struct yt921x_priv {
u16 eee_ports_mask;
DECLARE_BITMAP(meters_map, YT921X_METER_NUM);
+ DECLARE_BITMAP(flowstats_map, YT921X_FLOWSTAT_NUM);
u8 acl_masks[YT921X_ACL_BLK_NUM];
struct yt921x_acl_blk *acl_blks[YT921X_ACL_BLK_NUM];
--
2.53.0
next reply other threads:[~2026-06-10 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 20:25 David Yang [this message]
2026-06-14 0:45 ` [PATCH net-next] net: dsa: yt921x: Add limited ACL flow statistics support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610202508.845328-1-mmyangfl@gmail.com \
--to=mmyangfl@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox