From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63011E555 for ; Thu, 11 Jun 2026 01:43:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781142190; cv=none; b=fai5ePqZu2YSPKp1quxVZXLCBTlax+FiBByQvt4bpuxgehE5cqkx5ei9ZaDbzEnKTuGx66VxOOT9yKwTgxjGKO3EDp+0DKlZr7elA3izYD39yNHwwDYenWCZcOp32Udsgx9Z/pf2Iq597rwHy7OU5s30QVB/BXiSH15Xl5ZTIgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781142190; c=relaxed/simple; bh=+n513kDZ3TcIR4W2QVHnQqu/cInucM+9o9ze9SW7VLw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DWzcPD9OaWwnoGuFi4L3Ya4wHtMfMPPffg0vHnzMfIgcYzJx2miYIu/IUADGpQGgsgqtnfg8KlTS8KrzKEVvTexIWozXvNlMxGvgrCkBTXXXD08p4mkIVlQsbz5NmnG97HUmvTphAsELp1cmw12CbcZsCFX4lzlrofN0aLINFyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gSrkfHLx; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gSrkfHLx" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2bf1cda2b17so3328965ad.1 for ; Wed, 10 Jun 2026 18:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781142189; x=1781746989; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+n513kDZ3TcIR4W2QVHnQqu/cInucM+9o9ze9SW7VLw=; b=gSrkfHLx0/sm5xF0dE9ugXREgvgnUgTHn9r2qRvHxlwqC3DEtOm7x8J07wsffXgUij 65gj9SBrRbdOQR79pNHdLSGL24QuaA/5HGG8YWXydBInr17TlirAjn6W+EOtSw8bma7u aRo7xXqRPdV/lMKSGT1IBt9en0jn8S81u4Q9xe8owCAky9I/OuSXklZMLMmqq8nfLp9A agZmjfAGN/pX0Bbj0XMACxE4qcmEBPBltDC3S1BzwMZhzLyGyZYLlA8PKXz/jGpVdq9D QOH1uz76J6ugoX46YNdgYBrU1MSqnqmar4TSlObpbPO8aJd849eHchbczM4Mle4KDyV6 3Uyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781142189; x=1781746989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+n513kDZ3TcIR4W2QVHnQqu/cInucM+9o9ze9SW7VLw=; b=P/ca61kNm3zC2wx9FR0bJaeRkWBn4g1FJ7pgDVC+7nWfNcjerw94F9X9SwbKvvg5aq Kj+l1V2vdgRGm3HFU/qx8BOJuyPaXJg2rWVT0GKFS8xcC50IQWeov0ZwTZ3q1UfvnX2r ffF5X2Odbus2sWfMTAweSrto5shrMH4hoSrj3hgnxjH/oOwfQY4eypv6iuvPRcnDBaJB hhwDFBwg9MtU9xku6HBO6swwBwbeYWxL47kGq+KUr3uGA/ra0t8zOQqlG4gS1wLcFwD7 7zXJkqYX2YlRl/YxnOLyqqRDYZAqUTLdMeklkPoosHQi+MC1b2xgSj9YdaeXqVpB83Uu gXpw== X-Gm-Message-State: AOJu0YzugwWOAevsxj/ZfS9tJYyj+XDXhkcCTKtWHmbiDXGgSgKljX1m I5zA5DongIDAQp+AS4c2uDgXI4sqrhCJx1wIq6ejT0A0INEcyp8k3Ds= X-Gm-Gg: Acq92OHJGxGhbkHDpB5fhXwGpNCtgnAw3quYEj42CBy7790zZIJFCL3WEH+VynBpq8m iq3NK613DJ28kgRKV8D2Rjgr6Hqt+P0mjbSV3JiDg//ZTKg54EewWDUBa2Xdy1Q3bGfruhWkroH Rawzpmj8FZ55UGfOQjLFo1fxOfEdA4jTuo6BGmbCjD5HY1UiN6uuGoJSP9bWQ4xfep2O49eZn6B wIKoEIMgoDYwElm5PAztBt4rHPuTSBtybMY/fgV0JXs2NAP4XKm16VzUvwubiZPhPvlPfHCv+DQ PeGF3fHdiQYhx2gcPqcnIhs7+FiGyLworZN8PVQ20ilaTMUxplKKfVcysAT1O5ib96UPZNeFjt3 GOqKzUSI911xypVmIrgmNBGrkoJ94H3hMPy7moJbgQ35PAGIc9sZGNzkoTl+zeZ/dzHTU45C19h 0s6eWJf2DgY5WoTYZEZcDygvTzPMc744JLRTfV4NYMRaadlPt+djux7b1IchlRL4P4iP2pih+5m nTtVg== X-Received: by 2002:a17:903:320e:b0:2c0:c262:b924 with SMTP id d9443c01a7336-2c2f7203258mr5001395ad.13.1781142188609; Wed, 10 Jun 2026 18:43:08 -0700 (PDT) Received: from raf.tailb4a862.ts.net ([153.124.163.116]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16609e636sm260924895ad.51.2026.06.10.18.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 18:43:08 -0700 (PDT) From: Raf Dickson To: bobbyeshleman@gmail.com Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev, pabeni@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, bryan-bt.tan@broadcom.com, vishnu.dasa@broadcom.com, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH net-next 1/2] vsock: fold sk_acceptq_added() into vsock_enqueue_accept() Date: Thu, 11 Jun 2026 01:43:01 +0000 Message-ID: <20260611014301.22599-1-rafdog35@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, Jun 10, 2026 at 16:12:37 -0700, Bobby Eshleman wrote: > It looks like vmci might be an odd duck here, where sk_acceptq_added > actually pairs with vsock_add_pending(), instead of > vsock_enqueue_accept()... > > For example, if the pending work timer below fires, vsock_pending_work() > will see vsock_is_pending() is true, and then hit sk_acceptq_removed() > and underflow the zero backlog counter? You're right, thank you for catching that. In vmci sk_acceptq_added() pairs with vsock_add_pending(), not vsock_enqueue_accept(), so moving it would cause an underflow when the pending work timer fires without a successful connection. Patch 2/2 is unaffected. I'll send a v2 that keeps the vmci call site as-is and only folds the virtio and hyperv sites into vsock_enqueue_accept(). Raf