From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A993832FA14 for ; Thu, 11 Jun 2026 07:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781161785; cv=none; b=jZyO9rZIloVihQswktNNMiPng+805mFNcGehW17AShM8NdCFmJKIslZqYAeoYQc738j2aopqYSvd2uaNSOD7KtynLnCIIMypx70tqOCDX9FwBrV/v3Tz4CvZX20RA1ljipLPmt7U5rmeu2hZZnmOUGgKtfdyPg5aP0N6PPcyTIQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781161785; c=relaxed/simple; bh=LKZkxge+/v6SAk9zEBTdm7nNlWehxrJKWFBOkQa42X4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rkwXHQkJ/Fu3bPg+1/pWTwlonHg5rZAArp9Me9p4pUJQEPv5sUZQXclM+nBveyE6W4g0E3L+CqQyW2Egb1m1aPnEU8nEpFsYJXaQpHElRMtoSUzFKrgtY3912J4VQKr2d/J4p4h1BCd3zLSDwulL4esDAJBT6FWyQ5lOfbLSNtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c9nzDk74; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c9nzDk74" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf20f6be6bso60337555ad.3 for ; Thu, 11 Jun 2026 00:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781161784; x=1781766584; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qc5McNJZWXcInPiqjiZYGkHhDZEjUFo5MulDJfEtkWc=; b=c9nzDk74r6kyHQcBdiR2VCkxckg8JHUr6ZN2hNPJV4AooR6byM8eEGrpWo10SDjAJ6 y78v6g9VyjVjlUEDXlw4rDenobTTbCXPm6UITmhR8Qj8lzoltG/Tfk7huyQ1EyMu7mSY pVBCz0ROjHiFPOSkblr2XEhKwU/qCF7NFXqSAiswLFgAUg2eAMuu72dqcP3LgRi8PFmK bz/eYt/rbNMrOuXAE8QP7F21haGK/UrBJbSDXT9gmcNuKNU9ulAK6LjWMtuqVRjZasek QNTo3VKd+Q6tvRqxI2iTIQgx8FBEtgGVWahpU/Quo6/zPf0fTHwDojea2SvvD8ekEYl1 MhIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781161784; x=1781766584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qc5McNJZWXcInPiqjiZYGkHhDZEjUFo5MulDJfEtkWc=; b=q5cuV/twDxPYec0q4LC9PyVtBNAwA/Agpn3PUKRHi0V/MjJ/oVq0XxIc8RZ1z0Fwxy 9woq2TaSZAo0rye62h+31qAc0xv1eXzzxyu0HJjp4a4dmOynOKO8IeJkXuo2UZFWEkmm 2JQe8+hSyggdGXbMBR6wRW76DEWV5//9gvEMtvpGK2qmUOd24g5pMG0A2Y1HZtW+OIoQ m7LXTiyccXi9XFJmsWcr8TUhe9xJjTZZ+45ltp44sxy5QbJcLQ+VwAXo4tyt9+sXr5Vf hvziUs+ULCZSyv3tJyrx1xTE5GcKsleqSkoQmzCNQirELVyzjU6EuvQ7tVqRuBZROKo8 tCNw== X-Gm-Message-State: AOJu0YxJ8LJdd4Qz5T29J3wwcJgnO/rT9OkHVEBjLWx2UJqUA+gSIKoP /opn7wes6UqdmIXxxLEm7N0SoTHZvYzJX6GVDmVfl/K8qVJkhfysG4I+9iIyhwvt X-Gm-Gg: Acq92OGD1pAuM4esZlPKfIvd92W1lrt4ugBL5IizP8kG2adSSO+5UV04nPFxCiiYcZi TofGV4ezT9Tah1q55hu/pDfatM9S7JpSGWn03q+YNHl44eM40aDVLph4dhzmgBQ4nb7C+QopygB VB3NAs3uuA/5qthAsiHjfJ4KTvnILvnyW7I4raKgpuRno1KgrhGICLcpu9dJ2olDPKZJHGDAh6G L2vh5sCMZzmdFDf0zG6OLeoXrG3YcPtT2/RF/Q7GqnF6ZKTeFJglQWb0iZIAejnGyccjmPjQX6C Ymz+yAIzekg+8DR7S2SgcvPP8DUvrA23o6fS/0gb6jpI482k5OJCyNoAklbljY6CK6/64ti3AwX fpV5AwWeJvn3Lc2xPbqzoUHJxhTCKhzvQ8BYE4pVCciV43kGhPpOytt73fSDOQXk83p0kJcJBwJ lvrR1399xGhWXsuyiw/YKY51IUsUBQqrZVRhkr9pmeI2JaQ34BFJDeawUUm2gF X-Received: by 2002:a17:902:ecc4:b0:2b0:608d:d8a8 with SMTP id d9443c01a7336-2c2f0731886mr19433555ad.1.1781161783951; Thu, 11 Jun 2026 00:09:43 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:661d:3046::4cf:39]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c2d9bb2199sm18818975ad.77.2026.06.11.00.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 00:09:43 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Florian Fainelli , Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kurt Kanzenbach , Jiri Pirko , Simon Horman , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 4/5] net: dsa: mv88e6xxx: Avoid devlink resource IDs collision with PARENT_TOP Date: Thu, 11 Jun 2026 15:08:50 +0800 Message-ID: <20260611070856.889700-5-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260611070856.889700-1-mmyangfl@gmail.com> References: <20260611070856.889700-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The devlink resource ID for ATU collides with the sentinel DEVLINK_RESOURCE_ID_PARENT_TOP (0). As a result, ATU_bin_* are registered as in fact registered as top-level siblings, not as children of ATU. Whether intentional or unintentional, clarify it by keeping the real resource IDs starting at 1. Unfortunately ATU_bin_* are already registered at top-level, so keep their parent to PARENT_TOP. Signed-off-by: David Yang --- drivers/net/dsa/mv88e6xxx/devlink.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/devlink.c b/drivers/net/dsa/mv88e6xxx/devlink.c index 0f84bffc8ef1..6f034841883c 100644 --- a/drivers/net/dsa/mv88e6xxx/devlink.c +++ b/drivers/net/dsa/mv88e6xxx/devlink.c @@ -91,6 +91,7 @@ void mv88e6xxx_teardown_devlink_params(struct dsa_switch *ds) } enum mv88e6xxx_devlink_resource_id { + MV88E6XXX_RESOURCE_ID_NONE, /* DEVLINK_RESOURCE_ID_PARENT_TOP */ MV88E6XXX_RESOURCE_ID_ATU, MV88E6XXX_RESOURCE_ID_ATU_BIN_0, MV88E6XXX_RESOURCE_ID_ATU_BIN_1, @@ -200,7 +201,7 @@ int mv88e6xxx_setup_devlink_resources(struct dsa_switch *ds) err = dsa_devlink_resource_register(ds, "ATU_bin_0", mv88e6xxx_num_macs(chip) / 4, MV88E6XXX_RESOURCE_ID_ATU_BIN_0, - MV88E6XXX_RESOURCE_ID_ATU, + DEVLINK_RESOURCE_ID_PARENT_TOP, &size_params); if (err) goto out; @@ -208,7 +209,7 @@ int mv88e6xxx_setup_devlink_resources(struct dsa_switch *ds) err = dsa_devlink_resource_register(ds, "ATU_bin_1", mv88e6xxx_num_macs(chip) / 4, MV88E6XXX_RESOURCE_ID_ATU_BIN_1, - MV88E6XXX_RESOURCE_ID_ATU, + DEVLINK_RESOURCE_ID_PARENT_TOP, &size_params); if (err) goto out; @@ -216,7 +217,7 @@ int mv88e6xxx_setup_devlink_resources(struct dsa_switch *ds) err = dsa_devlink_resource_register(ds, "ATU_bin_2", mv88e6xxx_num_macs(chip) / 4, MV88E6XXX_RESOURCE_ID_ATU_BIN_2, - MV88E6XXX_RESOURCE_ID_ATU, + DEVLINK_RESOURCE_ID_PARENT_TOP, &size_params); if (err) goto out; @@ -224,7 +225,7 @@ int mv88e6xxx_setup_devlink_resources(struct dsa_switch *ds) err = dsa_devlink_resource_register(ds, "ATU_bin_3", mv88e6xxx_num_macs(chip) / 4, MV88E6XXX_RESOURCE_ID_ATU_BIN_3, - MV88E6XXX_RESOURCE_ID_ATU, + DEVLINK_RESOURCE_ID_PARENT_TOP, &size_params); if (err) goto out; -- 2.53.0