From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E716481244; Thu, 11 Jun 2026 20:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781210057; cv=none; b=j76M3S5l9sJX9lZ7QuSXwdWesPfA792VNReHEodEtIsoDr5ufFbCrISYSmGsw7PFA7CQO7mv3okYogmDnb8D/IpH+V1U1OQ6Jd/rgeKkPMl0L8XVTk6vC4380lpNLtWsHZF7ytxVMZwtzI/pQZUA10RZSLjmH2k3yNSZHmYEI2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781210057; c=relaxed/simple; bh=FU48NCNE9sYQz18bFtiD3LWJevD8xsYZ/bTNmProL/A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GLt55ZTX16qLNATMt9DRqxsFQmGF8egKlrgmVVZXxMF18emYVnzhv7xxWkMbphwKXf8WWH0OJ4sCNbK/3vQoatyahn3BKHpNsl7iqbYjpf66KHELC3BSpt/bW8JVazhM4UxLsSou+tceo0dngYZemfOy7kn7JKcX4hhU7vFg+vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pc3ZJeox; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pc3ZJeox" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A19381F000E9; Thu, 11 Jun 2026 20:34:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781210051; bh=nH/aLoa3AEqO6ONv7VWO2PSeTYf+vJbVrVpAdygpMxU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Pc3ZJeoxH3OmzlOHcFJbmzraUUUqa2I+240mrHUlr1rFjAX1DQbZQ4NN46UEaMDBw qZFS/CbYCFGB00X+tzCRSLaHiZEJGmA/2wfCn6WNkZl90QbbW8RFF8m/qru05dry6g QLvzvQUVBDFoEv2A2BWG2tfurazDhCqcJZkkdtuO67hR9+++J10VDmJWXjoTMg524+ YkVu6iMVnNIInJ0eIz/1SCnDGDA5qcy8NTSHPA/vxv/1+Nzm4ldSFuBUJsLSeTEvFH 9+YFU9wBeUFdK1Xj/EwFPfeJAgOTBJoApGzilNMtaqik4tm0YxLYkpqm8fSVWxRn7l RnTi2tWWoZezQ== Date: Thu, 11 Jun 2026 13:34:10 -0700 From: Jakub Kicinski To: Florian Westphal Cc: , Subject: Re: [PATCH net-next 2/2] selftests: netfilter: add phony nft_offload test Message-ID: <20260611133410.1c0396b1@kernel.org> In-Reply-To: <20260610175906.1767-3-fw@strlen.de> References: <20260610175906.1767-1-fw@strlen.de> <20260610175906.1767-3-fw@strlen.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Jun 2026 19:58:44 +0200 Florian Westphal wrote: > ... "phony", because its not testing offloads, it tests the control > plane code. Also test error unwind via fault injection framework. > > For a proper test, real hardware would be required given we'd have > check if 'previously handed off to hardware' offload commands are > properly removed again on failure or rule flush. > > Signed-off-by: Florian Westphal Validation errors in tools/testing/selftests/net/netfilter/config: Lines 36-37 invalid order, CONFIG_FAIL_FUNCTION=y should be before CONFIG_IP_VS_RR=m Shellcheck also has some comments FWIW