From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3968333A711 for ; Thu, 11 Jun 2026 16:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781195834; cv=none; b=pSkA1QMrRHqU0Ddba65Jako9PlvETNzcxEL62t6ygZ9KvSyTeaHDzc9kLJF/0DI7+bCQ0M5yRP9r6A2uccoy3zyqLOpZRYEEAxMwSFWRATA7FnnkP5yoxbzJ0yknkJ/aSh7rmToKZw5ZiXPPR/+ZfUiJRptIE51GPe03Nd9pufI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781195834; c=relaxed/simple; bh=THGFb424cSjMWDbvWIsERMcMVPYcS2mn3dgc/28swA0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S75ns4ulbNggyJ4u7U2MMcvPMJpU4HTWxwvBZrdZEo7UpfSdaOZCUQCrHu7qxEetDG/c6aj3CJIlmNxYF+9BZgKUbWc58QOjpD+Ojss+ASZl9Y5H7ngNGS1Y8s+bCZ/mp+j1tuzksaa2CJKCLgiWSi8Md/y8UGbV6H5ClFz8NAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Unykz7IH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Unykz7IH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 506311F00899; Thu, 11 Jun 2026 16:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781195832; bh=ZSqDXVAqq24W1HC/0+seIWlfKFSSqkK6xzTjV0nilPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Unykz7IHRlFiIyIQUMwgVXXNBrDresGjbKMH6FCnpRj4g+5vGqsdUt5cQ1AcS2AIn paE6IWek5jmwkllnm0thrm3x42CMqBjOTHcsneah+ZGFn9UM8R9SL29dOpuLHjFkdz HN2KG1LhXHIMrpdFkD/oCtxA5RDnUYmPhvNLJ8DzWVz4cSJV79/oBYeGGiHvk7ZB3K RMWPjTa70eBpUtrP1J9t0gzU6vINvueKksODRKfaqUdDPHX9PO2H52G6uIx2bsFMzG ZanAgXsO3B3aTWEzlJ5KgIBAKoU+uAOv/C8EsdcP11Rrnr8kpXxgp0MEJcdh3hxRVR XbQ6OuouRQmHw== Date: Thu, 11 Jun 2026 17:37:09 +0100 From: Simon Horman To: Ren Wei Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, 3chas3@gmail.com, yuantan098@gmail.com, bird@lzu.edu.cn, zcliangcn@gmail.com Subject: Re: [PATCH net 1/1] net: atm: reject out-of-range traffic classes in QoS validation Message-ID: <20260611163709.GW3920875@horms.kernel.org> References: <58f02c6f73d9818fd5d2022e1116759fdde6116b.1780965530.git.zcliangcn@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58f02c6f73d9818fd5d2022e1116759fdde6116b.1780965530.git.zcliangcn@gmail.com> On Tue, Jun 09, 2026 at 04:34:37PM +0800, Ren Wei wrote: > From: Zhengchuan Liang > > Reject ATM traffic classes above ATM_ANYCLASS in check_tp(). > SO_ATMQOS stores the supplied QoS after check_qos() succeeds, so > accepting larger values leaves invalid traffic_class values in > vcc->qos. > > That bad state later reaches pvc_info(), which indexes class_name[] > with vcc->qos.{rx,tp}.traffic_class. Values above ATM_ANYCLASS cause > an out-of-bounds read when /proc/net/atm/pvc is read. > > Tighten the existing QoS validation so invalid traffic_class values > are rejected at the point where user supplied QoS is accepted. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Reported-by: Yuan Tan > Reported-by: Xin Liu > Assisted-by: Codex:GPT-5.4 > Signed-off-by: Zhengchuan Liang > Signed-off-by: Ren Wei Reviewed-by: Simon Horman I believe the issue flagged by AI-generated review on https://netdev-ai.bots.linux.dev/sashiko/ is a false positive.