From: Jason Gunthorpe <jgg@ziepe.ca>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: leon@kernel.org, brett.creeley@amd.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, allen.hubbe@amd.com, nikhil.agarwal@amd.com,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [for-next v2 2/2] RDMA/ionic: Add RCQ userspace support
Date: Thu, 11 Jun 2026 15:34:49 -0300 [thread overview]
Message-ID: <20260611183449.GG1066031@ziepe.ca> (raw)
In-Reply-To: <20260611092544.783731-3-abhijit.gangurde@amd.com>
On Thu, Jun 11, 2026 at 02:55:43PM +0530, Abhijit Gangurde wrote:
> @@ -2154,7 +2157,7 @@ int ionic_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *attr,
> int rc;
>
> if (udata) {
> - rc = ib_copy_validate_udata_in(udata, req, rsvd);
> + rc = ib_copy_validate_udata_in(udata, req, ionic_flags);
^^^^^^^^^
> struct ionic_qdesc {
> @@ -84,6 +85,7 @@ struct ionic_qp_req {
> __u8 rq_cmb;
> __u8 udma_mask;
> __u8 rsvd[3];
> + __u32 ionic_flags;
> };
That is not the right way to use these APIs, this will fail old
rdma-cores that used the smaller struct.
Please check everything you did here.
Please support IB_UVERBS_CORE_SUPPORT_ROBUST_UDATA before changing
anything, and your userspace needs to check it before using extended
functions.
Jason
prev parent reply other threads:[~2026-06-11 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 9:25 [for-next v2 0/2] Add Reorder Completion Queue (RCQ) support Abhijit Gangurde
2026-06-11 9:25 ` [for-next v2 1/2] net: ionic: Fetch RCQ sign bit from firmware Abhijit Gangurde
2026-06-11 9:25 ` [for-next v2 2/2] RDMA/ionic: Add RCQ userspace support Abhijit Gangurde
2026-06-11 18:34 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260611183449.GG1066031@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=abhijit.gangurde@amd.com \
--cc=allen.hubbe@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox