From: Rongguang Wei <clementwei90@163.com>
To: przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Rongguang Wei <weirongguang@kylinos.cn>
Subject: [PATCH net-next v1] e1000: Initialize phy_data to avoid unexpected values
Date: Fri, 12 Jun 2026 16:03:31 +0800 [thread overview]
Message-ID: <20260612080331.120096-1-clementwei90@163.com> (raw)
From: Rongguang Wei <weirongguang@kylinos.cn>
The phy_data variable is not initialized. If e1000_read_phy_reg
returns an error, phy_data will not point to a valid value from
the PHY register, which may cause the regs_buff array to be populated
with unexpected values.
Signed-off-by: Rongguang Wei <weirongguang@kylinos.cn>
Change-Id: I46071b3b21a566f8da650168d38d6968251b077d
---
drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
index 4dcbeabb3ad2..f068108c5004 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
@@ -327,7 +327,7 @@ static void e1000_get_regs(struct net_device *netdev, struct ethtool_regs *regs,
struct e1000_adapter *adapter = netdev_priv(netdev);
struct e1000_hw *hw = &adapter->hw;
u32 *regs_buff = p;
- u16 phy_data;
+ u16 phy_data = 0;
memset(p, 0, E1000_REGS_LEN * sizeof(u32));
--
2.25.1
next reply other threads:[~2026-06-12 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 8:03 Rongguang Wei [this message]
2026-06-12 8:58 ` [PATCH net-next v1] e1000: Initialize phy_data to avoid unexpected values Jagielski, Jedrzej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612080331.120096-1-clementwei90@163.com \
--to=clementwei90@163.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=weirongguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox