From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AD03CC313; Sun, 14 Jun 2026 17:01:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456466; cv=none; b=i7ubNhe4rfh75y6GiNL++ZND6bfDztqVe36022Jj0G/26rmj3NzIGpDCLqFNMpqECy67kU+cjdvZRZw465U1Bquq7QvibOdizb8qKmvIKG2vtGnPKFyKqIg0aCqjT/HTW71j5dWLP1FNl7kzPO3E4Gbl67SSCYNf24pQ4O6bfxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781456466; c=relaxed/simple; bh=qf9LbvoxHnqkVZ9YxGMb9eGRyo7XNehqXqg8vfa09E4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tFttS1OPR+CupYyWSxEvdJtXnqCsiN4Fvptb5Dzp4nYRZAksvKRR7f/8QVUTwctBntCsu6R7NW4POY7/1CheUXvQDr/agmUNqZW5yI8UQ1dCnB/eE+UY4UScA7AnmQBALKSlDBmcq4ZVvLPnB7eedf5HzlSzJ8kFgaLC2g8RKDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u9YGwTfB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u9YGwTfB" Received: by smtp.kernel.org (Postfix) with ESMTPS id C29DAC2BCC7; Sun, 14 Jun 2026 17:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1781456465; bh=qf9LbvoxHnqkVZ9YxGMb9eGRyo7XNehqXqg8vfa09E4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=u9YGwTfBhAzsLqDmblCOb0vwgTi+PMnEYYJOhbYyuwaWMx+R0c+WcMRokd+EFKn1H U8qrLVC5zOrMCIbXOwACj9H2DwsDV1/nF2rig0xbzeK9dGDopvNpVNiCyXDTCNpvjo x3TLV8mQasHBgIUFuH0SqFVn9N+YBV5I8Nv/7mHXmxjXWaFsn/A5Yfv95jrQRQ741g wdlTvY7YhH+aSJyA5vS3pDI78EN0mIL1+k6aPVu25DEpdVGBh1Ig6RdVI24c+jw0ep fw18Ng0ShewkHQzbXvfaoh3VtrO+H4DQoS3qgO/A+9mavvCYjxB07Ty5VeBTnKDz5w 3hS4GfQL2tBBw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CFACD98C5; Sun, 14 Jun 2026 17:01:05 +0000 (UTC) From: Selvamani Rajagopal via B4 Relay Date: Sun, 14 Jun 2026 10:00:26 -0700 Subject: [PATCH net-next v5 10/15] net: phy: ncn26000: Enable enhanced noise immunity Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260614-s2500-mac-phy-support-v5-10-89874b72f725@onsemi.com> References: <20260614-s2500-mac-phy-support-v5-0-89874b72f725@onsemi.com> In-Reply-To: <20260614-s2500-mac-phy-support-v5-0-89874b72f725@onsemi.com> To: Andrew Lunn , Piergiorgio Beruto , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Parthiban Veerasooran , Selva Rajagopal , Richard Cochran , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Jerry Ray , Selvamani Rajagopal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781456463; l=2554; i=Selvamani.Rajagopal@onsemi.com; s=20260531; h=from:subject:message-id; bh=usMYgNJJhEZGYeEqVGV1sRYJj6gxRACZSQcd65bk+go=; b=07iBRZ2kGdlvPsZr2tHHe6BXaqnScjx3Qg5auKTHCi1gzpxxO4jPyALVTri6oSVLMkLNhyxVW zvbPm8HqbTQBuhSbuzeotx3sUv73WkFlka5f6TDC5Fd4o4XT1EMJOwF X-Developer-Key: i=Selvamani.Rajagopal@onsemi.com; a=ed25519; pk=5QRdM0HS/LGWWcUZZ9hVfZ+qbPQGZCumcTXOiN7Fyug= X-Endpoint-Received: by B4 Relay for Selvamani.Rajagopal@onsemi.com/20260531 with auth_id=803 X-Original-From: Selvamani Rajagopal Reply-To: Selvamani.Rajagopal@onsemi.com From: Selvamani Rajagopal By setting ENI bit, noise immunity is improved and it is specifically meant for PLCA enabled nodes. Reviewed-by: Andrew Lunn Signed-off-by: Selvamani Rajagopal --- changes in v5 - No changes changes in v4 - No changes changes in v3 - Moved as a separate patch --- drivers/net/phy/ncn26000.c | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/ncn26000.c b/drivers/net/phy/ncn26000.c index 2c8601c3f94a..c3a34b2c524d 100644 --- a/drivers/net/phy/ncn26000.c +++ b/drivers/net/phy/ncn26000.c @@ -36,6 +36,10 @@ #define TO_TMR_DEFAULT 32 +#define NCN26000_REG_PHYCFG1 0x8001 +#define NCN26000_PHYCFG1_ENI BIT(7) +#define NCN26000_PHYCFG1_ENI_MASK BIT(7) + static int ncn26000_config_init(struct phy_device *phydev) { int ret = 0; @@ -106,6 +110,24 @@ static int ncn26000_read_status(struct phy_device *phydev) return 0; } +/* Intercept PLCA enable/disable request to + * set the proprietary, ENI mode accordingly + */ +static int ncn26000_c45_plca_set_cfg(struct phy_device *phydev, + const struct phy_plca_cfg *plca_cfg) +{ + int ret = genphy_c45_plca_set_cfg(phydev, plca_cfg); + u16 eni_cfg = 0; + + if (ret || plca_cfg->enabled < 0) + return ret; + + eni_cfg = (plca_cfg->enabled) ? NCN26000_PHYCFG1_ENI : 0; + return phy_modify_mmd(phydev, MDIO_MMD_VEND2, + NCN26000_REG_PHYCFG1, + NCN26000_PHYCFG1_ENI_MASK, eni_cfg); +} + static irqreturn_t ncn26000_handle_interrupt(struct phy_device *phydev) { int ret; @@ -156,7 +178,7 @@ static struct phy_driver ncn26000_driver[] = { .config_aneg = ncn26000_config_aneg, .read_status = ncn26000_read_status, .handle_interrupt = ncn26000_handle_interrupt, - .set_plca_cfg = genphy_c45_plca_set_cfg, + .set_plca_cfg = ncn26000_c45_plca_set_cfg, .get_plca_cfg = genphy_c45_plca_get_cfg, .get_plca_status = genphy_c45_plca_get_status, .soft_reset = genphy_soft_reset, @@ -177,7 +199,7 @@ static struct phy_driver ncn26000_driver[] = { .read_status = ncn26000_read_status, .handle_interrupt = ncn26000_handle_interrupt, .get_plca_cfg = genphy_c45_plca_get_cfg, - .set_plca_cfg = genphy_c45_plca_set_cfg, + .set_plca_cfg = ncn26000_c45_plca_set_cfg, .get_plca_status = genphy_c45_plca_get_status, .soft_reset = genphy_soft_reset, }, -- 2.43.0