From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: <andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<sgoutham@marvell.com>, "Ratheesh Kannoth" <rkannoth@marvell.com>
Subject: [PATCH net-next] octeontx2-pf: add page pool ethtool statistics
Date: Mon, 15 Jun 2026 08:51:41 +0530 [thread overview]
Message-ID: <20260615032141.521667-1-rkannoth@marvell.com> (raw)
Expose page pool allocator statistics through ethtool.
When the interface is up, aggregate stats from each
receive queue page pool and append the common page_pool ethtool stat
block to the driver's private statistics set.
Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
---
.../marvell/octeontx2/nic/otx2_ethtool.c | 35 +++++++++++++++++--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
index a0340f3422bf..0a082f8d9714 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
@@ -133,6 +133,8 @@ static void otx2_get_strings(struct net_device *netdev, u32 sset, u8 *data)
ethtool_puts(&data, "reset_count");
ethtool_puts(&data, "Fec Corrected Errors: ");
ethtool_puts(&data, "Fec Uncorrected Errors: ");
+
+ page_pool_ethtool_stats_get_strings(data);
}
static void otx2_get_qset_stats(struct otx2_nic *pfvf,
@@ -182,6 +184,28 @@ static int otx2_get_phy_fec_stats(struct otx2_nic *pfvf)
return rc;
}
+static void otx2_page_pool_stats(struct otx2_nic *vf, u64 *data)
+{
+#ifdef CONFIG_PAGE_POOL_STATS
+ bool up = !!(vf->netdev->flags & IFF_UP);
+ struct page_pool_stats stats = {};
+ struct otx2_hw *hw = &vf->hw;
+ struct otx2_pool *pool;
+ int pool_id;
+
+ if (up) {
+ for (pool_id = 0; pool_id < hw->rqpool_cnt; pool_id++) {
+ pool = &vf->qset.pool[pool_id];
+ if (!pool->page_pool)
+ continue;
+ page_pool_get_stats(pool->page_pool, &stats);
+ }
+ }
+
+ page_pool_ethtool_stats_get(data, &stats);
+#endif
+}
+
/* Get device and per queue statistics */
static void otx2_get_ethtool_stats(struct net_device *netdev,
struct ethtool_stats *stats, u64 *data)
@@ -237,6 +261,8 @@ static void otx2_get_ethtool_stats(struct net_device *netdev,
*(data++) = fec_corr_blks;
*(data++) = fec_uncorr_blks;
+
+ otx2_page_pool_stats(pfvf, data);
}
static int otx2_get_sset_count(struct net_device *netdev, int sset)
@@ -254,7 +280,8 @@ static int otx2_get_sset_count(struct net_device *netdev, int sset)
otx2_update_lmac_fec_stats(pfvf);
return otx2_n_dev_stats + otx2_n_drv_stats + qstats_count +
- mac_stats + OTX2_FEC_STATS_CNT + 1;
+ mac_stats + OTX2_FEC_STATS_CNT + 1 +
+ page_pool_ethtool_stats_get_count();
}
/* Get no of queues device supports and current queue count */
@@ -1402,6 +1429,7 @@ static void otx2vf_get_strings(struct net_device *netdev, u32 sset, u8 *data)
otx2_get_qset_strings(vf, &data, 0);
ethtool_puts(&data, "reset_count");
+ page_pool_ethtool_stats_get_strings(data);
}
static void otx2vf_get_ethtool_stats(struct net_device *netdev,
@@ -1421,6 +1449,8 @@ static void otx2vf_get_ethtool_stats(struct net_device *netdev,
otx2_get_qset_stats(vf, stats, &data);
*(data++) = vf->reset_count;
+
+ otx2_page_pool_stats(vf, data);
}
static int otx2vf_get_sset_count(struct net_device *netdev, int sset)
@@ -1434,7 +1464,8 @@ static int otx2vf_get_sset_count(struct net_device *netdev, int sset)
qstats_count = otx2_n_queue_stats *
(vf->hw.rx_queues + otx2_get_total_tx_queues(vf));
- return otx2_n_dev_stats + otx2_n_drv_stats + qstats_count + 1;
+ return otx2_n_dev_stats + otx2_n_drv_stats + qstats_count + 1 +
+ page_pool_ethtool_stats_get_count();
}
static int otx2vf_get_link_ksettings(struct net_device *netdev,
--
2.43.0
next reply other threads:[~2026-06-15 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 3:21 Ratheesh Kannoth [this message]
2026-06-15 20:32 ` [PATCH net-next] octeontx2-pf: add page pool ethtool statistics Joe Damato
2026-06-15 21:50 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615032141.521667-1-rkannoth@marvell.com \
--to=rkannoth@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox