Re: [PATCH net-next 0/9] atm: remove more dead code

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 15 Jun 2026 17:33:19 +0100 Simon Horman wrote:
> On Sat, Jun 13, 2026 at 01:10:23PM -0700, Jakub Kicinski wrote:
> > Commit 6deb53595092 ("net: remove unused ATM protocols and legacy
> > ATM device drivers") removed a good chunk of old ATM drivers.
> > Our goal going forward is to limit the ATM support to PPPoATM
> > used in ADSL deployments.
> > 
> > A recent burst of AI generated fixes for net/atm/signaling.c and
> > net/atm/svc.c made me look closer at the remaining code. PPPoATM runs
> > over permanent virtual circuits (PF_ATMPVC) with a statically
> > configured VPI/VCI. We can drop switched virtual circuits (SVCs)
> > and user-space signaling (atmsigd) support. While digging around
> > I noticed a few more obviously dead pieces of code.
> > 
> > Annoyingly, I have applied one "fix" to QoS config which will
> > now make net conflict with this series :/
> > 
> > Jakub Kicinski (9):
> >   atm: remove AAL3/4 transport support
> >   atm: remove the unused send_oam / push_oam callbacks
> >   atm: remove dead SONET PHY ioctls
> >   atm: remove the local ATM (NSAP) address registry
> >   atm: remove SVC socket support and the signaling daemon interface
> >   atm: remove the unused change_qos device operation
> >   atm: remove the unused pre_send and send_bh device operations
> >   atm: remove unused ATM PHY operations
> >   atm: remove orphaned uAPI for deleted drivers, protocols and SVCs  
> 
> There is a compile time nit on patch 4/9.
> 
>   ../net/atm/resources.c: In function ‘atm_dev_ioctl’:
>   ../net/atm/resources.c:227:20: warning: variable ‘len’ set but not used [-Wunused-but-set-variable=]
>     227 |         int error, len, size = 0;
>         |                    ^~~
> 
> It might be nice to clear that one.
> But overall this looks good to me.
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Ugh, I thought clang is strictly better at finding these and
build-tested only with clang. Posting v2 shortly...