From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A897B3EB10D for ; Mon, 15 Jun 2026 12:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526647; cv=none; b=JtqpquDqesMcu4MgHEZSYOPELTqSxuPfhFMu7pk+qctHUJWjOOYjuuh1B0IInQeR+Nj8ldGqyDMxtbtQv6aZpAJVkc/iIvitalwWb0ZBVorjiuCvTrKy9Pjr5a8tgt9DoLiu8o9QcrMB9u7SKv3tDx7yBYy/LkdjSGuIHBrrUl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526647; c=relaxed/simple; bh=LiGJAO0/VUutQ0zWhOKOU6ESlza0YssOsxbuxpLi/68=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fMVZ7i+JrI2SRajw32405dsH3b+k0SdLpjYmmNNxvW6KFOXXPqbba4G/KPEPnC6lgYs+paWPLd5rtZzEVYvtN2opioWUMxXSb18rda/uVCyQu7yY9gIgS+B7Q0a4+IFx2E28ICEe0MSWH3FT4pJYrgloD33Sdm40eNRlW0HoiTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JUj7679Q; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JUj7679Q" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-490aaeabdb4so21712055e9.1 for ; Mon, 15 Jun 2026 05:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781526639; x=1782131439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LeREqKwyBL2tZifBDIM4b8FY1VqpNjyArTkAWxSLkSU=; b=JUj7679QAhKQy9liM0ZUDJxZDiorzbE3AQnB7jRP+WS/UfXqFu8LWqH7HapAU0W0Ql hfq2MeIAatms7DTfxiU0v0LANMzaV4Eu3aSmIE6z9jVQEIxK1aZZ3lK0KDGZj9qKylEy BxPFVGJ99MfPvSSo+vGllmY1HxcgzUJv5N1gDp9t/COvoUzOBkABLsqdl4H7PcM9GwDa cojVNi4bqYWRExTyHzH0N4ku36m0MSPoDqq4W7BzwrplMFUH03Glm7aROHDNtBlvUj++ dP6y7Xx+jOY9qRumEVi6cjNYIP2w5fyJM93bL3FMPX1GD4IgWpnsUSiTmntjLI2n/VhR XCog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781526639; x=1782131439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LeREqKwyBL2tZifBDIM4b8FY1VqpNjyArTkAWxSLkSU=; b=lH3PrZVYz/1wzcpjB1WIeF+MkxN0y8frzY3xg2qjVMY1J2uoX8yQmp8ImcY02J4gC5 nbYYFNZoFkam8CvnCHF8J1XMKPA5Fm4kv+zLND11D+kh5wjnbfo0u62MDSLhfOnDOGAC sY/QLsEL6yp6UBaJlRgUpWpqSBlGbzrM++AkEwGkT33hveylOlsBKF91NPiHVeF+R9EB 9HHYBEqkLKQfQYo57L6ijYZlUb7/W1Qiwb9sExnQ8q3r8eIE2zP1osiIfVG5VOAM7Kir jYjcuxoDB6hpWhQFP+GQ1SYTrQ3nwzlC9aZv4/o2a4MlJnAWngKlO0bAVK7vAUdi+ZdM TkIA== X-Forwarded-Encrypted: i=1; AFNElJ+Ml5Ccj2yetMrtmpcQVL48vNHqs5oXZqCKDil7qeZPsTebwh2iCcRo44dgrTyjZJLPqIobegY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmm3UwL2ZYi/u1FTQLps9OaNJfS33tlUvA9/si5m5+zOhYMXSO vwQNAIMthB/XpcWE0DdnrMmLUGjrHIpz1Wd+qHkc6Q84fw/xTyLZglpS X-Gm-Gg: Acq92OE6kTfU1ptSlCL0USu03s/xJaDKMeq9ovqWXsHNrO7s63cc108ku7d/yK5N+0J Xu7aQEKCWOpRadYTgVaRKcrccOaMNBfYBO6Zck//12icMaTbmV0aFq6xe6TQyg4VH0F3uc0GD3o 9CM4484cgWe0WsAmVGT+H+nT57rCvQ+Gfg1eTbSxCLvBt7eN16f8zno8TuhYJ0jE87iFI7Ruyra KdDJPBntBRUH0rMX990AtOjvMiCAoP0EMUzXwqLk1uOBBukj/loj7Mu2Sb8yV5HlbLhSS2UOQcg vwUjV5t18Jx6+YA6hSPQNOy8iPHEhG7zgh5apCiNOpN6yc8ffHwLSYmy4dBhGI+ge8MUb3yMgs9 Bwvwv3Fq5RVWtrOh9gFYjUSTZb2PdO75FcPLLzTAIfKlgzMlrgZ9R9wj8gm4+GpYKjA92wff3aI p4yc2Aa1fFfF6w5QOciexjf2EPVRYELL1VZM6m7PRDYSnr2T6MtrtkFPWydOroNaW8QA== X-Received: by 2002:a05:600c:3512:b0:491:9969:739d with SMTP id 5b1f17b1804b1-4922011393fmr139236575e9.29.1781526638312; Mon, 15 Jun 2026 05:30:38 -0700 (PDT) Received: from Ansuel-XPS24 (93-34-88-103.ip49.fastwebnet.it. [93.34.88.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-490ea95c512sm191426435e9.2.2026.06.15.05.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 05:30:36 -0700 (PDT) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Saravana Kannan , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v7 03/12] net: phylink: add phylink_release_pcs() to externally release a PCS Date: Mon, 15 Jun 2026 14:29:39 +0200 Message-ID: <20260615122950.22281-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260615122950.22281-1-ansuelsmth@gmail.com> References: <20260615122950.22281-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add phylink_release_pcs() to externally release a PCS from a phylink instance. This can be used to handle case when a single PCS needs to be removed and the phylink instance needs to be refreshed. On calling phylink_release_pcs(), the PCS will be removed from the phylink internal PCS list and the phylink supported_interfaces value is reparsed with the remaining PCS interfaces. Also a phylink resolve is triggered to handle the PCS removal. The flag force_major_config is set to make phylink resolve reconfigure the interface (even if it didn't change). This is needed to handle the special case when the current PCS used by phylink is removed and a major_config is needed to propagae the configuration change. With this option enabled we also force mac_config even if the PHY link is not up for the in-band case. Signed-off-by: Christian Marangi --- drivers/net/phy/phylink.c | 53 +++++++++++++++++++++++++++++++++++++++ include/linux/phylink.h | 2 ++ 2 files changed, 55 insertions(+) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index cb07184ce82f..ca4dad4b140a 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -158,6 +158,7 @@ static const phy_interface_t phylink_sfp_interface_preference[] = { static DECLARE_PHY_INTERFACE_MASK(phylink_sfp_interfaces); static void phylink_run_resolve(struct phylink *pl); +static void phylink_pcs_disable(struct phylink_pcs *pcs); /** * phylink_set_port_modes() - set the port type modes in the ethtool mask @@ -918,6 +919,58 @@ static void phylink_resolve_an_pause(struct phylink_link_state *state) } } +/** + * phylink_release_pcs - Removes a PCS from the phylink PCS available list + * @pcs: a pointer to the phylink_pcs struct to be released + * + * This function release a PCS from the phylink PCS available list if + * actually in use. It also refreshes the supported interfaces of the + * phylink instance by copying the supported interfaces from the phylink + * conf and merging the supported interfaces of the remaining available PCS + * in the list and trigger a resolve. + */ +void phylink_release_pcs(struct phylink_pcs *pcs) +{ + struct phylink *pl; + + ASSERT_RTNL(); + + pl = pcs->phylink; + if (!pl) + return; + + list_del(&pcs->list); + pcs->phylink = NULL; + + mutex_lock(&pl->state_mutex); + + /* Check if we are removing the PCS currently + * in use by phylink. If this is the case, + * force phylink resolve to reconfigure the interface + * mode, disable the current PCS and set the + * phylink PCS to NULL. + */ + if (pl->pcs == pcs) { + phylink_pcs_disable(pl->pcs); + + pl->force_major_config = true; + pl->pcs = NULL; + } + + mutex_unlock(&pl->state_mutex); + + /* Refresh supported interfaces */ + phy_interface_copy(pl->supported_interfaces, + pl->config->supported_interfaces); + list_for_each_entry(pcs, &pl->pcs_list, list) + phy_interface_or(pl->supported_interfaces, + pl->supported_interfaces, + pcs->supported_interfaces); + + phylink_run_resolve(pl); +} +EXPORT_SYMBOL_GPL(phylink_release_pcs); + static unsigned int phylink_pcs_inband_caps(struct phylink_pcs *pcs, phy_interface_t interface) { diff --git a/include/linux/phylink.h b/include/linux/phylink.h index ca9dfc142388..15e6b1a39dfe 100644 --- a/include/linux/phylink.h +++ b/include/linux/phylink.h @@ -751,6 +751,8 @@ void phylink_disconnect_phy(struct phylink *); int phylink_set_fixed_link(struct phylink *, const struct phylink_link_state *); +void phylink_release_pcs(struct phylink_pcs *pcs); + void phylink_mac_change(struct phylink *, bool up); void phylink_pcs_change(struct phylink_pcs *, bool up); -- 2.53.0