From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC02D3F1AAB for ; Mon, 15 Jun 2026 12:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526653; cv=none; b=OE18WVPqAaGy7maMcbYfPPuID5oAG0pbDvFKGGwJS3zZ7v5iV5gOqjXMJbYqWAdZ6EvsvmX4q3wp+y1SC0gOyiRNwIdGNsg4RVcVG1V3Dt2s3dbkw4uYH3z45dTrLQDlt+iKD6O3Y6D2q0eh7KVGW/Edt73xFln407zvBInKTIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781526653; c=relaxed/simple; bh=t3ALl6kM5PB5VIrlij+xKf1pj94KMP+Yikc9qj/8DD0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kGb5uZkCssrtoPGbPtOkLfLq8Y9dQ1cg8xXJhsMwYPhVj/PyWqhXuQ44WKACqPBtAZn7i0p+rC+kvcyxB5kRZinASR3LX5l+GpJh+GBmI6SUeNO7HyGieNObXfEfEQY4zJ2I/zm8ByvC7R448ZgPAF8hnnTfjg5ivLedBb+iOOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TzMdHudl; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TzMdHudl" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so21352705e9.0 for ; Mon, 15 Jun 2026 05:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781526643; x=1782131443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3tjTiOW8L5XMvZNg9p3Y/5l4xg/YCEGSjiRSop5LAtE=; b=TzMdHudliKvx4stdYdNJ23R2e2PQ+JGzUS4jfj6MR4zoJRmMqczgNwlQqn1fgbdMdR lR+u76PzXGgaAr4WS58OrDe+CsMKpbcvbKRNKSV4lyEa+b9rP2biWuNg/pITqL3mtoGd 1gSJwb5UV+x2CtvEdj/5SiKG8uTbl+py+kPVew3FFVRGfhazjhOaxYfhLMw27iStR8yF /Evh4VQKR/0RbuPwfjoXeKHWMQjCE1z7ppx6RFqbgqdKf5ESp6C4CiIQIRHx3wDjRAz2 C1E3g6wsX1d74dKIK+ZTakyXXWtabVMnjNVsyVnzEoGmprEqfkcrG385LTYgBrYPg1f1 Cvuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781526643; x=1782131443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3tjTiOW8L5XMvZNg9p3Y/5l4xg/YCEGSjiRSop5LAtE=; b=hNyyX9181Qv/RWtWhq+c+mJ/a2dWxleRyzBbsyJVSstQzVRoribHas0QXjZ8F+AQ8P 6d9IyFjnA/TKvUN6Vg9cQq9IrN9j3B+5jjiZLJPaBXfNRjIMTxBIQLRoo+xdIn5XFVqx uLvECPmhxlpGHr7Zydbu173HtXDNIfzE8Sl5UskqLcmCLPLohpSJSfbbPE5qOJwYcr3e dgx3JgDltqb33a+SaEAKtw8BWt16anRtcdsMn+Mhzcvuz/N028jav4UVKjJhfVj6RInH 9rnUkjMz6EgQZ0J5zD5oGMi3HmSIkeQV/kWC/0b7sKpr8McwLu96TQ/rYji7g1KMjMb1 aAsA== X-Forwarded-Encrypted: i=1; AFNElJ8NGNXQWVPlrmKNovE769UlpLgL1BseO2v4ygH22HgqOUiTmIKf+BUNGLIUn0N5DorlMFXnTh8=@vger.kernel.org X-Gm-Message-State: AOJu0YyQK70vkx/DoWaqQZRavDkDzdzSGBKjiOxraQTM78au7/+qa6u+ arErRv9NjMfdcY8tnvjZsiAMQIz/sGGS3iMQijjh75sasLomkyh7Mrp0 X-Gm-Gg: Acq92OE8Wt1UveXWCZe76PQkv36Tbiv82dP/z3pdpk56mHg8BGNvZAqCqiFSnwsu2g3 QEieKDIIcPWlrUZtz9t4J3qHVbbf2Dy5XL8V4xoOnnUvwDCaLueLFTsEAUs24Kc8wj36PVNuahW 0R6fstm/sF/FBTa02ql4SDPmPuALkgifP3F/0WEhFTtJZMCXsdToAoCfeeJ/9BI31VSBmmzhEq/ LlaKekdy3oHrLR1sz4wJHwPyHFqJ1uA4Nzq1dORhaTfQGmEKXVpOB3tMRFUUUmO6gWqiTe6d3MN rqRG0p078YDPLKgoweowrfUn9uhfeNZbLeL87tTjj/b2MMQ+gThOSlCiI8m2eLXm5lx0vTLDR6T snnJBf4QOAYKGJxi0F1rL1xGsJNIHhhV7WfF+T/GS8uvZlqPJA+QI5UYGS3AgB7MgAbdbVbubyb SXy7drIZ6hmHBQCNnVDuALLf1yy+Dg4Wcu+FmWzLbMSk/HvE8Hn1GSzhY= X-Received: by 2002:a05:600c:628f:b0:492:1e36:85dc with SMTP id 5b1f17b1804b1-4922017b005mr124400735e9.36.1781526642421; Mon, 15 Jun 2026 05:30:42 -0700 (PDT) Received: from Ansuel-XPS24 (93-34-88-103.ip49.fastwebnet.it. [93.34.88.103]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-490ea95c512sm191426435e9.2.2026.06.15.05.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 05:30:41 -0700 (PDT) From: Christian Marangi To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Horman , Jonathan Corbet , Shuah Khan , Christian Marangi , Lorenzo Bianconi , Heiner Kallweit , Russell King , Saravana Kannan , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev Subject: [PATCH net-next v7 05/12] net: phylink: support late PCS provider attach Date: Mon, 15 Jun 2026 14:29:41 +0200 Message-ID: <20260615122950.22281-6-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260615122950.22281-1-ansuelsmth@gmail.com> References: <20260615122950.22281-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for late PCS provider attachment to a phylink instance. This works by creating a global notifier for the PCS provider and making each phylink instance that makes use of fwnode subscribe to this notifier. The PCS notifier will emit the event FWNODE_PCS_PROVIDER_ADD every time a new PCS provider is added. phylink will then react to this event and will call the new function fwnode_phylink_pcs_get_from_fwnode() that will check if the PCS fwnode provided by the event is present in the pcs-handle property of the phylink instance. If a related PCS is found, then such PCS is added to the phylink instance PCS list. Then we link the PCS to the phylink instance and we refresh the supported interfaces of the phylink instance. Finally we check if we are in a major_config_failed scenario and trigger an interface reconfiguration in the next phylink resolve. In the example scenario where the link was previously torn down due to removal of PCS, the link will be established again as the PCS came back and is now available to phylink. Signed-off-by: Christian Marangi --- drivers/net/pcs/pcs.c | 49 ++++++++++++++++++++++++++++++++ drivers/net/phy/phylink.c | 57 +++++++++++++++++++++++++++++++++++++ include/linux/pcs/pcs.h | 60 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 166 insertions(+) diff --git a/drivers/net/pcs/pcs.c b/drivers/net/pcs/pcs.c index 67f9716f48fd..713b2ec22c97 100644 --- a/drivers/net/pcs/pcs.c +++ b/drivers/net/pcs/pcs.c @@ -22,6 +22,19 @@ struct fwnode_pcs_provider { static LIST_HEAD(fwnode_pcs_providers); static DEFINE_MUTEX(fwnode_pcs_mutex); +static BLOCKING_NOTIFIER_HEAD(fwnode_pcs_notify_list); + +int register_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_register(&fwnode_pcs_notify_list, nb); +} +EXPORT_SYMBOL_GPL(register_fwnode_pcs_notifier); + +int unregister_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return blocking_notifier_chain_unregister(&fwnode_pcs_notify_list, nb); +} +EXPORT_SYMBOL_GPL(unregister_fwnode_pcs_notifier); struct phylink_pcs *fwnode_pcs_simple_get(struct fwnode_reference_args *pcsspec, void *data) @@ -55,6 +68,10 @@ int fwnode_pcs_add_provider(struct fwnode_handle *fwnode, fwnode_dev_initialized(fwnode, true); + blocking_notifier_call_chain(&fwnode_pcs_notify_list, + FWNODE_PCS_PROVIDER_ADD, + fwnode); + return 0; } EXPORT_SYMBOL_GPL(fwnode_pcs_add_provider); @@ -150,6 +167,38 @@ struct phylink_pcs *fwnode_pcs_get(struct fwnode_handle *fwnode, unsigned int in } EXPORT_SYMBOL_GPL(fwnode_pcs_get); +struct phylink_pcs * +fwnode_phylink_pcs_get_from_fwnode(struct fwnode_handle *fwnode, + struct fwnode_handle *pcs_fwnode) +{ + struct fwnode_reference_args pcsspec; + int index = 0; + int ret; + + /* Loop until we find a matching PCS node or + * fwnode_parse_pcsspec() returns error + * if we don't have any other PCS reference to check. + */ + while (true) { + ret = fwnode_parse_pcsspec(fwnode, index, NULL, &pcsspec); + if (ret) + return ERR_PTR(ret); + + /* Exit loop if we found the matching PCS node */ + if (pcsspec.fwnode == pcs_fwnode) { + fwnode_handle_put(pcsspec.fwnode); + break; + } + + /* Check the next PCS reference */ + fwnode_handle_put(pcsspec.fwnode); + index++; + } + + return fwnode_pcs_get(fwnode, index); +} +EXPORT_SYMBOL_GPL(fwnode_phylink_pcs_get_from_fwnode); + unsigned int fwnode_phylink_pcs_count(struct fwnode_handle *fwnode) { struct fwnode_reference_args out_args; diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index ca4dad4b140a..0734c98498a9 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -62,6 +63,7 @@ struct phylink { /* List of available PCS */ struct list_head pcs_list; + struct notifier_block fwnode_pcs_nb; /* What interface are supported by the current link. * Can change on removal or addition of new PCS. @@ -1997,6 +1999,51 @@ static int phylink_fill_available_pcs(struct phylink *pl, return ret; } +static int pcs_provider_notify(struct notifier_block *self, + unsigned long val, void *data) +{ + struct phylink *pl = container_of(self, struct phylink, fwnode_pcs_nb); + struct fwnode_handle *pcs_fwnode = data; + struct phylink_pcs *pcs; + + /* Check if the just added PCS provider is + * in the phylink instance pcs-handle property. + */ + pcs = fwnode_phylink_pcs_get_from_fwnode(dev_fwnode(pl->config->dev), + pcs_fwnode); + if (IS_ERR(pcs)) + return NOTIFY_DONE; + + /* Add the PCS */ + rtnl_lock(); + + mutex_lock(&pl->state_mutex); + + /* Link PCS with phylink */ + list_add(&pcs->list, &pl->pcs_list); + pcs->phylink = pl; + + /* Refresh supported interfaces */ + phy_interface_copy(pl->supported_interfaces, + pl->config->supported_interfaces); + list_for_each_entry(pcs, &pl->pcs_list, list) + phy_interface_or(pl->supported_interfaces, + pl->supported_interfaces, + pcs->supported_interfaces); + + /* Force an interface reconfig if major config fail */ + if (pl->major_config_failed) + pl->force_major_config = true; + + mutex_unlock(&pl->state_mutex); + + rtnl_unlock(); + + phylink_run_resolve(pl); + + return NOTIFY_OK; +} + /** * phylink_create() - create a phylink instance * @config: a pointer to the target &struct phylink_config @@ -2068,6 +2115,12 @@ struct phylink *phylink_create(struct phylink_config *config, pl->supported_interfaces, pcs->supported_interfaces); + /* Register notifier for late PCS attach */ + if (!phy_interface_empty(config->pcs_interfaces)) { + pl->fwnode_pcs_nb.notifier_call = pcs_provider_notify; + register_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + } + pl->config = config; if (config->type == PHYLINK_NETDEV) { pl->netdev = to_net_dev(config->dev); @@ -2151,6 +2204,10 @@ void phylink_destroy(struct phylink *pl) if (pl->link_gpio) gpiod_put(pl->link_gpio); + /* Unregister notifier for late PCS attach */ + if (pl->fwnode_pcs_nb.notifier_call) + unregister_fwnode_pcs_notifier(&pl->fwnode_pcs_nb); + /* Drop link between PCS and phylink */ list_for_each_entry(pcs, &pl->pcs_list, list) pcs->phylink = NULL; diff --git a/include/linux/pcs/pcs.h b/include/linux/pcs/pcs.h index df1e6f32cfad..9de3f273428e 100644 --- a/include/linux/pcs/pcs.h +++ b/include/linux/pcs/pcs.h @@ -4,7 +4,36 @@ #include +enum fwnode_pcs_notify_event { + FWNODE_PCS_PROVIDER_ADD, +}; + #if IS_ENABLED(CONFIG_FWNODE_PCS) +/** + * register_fwnode_pcs_notifier - Register a notifier block for fwnode + * PCS events + * @nb: pointer to the notifier block + * + * Registers a notifier block to the fwnode_pcs_notify_list blocking + * notifier chain. This allows phylink instance to subscribe for + * PCS provider events. + * + * Returns: 0 or a negative error. + */ +int register_fwnode_pcs_notifier(struct notifier_block *nb); + +/** + * unregister_fwnode_pcs_notifier - Unregister a notifier block for fwnode + * PCS events + * @nb: pointer to the notifier block + * + * Unregisters a notifier block to the fwnode_pcs_notify_list blocking + * notifier chain. + * + * Returns: 0 or a negative error. + */ +int unregister_fwnode_pcs_notifier(struct notifier_block *nb); + /** * fwnode_pcs_get - Retrieves a PCS from a firmware node * @fwnode: firmware node @@ -20,6 +49,25 @@ struct phylink_pcs *fwnode_pcs_get(struct fwnode_handle *fwnode, unsigned int index); +/** + * fwnode_phylink_pcs_get_from_fwnode - Retrieves the PCS provided + * by the firmware node from a + * firmware node + * @fwnode: firmware node + * @pcs_fwnode: PCS firmware node + * + * Parse 'pcs-handle' in 'fwnode' and get the PCS that match + * 'pcs_fwnode' firmware node. + * + * Returns: a pointer to the phylink_pcs or a negative + * error pointer. Can return -EPROBE_DEFER if the PCS is not + * present in global providers list (either due to driver + * still needs to be probed or it failed to probe/removed) + */ +struct phylink_pcs * +fwnode_phylink_pcs_get_from_fwnode(struct fwnode_handle *fwnode, + struct fwnode_handle *pcs_fwnode); + /** * fwnode_phylink_pcs_count - count PCS entries described in firmware node * @fwnode: firmware node @@ -53,12 +101,24 @@ int fwnode_phylink_pcs_parse(struct fwnode_handle *fwnode, struct phylink_pcs **available_pcs, unsigned int num_pcs); #else +static inline int register_fwnode_pcs_notifier(struct notifier_block *nb) +{ + return -EOPNOTSUPP; +} + static inline struct phylink_pcs *fwnode_pcs_get(struct fwnode_handle *fwnode, int index) { return ERR_PTR(-ENOENT); } +static inline struct phylink_pcs * +fwnode_phylink_pcs_get_from_fwnode(struct fwnode_handle *fwnode, + struct fwnode_handle *pcs_fwnode) +{ + return ERR_PTR(-ENOENT); +} + static inline unsigned int fwnode_phylink_pcs_count(struct fwnode_handle *fwnode) { return 0; -- 2.53.0